HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM #5035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
approved these changes
Feb 17, 2023
| { | ||
| # pass through SIGHUP if we can | ||
| if [ -f "${HBASE_PID}" ] ; then | ||
| kill -s HUP "$(cat "${HBASE_PID}")" |
There was a problem hiding this comment.
You'd rather see the output than /dev/null it? And does the old pid stick around now?
There was a problem hiding this comment.
Testing in a docker container that disappears... I'm guessing that this script already handles the pid file, but let me look more closely...
There was a problem hiding this comment.
Oh. cleanupAfterRun handles the pid file.
…and SIGTERM Introduce separate `trap`s for SIGHUP vs. the rest. Treat `SIGINT`, `SIGKILL`, and `EXIT` identically, as before. Use the signal name without `SIG` prefix for increased portability, as per the POSIX man page for `trap`. `SIGTERM` handler will now honor `HBASE_STOP_TIMEOUT` as described in the file header.
ndimiduk
force-pushed
the
27651-hbase-daemon-sigs
branch
from
3e59f4d
to
4fdeece
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Looks like this works as we expect. Running in a kubernetes pod, launching the region server container with |
|
So in the old code we will always use |
Apache9
approved these changes
Mar 19, 2023
Correct. |
|
The new code will also honor the documented timeout between sending SIGTERM and SIGKILL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce separate
traps for SIGHUP vs. the rest. TreatSIGINT,SIGKILL, andEXITidentically, as before. Use the signal name withoutSIGprefix for increased portability, as per the POSIX man page fortrap.SIGTERMhandler will now honorHBASE_STOP_TIMEOUTas described in the file header.