Backport "HBASE-23102: Improper Usage of Map putIfAbsent (#828)" to branch-2 #5048

ndimiduk · 2023-02-21T15:44:55Z

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

petersomogyi

The backport looks good to me.

Apache-HBase · 2023-02-21T23:43:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 53s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 30s	branch-2 passed
+1 💚	compile	3m 7s	branch-2 passed
+1 💚	checkstyle	0m 55s	branch-2 passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 18s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 23s	the patch passed
+1 💚	compile	3m 4s	the patch passed
+1 💚	javac	3m 4s	the patch passed
+1 💚	checkstyle	0m 10s	The patch passed checkstyle in hbase-procedure
+1 💚	checkstyle	0m 33s	hbase-server: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6)
+1 💚	checkstyle	0m 9s	The patch passed checkstyle in hbase-rsgroup
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 37s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚	spotless	0m 42s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 40s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 31s	The patch does not generate ASF License warnings.
		42m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5048
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 36444b7032c3 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `3f25f33`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server hbase-rsgroup U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-02-22T03:01:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 46s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 56s	branch-2 passed
+1 💚	compile	1m 20s	branch-2 passed
+1 💚	shadedjars	5m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 5s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 57s	the patch passed
+1 💚	compile	1m 18s	the patch passed
+1 💚	javac	1m 18s	the patch passed
+1 💚	shadedjars	5m 18s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 54s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 25s	hbase-procedure in the patch passed.
-1 ❌	unit	204m 21s	hbase-server in the patch failed.
+1 💚	unit	4m 14s	hbase-rsgroup in the patch passed.
		239m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5048
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6e3f933523ac 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `3f25f33`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/testReport/
Max. process+thread count	2412 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server hbase-rsgroup U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-02-22T03:02:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 2s	branch-2 passed
+1 💚	compile	1m 40s	branch-2 passed
+1 💚	shadedjars	6m 20s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 6s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 9s	the patch passed
+1 💚	compile	1m 23s	the patch passed
+1 💚	javac	1m 23s	the patch passed
+1 💚	shadedjars	5m 24s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 55s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 28s	hbase-procedure in the patch passed.
-1 ❌	unit	203m 25s	hbase-server in the patch failed.
+1 💚	unit	4m 20s	hbase-rsgroup in the patch passed.
		240m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5048
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 297e5fe6c41c 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `3f25f33`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/testReport/
Max. process+thread count	2616 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server hbase-rsgroup U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-02-24T16:07:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 54s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 35s	branch-2 passed
+1 💚	compile	3m 4s	branch-2 passed
+1 💚	checkstyle	0m 57s	branch-2 passed
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 19s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 20s	the patch passed
+1 💚	compile	3m 5s	the patch passed
+1 💚	javac	3m 5s	the patch passed
+1 💚	checkstyle	0m 10s	The patch passed checkstyle in hbase-procedure
+1 💚	checkstyle	0m 34s	hbase-server: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6)
+1 💚	checkstyle	0m 10s	The patch passed checkstyle in hbase-rsgroup
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 36s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 40s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 30s	The patch does not generate ASF License warnings.
		42m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5048
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 982a917f0557 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `3f25f33`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server hbase-rsgroup U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-02-24T19:15:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 46s	branch-2 passed
+1 💚	compile	1m 0s	branch-2 passed
+1 💚	shadedjars	4m 26s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 39s	the patch passed
+1 💚	compile	0m 59s	the patch passed
+1 💚	javac	0m 59s	the patch passed
+1 💚	shadedjars	4m 24s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 28s	hbase-procedure in the patch passed.
+1 💚	unit	200m 59s	hbase-server in the patch passed.
+1 💚	unit	5m 13s	hbase-rsgroup in the patch passed.
		230m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5048
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux be37804fa4e7 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `3f25f33`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/2/testReport/
Max. process+thread count	2532 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server hbase-rsgroup U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-02-24T19:15:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 53s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 21s	branch-2 passed
+1 💚	compile	1m 19s	branch-2 passed
+1 💚	shadedjars	4m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 53s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 21s	the patch passed
+1 💚	compile	1m 19s	the patch passed
+1 💚	javac	1m 19s	the patch passed
+1 💚	shadedjars	4m 31s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 53s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 24s	hbase-procedure in the patch passed.
+1 💚	unit	198m 55s	hbase-server in the patch passed.
+1 💚	unit	4m 24s	hbase-rsgroup in the patch passed.
		230m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5048
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 684bea657100 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `3f25f33`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/2/testReport/
Max. process+thread count	2526 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server hbase-rsgroup U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5048/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2023-02-27T10:23:54Z

Thanks for looking at this older one folks.

HBASE-23102: Improper Usage of Map putIfAbsent (apache#828)

2b1b51e

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

ndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Feb 21, 2023

ndimiduk requested review from bharathv, wchevreuil and petersomogyi February 21, 2023 15:44

ndimiduk mentioned this pull request Feb 21, 2023

Backport "HBASE-23561 Look up of Region in Master by encoded region name is O(n)" and addendum to branch-2 #5049

Merged

petersomogyi approved these changes Feb 21, 2023

View reviewed changes

fix TestBalancer

1723067

petersomogyi approved these changes Feb 24, 2023

View reviewed changes

Apache9 approved these changes Feb 25, 2023

View reviewed changes

ndimiduk merged commit 3b6d8c3 into apache:branch-2 Feb 27, 2023

ndimiduk deleted the 23102-improper-use-of-map-putifabsent-branch-2 branch February 27, 2023 10:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport "HBASE-23102: Improper Usage of Map putIfAbsent (#828)" to branch-2 #5048

Backport "HBASE-23102: Improper Usage of Map putIfAbsent (#828)" to branch-2 #5048

ndimiduk commented Feb 21, 2023

petersomogyi left a comment

Apache-HBase commented Feb 21, 2023

Apache-HBase commented Feb 22, 2023

Apache-HBase commented Feb 22, 2023

Apache-HBase commented Feb 24, 2023

Apache-HBase commented Feb 24, 2023

Apache-HBase commented Feb 24, 2023

ndimiduk commented Feb 27, 2023

Backport "HBASE-23102: Improper Usage of Map putIfAbsent (#828)" to branch-2 #5048

Backport "HBASE-23102: Improper Usage of Map putIfAbsent (#828)" to branch-2 #5048

Conversation

ndimiduk commented Feb 21, 2023

petersomogyi left a comment

Choose a reason for hiding this comment

Apache-HBase commented Feb 21, 2023

Apache-HBase commented Feb 22, 2023

Apache-HBase commented Feb 22, 2023

Apache-HBase commented Feb 24, 2023

Apache-HBase commented Feb 24, 2023

Apache-HBase commented Feb 24, 2023

ndimiduk commented Feb 27, 2023