HBASE-27859:HMaster.getCompactionState can happen NPE when region state is closed #5232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apache9
reviewed
May 11, 2023
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
guluo2016
commented
May 12, 2023
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
reviewed
May 31, 2023
| @@ -4155,6 +4155,11 @@ public CompactionState getCompactionState(final TableName tableName) { | |||
| continue; | |||
| } | |||
| RegionMetrics regionMetrics = sl.getRegionMetrics().get(regionInfo.getRegionName()); | |||
| if (regionMetrics == null) { | |||
| LOG.error("Can not get compaction details for the region: " | |||
| + regionInfo.getRegionNameAsString() + " , it may be not online."); | |||
There was a problem hiding this comment.
Please use parameterised logging.
There was a problem hiding this comment.
Thanks for the review. The update has been made.
At the same time , I changed the log level to WARN, as it more suitable here, I think.
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
wchevreuil
reviewed
Jun 2, 2023
| @@ -4155,6 +4155,12 @@ public CompactionState getCompactionState(final TableName tableName) { | |||
| continue; | |||
| } | |||
| RegionMetrics regionMetrics = sl.getRegionMetrics().get(regionInfo.getRegionName()); | |||
| if (regionMetrics == null) { | |||
| LOG.warn(String.format( | |||
| "Can not get compaction details for the region: %s , it may be not online.", | |||
There was a problem hiding this comment.
log4j already has the parameterised feature, there's no need to use String.format here. Just do:
LOG.warn("Can not get compaction details for the region: {} , it may be not online.", regionInfo.getRegionNameAsString());
There was a problem hiding this comment.
The update has been made, thanks
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
wchevreuil
approved these changes
Jun 7, 2023
Apache9
approved these changes
Jul 5, 2023
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…te is closed (apache#5232) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit b2e2abe) (cherry picked from commit d8b9d82) Change-Id: Iae2d47e8dbf1fd32bdd8d64ad784e6844cb4b8b7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details see : HBASE-27859