HBASE-27858 Update surefire version to 3.1.0 and use SurefireForkNodeFactory #5234

jonathan-albrecht-ibm · 2023-05-12T11:42:27Z

Surefire version updated from 3.0.0-M6 -> 3.1.0.

SurefireForkNodeFactory is a new strategy to control how the forked nodes communicate with the main maven process. It uses a tcp channel instead of pipes and fixes some corrupted messages seen in the s390x build.

…Factory Surefire version updated from 3.0.0-M6 -> 3.1.0. SurefireForkNodeFactory is a new strategy to control how the forked nodes communicate with the main maven process. It uses a tcp channel instead of pipes and fixes some corrupted messages seen in the s390x build. Signed-off-by: Jonathan Albrecht <jonathan.albrecht@ibm.com>

Apache-HBase · 2023-05-12T12:24:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 45s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 44s	master passed
+1 💚	compile	4m 48s	master passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 19s	the patch passed
+1 💚	compile	4m 44s	the patch passed
+1 💚	javac	4m 45s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	12m 34s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		38m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5234
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile
uname	Linux af7a7c668b76 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e343584`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-12T17:01:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 24s	master passed
+1 💚	compile	2m 34s	master passed
+1 💚	shadedjars	5m 24s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 31s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 48s	the patch passed
+1 💚	compile	2m 26s	the patch passed
+1 💚	javac	2m 26s	the patch passed
+1 💚	shadedjars	5m 27s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 18s	the patch passed
		_ Other Tests _
-1 ❌	unit	279m 28s	root in the patch failed.
		315m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5234
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2900ea20a0e2 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e343584`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/1/testReport/
Max. process+thread count	5014 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-12T17:33:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 23s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
-1 ❌	mvninstall	1m 4s	root in master failed.
+1 💚	compile	1m 32s	master passed
+1 💚	shadedjars	4m 40s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 16s	root in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 45s	the patch passed
+1 💚	compile	1m 29s	the patch passed
+1 💚	javac	1m 29s	the patch passed
+1 💚	shadedjars	4m 37s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	1m 20s	root generated 83 new + 1 unchanged - 0 fixed = 84 total (was 1)
		_ Other Tests _
-1 ❌	unit	325m 22s	root in the patch failed.
		348m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5234
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5f8a66a7e886 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e343584`
Default Java	Temurin-1.8.0_352-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/1/artifact/yetus-jdk8-hadoop3-check/output/branch-mvninstall-root.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/1/artifact/yetus-jdk8-hadoop3-check/output/branch-javadoc-root.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-root.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/1/testReport/
Max. process+thread count	5105 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-13T01:32:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 46s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 19s	master passed
+1 💚	compile	4m 43s	master passed
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 16s	the patch passed
+1 💚	compile	4m 38s	the patch passed
+1 💚	javac	4m 38s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	12m 20s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		37m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5234
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile
uname	Linux 485238226cd8 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `220eacf`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-13T06:00:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 0s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 22s	master passed
+1 💚	compile	1m 52s	master passed
+1 💚	shadedjars	4m 24s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 52s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 19s	the patch passed
+1 💚	compile	1m 51s	the patch passed
+1 💚	javac	1m 51s	the patch passed
+1 💚	shadedjars	4m 27s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 52s	the patch passed
		_ Other Tests _
+1 💚	unit	275m 28s	root in the patch passed.
		305m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5234
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d94c09982cce 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `220eacf`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/2/testReport/
Max. process+thread count	7679 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-13T07:57:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 9s	master passed
+1 💚	compile	1m 31s	master passed
+1 💚	shadedjars	4m 45s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 21s	master passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	2m 47s	root in the patch failed.
+1 💚	compile	1m 25s	the patch passed
+1 💚	javac	1m 25s	the patch passed
+1 💚	shadedjars	4m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 20s	the patch passed
		_ Other Tests _
+1 💚	unit	395m 44s	root in the patch passed.
		422m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5234
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 77f123030738 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `220eacf`
Default Java	Temurin-1.8.0_352-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/2/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/2/testReport/
Max. process+thread count	8265 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5234/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2023-05-13T10:43:37Z

I think the problem is maven central is not very stable, or the network is not very stable. It fails with this

[ERROR] Plugin org.apache.maven.plugins:maven-failsafe-plugin:3.1.0 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.apache.maven.plugins:maven-failsafe-plugin:jar:3.1.0: Could not transfer artifact org.apache.maven.plugins:maven-failsafe-plugin:pom:3.1.0 from/to central (https://repo.maven.apache.org/maven2): transfer failed for https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-failsafe-plugin/3.1.0/maven-failsafe-plugin-3.1.0.pom: Connection reset -> [Help 1]

Let me merge.

…Factory (#5234) Surefire version updated from 3.0.0-M6 -> 3.1.0. SurefireForkNodeFactory is a new strategy to control how the forked nodes communicate with the main maven process. It uses a tcp channel instead of pipes and fixes some corrupted messages seen in the s390x build. Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 67612cc)

jonathan-albrecht-ibm · 2023-05-15T14:13:18Z

Thanks for reviewing and merging @Apache9!

…Factory (apache#5234) Surefire version updated from 3.0.0-M6 -> 3.1.0. SurefireForkNodeFactory is a new strategy to control how the forked nodes communicate with the main maven process. It uses a tcp channel instead of pipes and fixes some corrupted messages seen in the s390x build. Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 67612cc) (cherry picked from commit 3a68cdd) Change-Id: Ie632012d81c28fd7bba09f6a909043e2033aebcc

Apache9 approved these changes May 12, 2023

View reviewed changes

Apache9 merged commit 67612cc into apache:master May 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27858 Update surefire version to 3.1.0 and use SurefireForkNodeFactory #5234

HBASE-27858 Update surefire version to 3.1.0 and use SurefireForkNodeFactory #5234

jonathan-albrecht-ibm commented May 12, 2023

Apache-HBase commented May 12, 2023

Apache-HBase commented May 12, 2023

Apache-HBase commented May 12, 2023

Apache-HBase commented May 13, 2023

Apache-HBase commented May 13, 2023

Apache-HBase commented May 13, 2023

Apache9 commented May 13, 2023

jonathan-albrecht-ibm commented May 15, 2023

HBASE-27858 Update surefire version to 3.1.0 and use SurefireForkNodeFactory #5234

HBASE-27858 Update surefire version to 3.1.0 and use SurefireForkNodeFactory #5234

Conversation

jonathan-albrecht-ibm commented May 12, 2023

Apache-HBase commented May 12, 2023

Apache-HBase commented May 12, 2023

Apache-HBase commented May 12, 2023

Apache-HBase commented May 13, 2023

Apache-HBase commented May 13, 2023

Apache-HBase commented May 13, 2023

Apache9 commented May 13, 2023

jonathan-albrecht-ibm commented May 15, 2023