HBASE-22806 Recreating a deleted column family brings back the delete… #530

pankaj72981 · 2019-08-23T11:48:21Z

Deleted CF dirs should be cleared after region reopen.

…d cells

Apache-HBase · 2019-08-23T15:28:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	43	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	351	master passed
+1	compile	60	master passed
+1	checkstyle	76	master passed
+1	shadedjars	282	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	39	master passed
0	spotbugs	267	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	265	master passed
		_ Patch Compile Tests _
+1	mvninstall	319	the patch passed
+1	compile	57	the patch passed
+1	javac	57	the patch passed
+1	checkstyle	74	the patch passed
+1	whitespace	1	The patch has no whitespace issues.
+1	shadedjars	278	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	967	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	37	the patch passed
+1	findbugs	282	the patch passed
		_ Other Tests _
-1	unit	9231	hbase-server in the patch failed.
+1	asflicense	25	The patch does not generate ASF License warnings.
		12775

Reason	Tests
Failed junit tests	hadoop.hbase.master.assignment.TestOpenRegionProcedureHang

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/1/artifact/out/Dockerfile
GITHUB PR	#530
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux da39e322ff56 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-530/out/precommit/personality/provided.sh
git revision	master / `767bb15`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/1/testReport/
Max. process+thread count	4819 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

saintstack

I like the tests. Can you say how it fixes the problem Pankaj? I like how straightforward this is.

Apache-HBase · 2019-08-23T22:59:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	82	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	357	master passed
+1	compile	57	master passed
+1	checkstyle	90	master passed
+1	shadedjars	297	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	38	master passed
0	spotbugs	239	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	236	master passed
		_ Patch Compile Tests _
+1	mvninstall	333	the patch passed
+1	compile	58	the patch passed
+1	javac	58	the patch passed
+1	checkstyle	89	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	299	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1035	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	36	the patch passed
+1	findbugs	265	the patch passed
		_ Other Tests _
-1	unit	14806	hbase-server in the patch failed.
+1	asflicense	31	The patch does not generate ASF License warnings.
		18515

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/2/artifact/out/Dockerfile
GITHUB PR	#530
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 032e2b7ac797 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-530/out/precommit/personality/provided.sh
git revision	master / `74fb204`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/2/testReport/
Max. process+thread count	4661 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-24T01:05:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	71	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	363	master passed
+1	compile	57	master passed
+1	checkstyle	74	master passed
+1	shadedjars	297	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	34	master passed
0	spotbugs	258	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	249	master passed
		_ Patch Compile Tests _
+1	mvninstall	306	the patch passed
+1	compile	57	the patch passed
+1	javac	57	the patch passed
+1	checkstyle	74	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	301	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1031	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	31	the patch passed
+1	findbugs	257	the patch passed
		_ Other Tests _
-1	unit	16147	hbase-server in the patch failed.
+1	asflicense	29	The patch does not generate ASF License warnings.
		19806

Reason	Tests
Failed junit tests	hadoop.hbase.master.TestAssignmentManagerMetrics
	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.master.assignment.TestOpenRegionProcedureHang
	hadoop.hbase.replication.TestReplicationSmallTestsSync
	hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/3/artifact/out/Dockerfile
GITHUB PR	#530
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 995b7b853279 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-530/out/precommit/personality/provided.sh
git revision	master / `2d45801`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/3/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/3/testReport/
Max. process+thread count	4932 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-24T01:24:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	63	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	323	master passed
+1	compile	53	master passed
+1	checkstyle	73	master passed
+1	shadedjars	263	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	34	master passed
0	spotbugs	236	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	234	master passed
		_ Patch Compile Tests _
+1	mvninstall	288	the patch passed
+1	compile	54	the patch passed
+1	javac	54	the patch passed
+1	checkstyle	78	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	283	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	944	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	32	the patch passed
+1	findbugs	239	the patch passed
		_ Other Tests _
-1	unit	15550	hbase-server in the patch failed.
+1	asflicense	66	The patch does not generate ASF License warnings.
		18974

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/4/artifact/out/Dockerfile
GITHUB PR	#530
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux ea448e3a98dc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-530/out/precommit/personality/provided.sh
git revision	master / `2d45801`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/4/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/4/testReport/
Max. process+thread count	5184 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/4/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-24T03:36:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	34	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	413	master passed
+1	compile	77	master passed
+1	checkstyle	113	master passed
+1	shadedjars	368	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	45	master passed
0	spotbugs	321	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	320	master passed
		_ Patch Compile Tests _
+1	mvninstall	387	the patch passed
+1	compile	75	the patch passed
+1	javac	75	the patch passed
+1	checkstyle	116	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	382	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1254	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	45	the patch passed
+1	findbugs	335	the patch passed
		_ Other Tests _
+1	unit	9545	hbase-server in the patch passed.
+1	asflicense	28	The patch does not generate ASF License warnings.
		13993

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/5/artifact/out/Dockerfile
GITHUB PR	#530
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 4e12fa64b0bf 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-530/out/precommit/personality/provided.sh
git revision	master / `504fc52`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/5/testReport/
Max. process+thread count	4683 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/5/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-24T05:51:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	38	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	320	master passed
+1	compile	54	master passed
+1	checkstyle	75	master passed
+1	shadedjars	269	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	34	master passed
0	spotbugs	245	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	243	master passed
		_ Patch Compile Tests _
+1	mvninstall	294	the patch passed
+1	compile	53	the patch passed
+1	javac	53	the patch passed
+1	checkstyle	73	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	289	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1002	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	33	the patch passed
+1	findbugs	268	the patch passed
		_ Other Tests _
+1	unit	8647	hbase-server in the patch passed.
+1	asflicense	23	The patch does not generate ASF License warnings.
		12110

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/7/artifact/out/Dockerfile
GITHUB PR	#530
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 957d2ccf09d0 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-530/out/precommit/personality/provided.sh
git revision	master / `ee9d986`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/7/testReport/
Max. process+thread count	4296 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/7/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-24T07:48:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	119	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	363	master passed
+1	compile	63	master passed
+1	checkstyle	82	master passed
+1	shadedjars	292	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	38	master passed
0	spotbugs	270	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	267	master passed
		_ Patch Compile Tests _
+1	mvninstall	323	the patch passed
+1	compile	62	the patch passed
+1	javac	62	the patch passed
+1	checkstyle	79	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	282	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1153	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	38	the patch passed
+1	findbugs	289	the patch passed
		_ Other Tests _
-1	unit	17993	hbase-server in the patch failed.
+1	asflicense	30	The patch does not generate ASF License warnings.
		21938

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAsyncSnapshotAdminApi
	hadoop.hbase.master.procedure.TestTruncateTableProcedure
	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.client.TestAsyncTableAdminApi
	hadoop.hbase.master.procedure.TestSCPWithReplicas

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/6/artifact/out/Dockerfile
GITHUB PR	#530
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux e4fa3a29bb4c 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-530/out/precommit/personality/provided.sh
git revision	master / `ee9d986`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/6/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/6/testReport/
Max. process+thread count	5206 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/6/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-24T07:52:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	40	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	378	master passed
+1	compile	53	master passed
+1	checkstyle	75	master passed
+1	shadedjars	265	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	34	master passed
0	spotbugs	249	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	246	master passed
		_ Patch Compile Tests _
+1	mvninstall	292	the patch passed
+1	compile	52	the patch passed
+1	javac	52	the patch passed
+1	checkstyle	72	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	269	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	917	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	31	the patch passed
+1	findbugs	264	the patch passed
		_ Other Tests _
-1	unit	9057	hbase-server in the patch failed.
+1	asflicense	22	The patch does not generate ASF License warnings.
		12428

Reason	Tests
Failed junit tests	hadoop.hbase.master.assignment.TestOpenRegionProcedureHang

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/9/artifact/out/Dockerfile
GITHUB PR	#530
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux d95f9b22ebfc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-530/out/precommit/personality/provided.sh
git revision	master / `ee9d986`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/9/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/9/testReport/
Max. process+thread count	4950 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/9/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-24T12:14:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	44	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	346	master passed
+1	compile	60	master passed
+1	checkstyle	83	master passed
+1	shadedjars	300	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	45	master passed
0	spotbugs	288	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	286	master passed
		_ Patch Compile Tests _
+1	mvninstall	330	the patch passed
+1	compile	61	the patch passed
+1	javac	61	the patch passed
+1	checkstyle	81	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	302	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1033	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	38	the patch passed
+1	findbugs	286	the patch passed
		_ Other Tests _
+1	unit	9444	hbase-server in the patch passed.
+1	asflicense	26	The patch does not generate ASF License warnings.
		13161

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/11/artifact/out/Dockerfile
GITHUB PR	#530
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 6e9f629b0f6b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-530/out/precommit/personality/provided.sh
git revision	master / `94155fe`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/11/testReport/
Max. process+thread count	4849 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/11/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

pankaj72981 · 2019-08-24T16:01:41Z

I like the tests. Can you say how it fixes the problem Pankaj? I like how straightforward this is.

Thanks Stack sir for looking into this.

As I mentioned earlier,
https://issues.apache.org/jira/browse/HBASE-22806?focusedCommentId=16911052&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16911052

During region close (reopen region close the region first and then open) memstore content will be flushed to FS, at RS side we dont have CF existence validation. So CF dir will be recreated with the HFile.

Moving MODIFY_TABLE_REOPEN_ALL_REGIONS state before MODIFY_TABLE_DELETE_FS_LAYOUT will solve the problem.

Apache-HBase · 2019-08-24T20:05:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	97	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	356	master passed
+1	compile	58	master passed
+1	checkstyle	94	master passed
+1	shadedjars	305	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	41	master passed
0	spotbugs	272	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	270	master passed
		_ Patch Compile Tests _
+1	mvninstall	352	the patch passed
+1	compile	62	the patch passed
+1	javac	62	the patch passed
+1	checkstyle	95	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	358	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1323	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	38	the patch passed
+1	findbugs	277	the patch passed
		_ Other Tests _
-1	unit	14962	hbase-server in the patch failed.
+1	asflicense	27	The patch does not generate ASF License warnings.
		19186

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSideWithCoprocessor
	hadoop.hbase.master.TestMasterShutdown

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/12/artifact/out/Dockerfile
GITHUB PR	#530
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 61a8cf8cd180 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-530/out/precommit/personality/provided.sh
git revision	master / `554b253`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/12/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/12/testReport/
Max. process+thread count	4749 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-530/12/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

saintstack

Ok. I get it now. I re-read your comment up in the JIRA. Let me merge.

…d cells (#530) Signed-off-by: stack <stack@apache.org>

pankaj72981 · 2019-08-25T10:23:55Z

Ok. I get it now. I re-read your comment up in the JIRA. Let me merge.

Thanks Stack Sir. 👍

…d cells (apache#530) Signed-off-by: stack <stack@apache.org>

…d cells (apache#530) Signed-off-by: stack <stack@apache.org> (cherry picked from commit b55b676) Change-Id: Ieebc5ba5f3f12473526cce215e274fb6e13b10d4

HBASE-22806 Recreating a deleted column family brings back the delete…

c79b3a4

…d cells

saintstack reviewed Aug 23, 2019

View reviewed changes

saintstack approved these changes Aug 25, 2019

View reviewed changes

saintstack merged commit ae107bd into apache:master Aug 25, 2019

asfgit pushed a commit that referenced this pull request Aug 25, 2019

HBASE-22806 Recreating a deleted column family brings back the delete…

cb5651b

…d cells (#530) Signed-off-by: stack <stack@apache.org>

asfgit pushed a commit that referenced this pull request Aug 25, 2019

HBASE-22806 Recreating a deleted column family brings back the delete…

b55b676

…d cells (#530) Signed-off-by: stack <stack@apache.org>

asfgit pushed a commit that referenced this pull request Aug 25, 2019

HBASE-22806 Recreating a deleted column family brings back the delete…

902d4c2

…d cells (#530) Signed-off-by: stack <stack@apache.org>

infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020

HBASE-22806 Recreating a deleted column family brings back the delete…

16f6d75

…d cells (apache#530) Signed-off-by: stack <stack@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-22806 Recreating a deleted column family brings back the delete… #530

HBASE-22806 Recreating a deleted column family brings back the delete… #530

pankaj72981 commented Aug 23, 2019

Apache-HBase commented Aug 23, 2019

saintstack left a comment

Apache-HBase commented Aug 23, 2019

Apache-HBase commented Aug 24, 2019

Apache-HBase commented Aug 24, 2019

Apache-HBase commented Aug 24, 2019

Apache-HBase commented Aug 24, 2019

Apache-HBase commented Aug 24, 2019

Apache-HBase commented Aug 24, 2019

Apache-HBase commented Aug 24, 2019

pankaj72981 commented Aug 24, 2019

Apache-HBase commented Aug 24, 2019

saintstack left a comment

pankaj72981 commented Aug 25, 2019

HBASE-22806 Recreating a deleted column family brings back the delete… #530

HBASE-22806 Recreating a deleted column family brings back the delete… #530

Conversation

pankaj72981 commented Aug 23, 2019

Apache-HBase commented Aug 23, 2019

saintstack left a comment

Choose a reason for hiding this comment

Apache-HBase commented Aug 23, 2019

Apache-HBase commented Aug 24, 2019

Apache-HBase commented Aug 24, 2019

Apache-HBase commented Aug 24, 2019

Apache-HBase commented Aug 24, 2019

Apache-HBase commented Aug 24, 2019

Apache-HBase commented Aug 24, 2019

Apache-HBase commented Aug 24, 2019

pankaj72981 commented Aug 24, 2019

Apache-HBase commented Aug 24, 2019

saintstack left a comment

Choose a reason for hiding this comment

pankaj72981 commented Aug 25, 2019