HBASE-27717 Add rsgroup name for dead region servers on master UI #5361

xieyupei · 2023-08-20T15:49:29Z

No description provided.

Apache-HBase · 2023-08-20T16:04:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 1s	branch-2 passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 27s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		9m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5361/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5361
Optional Tests	dupname asflicense javac spotless
uname	Linux f6485c8677dd 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `fbd258f`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5361/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

xieyupei · 2023-08-20T16:11:15Z

Apache-HBase · 2023-08-20T19:24:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 33s	branch-2 passed
+1 💚	javadoc	0m 23s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 7s	the patch passed
+1 💚	javadoc	0m 21s	the patch passed
		_ Other Tests _
+1 💚	unit	198m 57s	hbase-server in the patch passed.
		209m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5361/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5361
Optional Tests	javac javadoc unit
uname	Linux 9bdd797e88ea 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `fbd258f`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5361/1/testReport/
Max. process+thread count	4805 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5361/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-08-20T19:26:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 52s	branch-2 passed
+1 💚	javadoc	0m 24s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 32s	the patch passed
+1 💚	javadoc	0m 21s	the patch passed
		_ Other Tests _
+1 💚	unit	199m 56s	hbase-server in the patch passed.
		210m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5361/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5361
Optional Tests	javac javadoc unit
uname	Linux 4dbba2ff98ec 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `fbd258f`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5361/1/testReport/
Max. process+thread count	4752 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5361/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2023-08-22T07:58:16Z

hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon

+        ServerName [] deadServerNames = deadServers.toArray(new ServerName[deadServers.size()]);
+        Arrays.sort(deadServerNames);
+        for (ServerName deadServerName: deadServerNames) {
+            String rsGroupName = null;


The indentation is a bit strange? We use 2 spaces instead of 4 spaces

ok, i will fix it

Apache-HBase · 2023-08-23T14:29:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 40s	branch-2 passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 27s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		8m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5361/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5361
Optional Tests	dupname asflicense javac spotless
uname	Linux 0b903fcd8465 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `fbd258f`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5361/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-08-23T17:51:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 50s	branch-2 passed
+1 💚	javadoc	0m 23s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	200m 1s	hbase-server in the patch passed.
		210m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5361/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5361
Optional Tests	javac javadoc unit
uname	Linux f057aa9c4647 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `fbd258f`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5361/2/testReport/
Max. process+thread count	4776 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5361/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-08-23T18:02:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 17s	branch-2 passed
+1 💚	javadoc	0m 25s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 11s	the patch passed
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	211m 30s	hbase-server in the patch passed.
		221m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5361/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5361
Optional Tests	javac javadoc unit
uname	Linux 1f1c1b801e84 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `fbd258f`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5361/2/testReport/
Max. process+thread count	4190 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5361/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

HBASE-27717 Add rsgroup name for dead region servers on master UI

bd890da

sunhelly approved these changes Aug 22, 2023

View reviewed changes

Apache9 reviewed Aug 22, 2023

View reviewed changes

indentation 2 spaces

002f773

xieyupei requested review from Apache9 and sunhelly August 23, 2023 14:19

Apache9 approved these changes Aug 26, 2023

View reviewed changes

Apache9 merged commit b973ae4 into apache:branch-2 Aug 27, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27717 Add rsgroup name for dead region servers on master UI #5361

HBASE-27717 Add rsgroup name for dead region servers on master UI #5361

xieyupei commented Aug 20, 2023

Apache-HBase commented Aug 20, 2023

xieyupei commented Aug 20, 2023

Apache-HBase commented Aug 20, 2023

Apache-HBase commented Aug 20, 2023

Apache9 Aug 22, 2023

xieyupei Aug 23, 2023

Apache-HBase commented Aug 23, 2023

Apache-HBase commented Aug 23, 2023

Apache-HBase commented Aug 23, 2023

HBASE-27717 Add rsgroup name for dead region servers on master UI #5361

HBASE-27717 Add rsgroup name for dead region servers on master UI #5361

Conversation

xieyupei commented Aug 20, 2023

Apache-HBase commented Aug 20, 2023

xieyupei commented Aug 20, 2023

Apache-HBase commented Aug 20, 2023

Apache-HBase commented Aug 20, 2023

Apache9 Aug 22, 2023

Choose a reason for hiding this comment

xieyupei Aug 23, 2023

Choose a reason for hiding this comment

Apache-HBase commented Aug 23, 2023

Apache-HBase commented Aug 23, 2023

Apache-HBase commented Aug 23, 2023