HBASE-28066 Drop duplicate test class TestShellRSGroups.java #5387

NihalJain · 2023-09-06T18:50:33Z

No description provided.

NihalJain · 2023-09-06T18:55:19Z

Just noticed that TestShellRSGroups.java is misplaced and also because of same misplacement spotless skipped this file. I am assuming this file must have been misplaced due to human error, hence raised this PR.

Apache-HBase · 2023-09-06T19:30:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 44s	master passed
+1 💚	compile	0m 15s	master passed
+1 💚	shadedjars	4m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 36s	the patch passed
+1 💚	compile	0m 15s	the patch passed
+1 💚	javac	0m 15s	the patch passed
+1 💚	shadedjars	4m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 9s	hbase-shell in the patch passed.
		24m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5387/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5387
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 28ee1072c977 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `97d512b`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5387/1/testReport/
Max. process+thread count	1563 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5387/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-06T19:30:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 3s	master passed
+1 💚	compile	0m 15s	master passed
+1 💚	checkstyle	0m 7s	master passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 0s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 41s	the patch passed
+1 💚	compile	0m 14s	the patch passed
+1 💚	javac	0m 14s	the patch passed
+1 💚	checkstyle	0m 6s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	10m 22s	Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 0s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		25m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5387/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5387
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux b43472c23c6e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `97d512b`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5387/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-06T19:30:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 29s	master passed
+1 💚	compile	0m 11s	master passed
+1 💚	shadedjars	4m 54s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 14s	the patch passed
+1 💚	compile	0m 12s	the patch passed
+1 💚	javac	0m 12s	the patch passed
+1 💚	shadedjars	4m 55s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 7s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 40s	hbase-shell in the patch passed.
		25m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5387/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5387
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux be85d2908645 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `97d512b`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5387/1/testReport/
Max. process+thread count	1729 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5387/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2023-09-06T19:46:31Z

Just found another class https://github.com/apache/hbase/blob/master/hbase-shell/src/test/java/org/apache/hadoop/hbase/client/TestRSGroupShell.java which seems to be same as https://github.com/apache/hbase/blob/master/hbase-shell/src/test/rsgroup/org/apache/hadoop/hbase/client/rsgroup/TestShellRSGroups.java
Not sure though, need to verify.

NihalJain · 2023-09-06T19:55:07Z

Also, running Hbase::RSGroupShellTest from TestShellRSGroups.java#L98C7-L98C67 should be same as running rsgroup_shell_test.rb in TestRSGroupShell.java#L48C1-L50C4.
Hence, I am guessing TestShellRSGroups.java must be duplicate, will check the test run logs and update here.

NihalJain · 2023-09-06T20:44:14Z

Ran mvn test -pl :hbase-shell -Dtest=TestShellRSGroups,TestRSGroupShell and was able to verify both classes run same set of tests.

Also same tables were created in both cases:

➜  surefire-reports git:(HBASE-28066) ll
total 10104
-rw-r--r--  1 nihjain  staff   1.0M Sep  7 01:54 TEST-org.apache.hadoop.hbase.client.TestRSGroupShell.xml
-rw-r--r--  1 nihjain  staff   855K Sep  7 01:54 TEST-org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups.xml
-rw-r--r--  1 nihjain  staff   1.1M Sep  7 01:54 org.apache.hadoop.hbase.client.TestRSGroupShell-output.txt
-rw-r--r--  1 nihjain  staff   344B Sep  7 01:54 org.apache.hadoop.hbase.client.TestRSGroupShell.txt
-rw-r--r--  1 nihjain  staff   963K Sep  7 01:54 org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups-output.txt
-rw-r--r--  1 nihjain  staff   362B Sep  7 01:54 org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups.txt

➜  surefire-reports git:(HBASE-28066) grep "Created table test_table" *-output.txt
org.apache.hadoop.hbase.client.TestRSGroupShell-output.txt:Created table test_table
org.apache.hadoop.hbase.client.TestRSGroupShell-output.txt:Created table test_table
org.apache.hadoop.hbase.client.TestRSGroupShell-output.txt:Created table test_table
org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups-output.txt:Created table test_table
org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups-output.txt:Created table test_table
org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups-output.txt:Created table test_table

➜  surefire-reports git:(HBASE-28066) grep "Created table test_namespace:test_ns_table" *-output.txt
org.apache.hadoop.hbase.client.TestRSGroupShell-output.txt:Created table test_namespace:test_ns_table
org.apache.hadoop.hbase.client.TestRSGroupShell-output.txt:Created table test_namespace:test_ns_table2
org.apache.hadoop.hbase.client.TestRSGroupShell-output.txt:Created table test_namespace:test_ns_table
org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups-output.txt:Created table test_namespace:test_ns_table
org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups-output.txt:Created table test_namespace:test_ns_table2
org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups-output.txt:Created table test_namespace:test_ns_table

➜  surefire-reports git:(HBASE-28066) grep "Created table test_namespace:test_ns_table2" *-output.txt
org.apache.hadoop.hbase.client.TestRSGroupShell-output.txt:Created table test_namespace:test_ns_table2
org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups-output.txt:Created table test_namespace:test_ns_table2

Sample test run logs from TestRSGroupShell

2023-09-07T01:54:15,611 INFO  [Listener at localhost/52752 {}] client.AbstractTestShell(93): Starting ruby tests. includes: rsgroup_shell_test.rb excludes: 
Skip formatter_test.rb because of not included
Skip list_tables_test.rb because of not included
Skip converter_test.rb because of not included
Skip list_locks_test.rb because of not included
Skip list_procedures_test.rb because of not included
Skip commands_test.rb because of not included
Skip noninteractive_test.rb because of not included
Skip sftchange_shell_test.rb because of not included
Skip shell_test.rb because of not included
Skip quotas_test.rb because of not included
Skip replication_admin_test.rb because of not included
Skip taskmonitor_test.rb because of not included
Skip hbase_test.rb because of not included
Skip admin_test.rb because of not included
Skip balancer_utils_test.rb because of not included
Skip admin2_test.rb because of not included
Skip table_test.rb because of not included
Skip security_admin_test.rb because of not included
Skip visibility_labels_admin_test.rb because of not included
Loaded suite src/test/ruby/tests_runner
Started

Sample test run logs from TestShellRSGroups

2023-09-07T01:54:15,791 INFO  [Listener at localhost/52758 {}] hbase.ResourceChecker(147): before: client.rsgroup.TestShellRSGroups#testRunShellTests Thread=497, OpenFileDescriptor=812, MaxFileDescriptor=10240, SystemLoadAverage=1399, ProcessCount=556, AvailableMemoryMB=4310
loading test file 'formatter_test.rb'.
loading test file 'list_tables_test.rb'.
loading test file 'converter_test.rb'.
loading test file 'list_locks_test.rb'.
loading test file 'list_procedures_test.rb'.
loading test file 'commands_test.rb'.
loading test file 'noninteractive_test.rb'.
loading test file 'sftchange_shell_test.rb'.
loading test file 'shell_test.rb'.
loading test file 'quotas_test.rb'.
loading test file 'replication_admin_test.rb'.
loading test file 'taskmonitor_test.rb'.
loading test file 'hbase_test.rb'.
loading test file 'admin_test.rb'.
loading test file 'balancer_utils_test.rb'.
loading test file 'admin2_test.rb'.
src/test/ruby/hbase/admin2_test.rb:386: warning: `+' after local variable or literal is interpreted as binary operator
src/test/ruby/hbase/admin2_test.rb:386: warning: even though it seems like unary operator
loading test file 'table_test.rb'.
loading test file 'security_admin_test.rb'.
loading test file 'visibility_labels_admin_test.rb'.
Only running tests that match Hbase::RSGroupShellTest
Loaded suite src/test/ruby/tests_runner
Started

Also introduced an assertion error in one of tests in rsgroup_shell_test.rb, both the classes failed (as expected), validating that they are duplicate:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups
[INFO] Running org.apache.hadoop.hbase.client.TestRSGroupShell
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 31.657 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestRSGroupShell
[ERROR] org.apache.hadoop.hbase.client.TestRSGroupShell.testRunShellTests  Time elapsed: 15.17 s  <<< ERROR!
org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed. Check output file for details.
	at org.jruby.embed.internal.EmbedEvalUnitImpl.run(EmbedEvalUnitImpl.java:134)
	at org.jruby.embed.ScriptingContainer.runUnit(ScriptingContainer.java:1296)
	at org.jruby.embed.ScriptingContainer.runScriptlet(ScriptingContainer.java:1341)
	at org.apache.hadoop.hbase.client.AbstractTestShell.testRunShellTests(AbstractTestShell.java:94)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: org.jruby.exceptions.RuntimeError: (RuntimeError) Shell unit tests failed. Check output file for details.
	at RUBY.<main>(src/test/ruby/tests_runner.rb:91)

[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 32.006 s <<< FAILURE! - in org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups
[ERROR] org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups.testRunShellTests  Time elapsed: 14.246 s  <<< ERROR!
org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed. Check output file for details.
	at org.jruby.embed.internal.EmbedEvalUnitImpl.run(EmbedEvalUnitImpl.java:134)
	at org.jruby.embed.ScriptingContainer.runUnit(ScriptingContainer.java:1296)
	at org.jruby.embed.ScriptingContainer.runScriptlet(ScriptingContainer.java:1341)
	at org.apache.hadoop.hbase.client.rsgroup.TestShellRSGroups.testRunShellTests(TestShellRSGroups.java:97)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: org.jruby.exceptions.RuntimeError: (RuntimeError) Shell unit tests failed. Check output file for details.
	at RUBY.<main>(src/test/ruby/tests_runner.rb:91)

[INFO]
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]   TestRSGroupShell>AbstractTestShell.testRunShellTests:94 » EvalFailed (RuntimeError) Shell unit tests failed. Check output file for details.
[ERROR]   TestShellRSGroups.testRunShellTests:97 » EvalFailed (RuntimeError) Shell unit tests failed. Check output file for details.
[INFO]
[ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0

So TestShellRSGroups is redundant, will drop the class from codebase, if analysis looks good to others. Please run mvn test -pl :hbase-shell -Dtest=TestShellRSGroups,TestRSGroupShell to cross check (assuming code is already built).

Also, TestRSGroupShell was recently added in https://issues.apache.org/jira/browse/HBASE-23809 and is more aligned with other test classes in https://github.com/apache/hbase/tree/master/hbase-shell/src/test/java/org/apache/hadoop/hbase/client, hence keeping it and dropping the older implementation TestShellRSGroups

NihalJain · 2023-09-06T20:48:47Z

Updated PR and description to reflect change based on above analysis. @Apache9 Could you please take a look at this?

Apache-HBase · 2023-09-06T21:14:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 9s	master passed
+1 💚	compile	0m 12s	master passed
+1 💚	shadedjars	4m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 8s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 15s	the patch passed
+1 💚	compile	0m 11s	the patch passed
+1 💚	javac	0m 11s	the patch passed
+1 💚	shadedjars	4m 52s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 8s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 47s	hbase-shell in the patch passed.
		24m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5387/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5387
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux caf93960c281 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `97d512b`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5387/2/testReport/
Max. process+thread count	1732 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5387/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-06T21:14:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 36s	master passed
+1 💚	compile	0m 15s	master passed
+1 💚	shadedjars	4m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 40s	the patch passed
+1 💚	compile	0m 15s	the patch passed
+1 💚	javac	0m 15s	the patch passed
+1 💚	shadedjars	4m 45s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 8s	hbase-shell in the patch passed.
		24m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5387/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5387
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 29e7301f06c6 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `97d512b`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5387/2/testReport/
Max. process+thread count	1563 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5387/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-06T21:15:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 46s	master passed
+1 💚	compile	0m 14s	master passed
+1 💚	checkstyle	0m 5s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 0s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 42s	the patch passed
+1 💚	compile	0m 14s	the patch passed
+1 💚	javac	0m 14s	the patch passed
+1 💚	checkstyle	0m 6s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	10m 20s	Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 💚	spotless	0m 42s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 0s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 7s	The patch does not generate ASF License warnings.
		24m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5387/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5387
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux ee534e3b954e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `97d512b`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5387/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit a80b341)

…5387) Signed-off-by: Duo Zhang <zhangduo@apache.org>

…5387) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit a80b341) (cherry picked from commit fb3f0aa) Change-Id: Ied3b2e116649c473ff0987a55b6ea4fb1a30676f

HBASE-28066 Move TestShellRSGroups.java inside /src/test/java

6b0d319

Drop duplicate test class TestShellRSGroups.java

91d4768

NihalJain changed the title ~~HBASE-28066 Move TestShellRSGroups.java inside /src/test/java~~ HBASE-28066 Drop duplicate test class TestShellRSGroups.java Sep 6, 2023

NihalJain requested a review from Apache9 September 6, 2023 21:09

Apache9 approved these changes Sep 8, 2023

View reviewed changes

NihalJain merged commit a80b341 into apache:master Sep 16, 2023
1 check passed

NihalJain added a commit that referenced this pull request Sep 16, 2023

HBASE-28066 Drop duplicate test class TestShellRSGroups.java (#5387)

f232a17

Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit a80b341)

NihalJain added a commit that referenced this pull request Sep 16, 2023

HBASE-28066 Drop duplicate test class TestShellRSGroups.java (#5387)

7dd9306

Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit a80b341)

NihalJain added a commit that referenced this pull request Sep 16, 2023

HBASE-28066 Drop duplicate test class TestShellRSGroups.java (#5387)

686820a

Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit a80b341)

NihalJain added a commit that referenced this pull request Sep 16, 2023

HBASE-28066 Drop duplicate test class TestShellRSGroups.java (#5387)

fb3f0aa

Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit a80b341)

wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request Nov 2, 2023

HBASE-28066 Drop duplicate test class TestShellRSGroups.java (apache#…

342a6f6

…5387) Signed-off-by: Duo Zhang <zhangduo@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28066 Drop duplicate test class TestShellRSGroups.java #5387

HBASE-28066 Drop duplicate test class TestShellRSGroups.java #5387

NihalJain commented Sep 6, 2023 •

edited

NihalJain commented Sep 6, 2023

Apache-HBase commented Sep 6, 2023

Apache-HBase commented Sep 6, 2023

Apache-HBase commented Sep 6, 2023

NihalJain commented Sep 6, 2023

NihalJain commented Sep 6, 2023

NihalJain commented Sep 6, 2023 •

edited

NihalJain commented Sep 6, 2023 •

edited

Apache-HBase commented Sep 6, 2023

Apache-HBase commented Sep 6, 2023

Apache-HBase commented Sep 6, 2023

HBASE-28066 Drop duplicate test class TestShellRSGroups.java #5387

HBASE-28066 Drop duplicate test class TestShellRSGroups.java #5387

Conversation

NihalJain commented Sep 6, 2023 • edited

NihalJain commented Sep 6, 2023

Apache-HBase commented Sep 6, 2023

Apache-HBase commented Sep 6, 2023

Apache-HBase commented Sep 6, 2023

NihalJain commented Sep 6, 2023

NihalJain commented Sep 6, 2023

NihalJain commented Sep 6, 2023 • edited

NihalJain commented Sep 6, 2023 • edited

Apache-HBase commented Sep 6, 2023

Apache-HBase commented Sep 6, 2023

Apache-HBase commented Sep 6, 2023

NihalJain commented Sep 6, 2023 •

edited

NihalJain commented Sep 6, 2023 •

edited

NihalJain commented Sep 6, 2023 •

edited