HBASE-28105 NPE in QuotaCache if Table is dropped from cluster #5426

hanke580 · 2023-09-21T15:31:25Z

https://issues.apache.org/jira/browse/HBASE-28105

Avoid NPE by making sure the table exists in the latest metadata.

Apache-HBase · 2023-09-21T16:18:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 53s	master passed
+1 💚	compile	2m 31s	master passed
+1 💚	checkstyle	0m 35s	master passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 32s	the patch passed
+1 💚	compile	2m 31s	the patch passed
+1 💚	javac	2m 31s	the patch passed
+1 💚	checkstyle	0m 34s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 37s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 33s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		32m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5426
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 0c5c82ef2898 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `20c4136`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-21T19:51:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 50s	master passed
+1 💚	compile	0m 48s	master passed
+1 💚	shadedjars	4m 55s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 36s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	4m 50s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	223m 13s	hbase-server in the patch passed.
		245m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5426
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux dead871c44e1 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `20c4136`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/1/testReport/
Max. process+thread count	4714 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-21T20:19:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 56s	master passed
+1 💚	compile	0m 46s	master passed
+1 💚	shadedjars	6m 6s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 30s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 47s	the patch passed
+1 💚	compile	0m 49s	the patch passed
+1 💚	javac	0m 49s	the patch passed
+1 💚	shadedjars	6m 33s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	the patch passed
		_ Other Tests _
-1 ❌	unit	248m 40s	hbase-server in the patch failed.
		274m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5426
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fd1bd702138a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `20c4136`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/1/testReport/
Max. process+thread count	4543 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreault

I think we should probably remove the tableName from the tableMachineQuotaFactors in this case. Nothing else seems to cause entries to be removed from that map, and it may have outdated factors that mess with the user quotas.

hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaCache.java

hanke580 · 2023-09-22T20:47:00Z

@bbeaudreault

I think we should probably remove the tableName from the tableMachineQuotaFactors in this case. Nothing else seems to cause entries to be removed from that map, and it may have outdated factors that mess with the user quotas.

Are you referring to tableQuotaCache? Since tableQuotaCache could store the outdated tableName.

If so, I think the outdated tableName might be removed the next time when the cache gets updated in this function.

Not sure whether we still need to remove it explicitly in updateQuotaFactors().

bbeaudreault · 2023-09-22T20:50:29Z

I think we should probably remove the tableName from the tableMachineQuotaFactors in this case. Nothing else seems to cause entries to be removed from that map, and it may have outdated factors that mess with the user quotas.

Are you referring to tableQuotaCache? Since tableQuotaCache could store the outdated tableName.

If so, I think the outdated tableName will be removed the next time when the cache gets updated in this function.

No, this method is populating a map called tableMachineQuotaFactors. Nothing removes from that map, but it affects quota enforcement. So i think here if the table does not exist we should remove from that map tableMachineQuotaFactors.

hanke580 · 2023-09-22T21:28:07Z

Make sense. I have updated the commit to remove the dropped tableName from tableMachineQuotaFactors. Is there any other place you suggest me to modify?

Apache-HBase · 2023-09-22T22:01:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 58s	master passed
+1 💚	compile	2m 27s	master passed
+1 💚	checkstyle	0m 35s	master passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	2m 25s	the patch passed
+1 💚	javac	2m 25s	the patch passed
-0 ⚠️	checkstyle	0m 33s	hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 29s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
-1 ❌	spotless	0m 33s	patch has 22 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	1m 31s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		31m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5426
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux d539339afc57 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `05f5d5b`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-23T01:35:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 33s	master passed
+1 💚	compile	0m 47s	master passed
+1 💚	shadedjars	4m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 36s	the patch passed
+1 💚	compile	0m 48s	the patch passed
+1 💚	javac	0m 48s	the patch passed
+1 💚	shadedjars	4m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	222m 10s	hbase-server in the patch passed.
		244m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5426
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e58844120de5 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `05f5d5b`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/2/testReport/
Max. process+thread count	4754 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-23T01:42:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 38s	master passed
+1 💚	compile	0m 38s	master passed
+1 💚	shadedjars	5m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 20s	the patch passed
+1 💚	compile	0m 38s	the patch passed
+1 💚	javac	0m 38s	the patch passed
+1 💚	shadedjars	5m 18s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
-1 ❌	unit	229m 28s	hbase-server in the patch failed.
		251m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5426
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f2b1d15ac2c1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `05f5d5b`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/2/testReport/
Max. process+thread count	5065 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreault

@hanke580 It looks good but can you run mvn spotless:apply to fix formatting?

hanke580 · 2023-09-23T15:03:53Z

@bbeaudreault Certainly! I have fixed the format problem.

Apache-HBase · 2023-09-23T15:46:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 37s	master passed
+1 💚	compile	2m 26s	master passed
+1 💚	checkstyle	0m 33s	master passed
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	2m 23s	the patch passed
+1 💚	javac	2m 23s	the patch passed
+1 💚	checkstyle	0m 34s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 25s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 34s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		31m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5426
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 0e38c9d9614d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `05f5d5b`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-23T19:20:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 55s	master passed
+1 💚	compile	0m 46s	master passed
+1 💚	shadedjars	4m 52s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 37s	the patch passed
+1 💚	compile	0m 46s	the patch passed
+1 💚	javac	0m 46s	the patch passed
+1 💚	shadedjars	4m 44s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
-1 ❌	unit	222m 18s	hbase-server in the patch failed.
		244m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5426
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f1a2b75df13e 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `05f5d5b`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/3/testReport/
Max. process+thread count	4757 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-09-23T20:00:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 11s	master passed
+1 💚	compile	0m 51s	master passed
+1 💚	shadedjars	6m 30s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 5s	the patch passed
+1 💚	compile	0m 52s	the patch passed
+1 💚	javac	0m 52s	the patch passed
+1 💚	shadedjars	6m 16s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 29s	the patch passed
		_ Other Tests _
-1 ❌	unit	257m 53s	hbase-server in the patch failed.
		284m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5426
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux aa69493cf119 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `05f5d5b`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/3/testReport/
Max. process+thread count	4485 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5426/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreault

Unit test failure is unrelated. LGTM, thanks for the contribution!

Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

…rom cluster (apache#5426) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

…e#5426) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

…e#5426) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> (cherry picked from commit 897fcf8) Change-Id: Ided23c7dff843daaf4c74b1459e95640f226b999

HBASE-28105 NPE in QuotaCache if Table is dropped from cluster

a1a0307

bbeaudreault reviewed Sep 21, 2023

View reviewed changes

Apache9 reviewed Sep 22, 2023

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaCache.java Show resolved Hide resolved

remove the dropped table from tableMachineQuotaFactors

9a5ca51

bbeaudreault reviewed Sep 23, 2023

View reviewed changes

spotless: fix format

51001ec

bbeaudreault approved these changes Sep 25, 2023

View reviewed changes

bbeaudreault merged commit 79fbbc3 into apache:master Sep 25, 2023
1 check failed

bbeaudreault pushed a commit that referenced this pull request Sep 25, 2023

HBASE-28105 NPE in QuotaCache if Table is dropped from cluster (#5426)

48edded

Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

bbeaudreault pushed a commit that referenced this pull request Sep 25, 2023

HBASE-28105 NPE in QuotaCache if Table is dropped from cluster (#5426)

04826d1

Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

bbeaudreault pushed a commit that referenced this pull request Sep 25, 2023

HBASE-28105 NPE in QuotaCache if Table is dropped from cluster (#5426)

5f7415e

Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

bbeaudreault pushed a commit that referenced this pull request Sep 25, 2023

HBASE-28105 NPE in QuotaCache if Table is dropped from cluster (#5426)

897fcf8

Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

bbeaudreault pushed a commit to HubSpot/hbase that referenced this pull request Sep 25, 2023

HubSpot Backport: HBASE-28105 NPE in QuotaCache if Table is dropped f…

61c109e

…rom cluster (apache#5426) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request Nov 2, 2023

HBASE-28105 NPE in QuotaCache if Table is dropped from cluster (apach…

c4c253b

…e#5426) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28105 NPE in QuotaCache if Table is dropped from cluster #5426

HBASE-28105 NPE in QuotaCache if Table is dropped from cluster #5426

hanke580 commented Sep 21, 2023

Apache-HBase commented Sep 21, 2023

Apache-HBase commented Sep 21, 2023

Apache-HBase commented Sep 21, 2023

bbeaudreault left a comment

hanke580 commented Sep 22, 2023 •

edited

Loading

bbeaudreault commented Sep 22, 2023

hanke580 commented Sep 22, 2023

Apache-HBase commented Sep 22, 2023

Apache-HBase commented Sep 23, 2023

Apache-HBase commented Sep 23, 2023

bbeaudreault left a comment

hanke580 commented Sep 23, 2023 •

edited

Loading

Apache-HBase commented Sep 23, 2023

Apache-HBase commented Sep 23, 2023

Apache-HBase commented Sep 23, 2023

bbeaudreault left a comment

HBASE-28105 NPE in QuotaCache if Table is dropped from cluster #5426

HBASE-28105 NPE in QuotaCache if Table is dropped from cluster #5426

Conversation

hanke580 commented Sep 21, 2023

Apache-HBase commented Sep 21, 2023

Apache-HBase commented Sep 21, 2023

Apache-HBase commented Sep 21, 2023

bbeaudreault left a comment

Choose a reason for hiding this comment

hanke580 commented Sep 22, 2023 • edited Loading

bbeaudreault commented Sep 22, 2023

hanke580 commented Sep 22, 2023

Apache-HBase commented Sep 22, 2023

Apache-HBase commented Sep 23, 2023

Apache-HBase commented Sep 23, 2023

bbeaudreault left a comment

Choose a reason for hiding this comment

hanke580 commented Sep 23, 2023 • edited Loading

Apache-HBase commented Sep 23, 2023

Apache-HBase commented Sep 23, 2023

Apache-HBase commented Sep 23, 2023

bbeaudreault left a comment

Choose a reason for hiding this comment

hanke580 commented Sep 22, 2023 •

edited

Loading

hanke580 commented Sep 23, 2023 •

edited

Loading