New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28223 Include shaded netty-all in hbase-shaded-mapreduce #5542
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Shouldn't netty-all be coming from the Hadoop classpath ? |
hbase-shaded-client is meant to include Hadoop, but hbase-shaded-mapreduce is not. |
As discussed offline netty-all is a direct dependency of ZK, so I think this is fine after all. |
-1 |
Hbase-mapreduce module does not transitively depend on netty-all? Strange... |
hbase-mapreduce does. |
Thanks @stoty . Converting it to draft, because we're verifying a downstream-only fix. |
Move netty-all to compile scope in
hbase-shaded-mapreduce
, because it's a required runtime dependency for MR clients which use TLS connections for HBase and ZK.