Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-28223 Include shaded netty-all in hbase-shaded-mapreduce #5542

Closed
wants to merge 1 commit into from

Conversation

anmolnar
Copy link
Contributor

Move netty-all to compile scope in hbase-shaded-mapreduce, because it's a required runtime dependency for MR clients which use TLS connections for HBase and ZK.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 25s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 33s master passed
+1 💚 compile 0m 10s master passed
+1 💚 shadedjars 5m 4s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 10s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 13s the patch passed
+1 💚 compile 0m 11s the patch passed
+1 💚 javac 0m 11s the patch passed
+1 💚 shadedjars 5m 1s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 8s the patch passed
_ Other Tests _
+1 💚 unit 0m 11s hbase-shaded-mapreduce in the patch passed.
17m 1s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5542/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5542
Optional Tests javac javadoc unit shadedjars compile
uname Linux 5732ef221c21 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / dbfb516
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5542/1/testReport/
Max. process+thread count 67 (vs. ulimit of 30000)
modules C: hbase-shaded/hbase-shaded-mapreduce U: hbase-shaded/hbase-shaded-mapreduce
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5542/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 17s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 55s master passed
+1 💚 compile 0m 14s master passed
+1 💚 shadedjars 4m 57s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 12s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 42s the patch passed
+1 💚 compile 0m 14s the patch passed
+1 💚 javac 0m 14s the patch passed
+1 💚 shadedjars 4m 52s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 10s the patch passed
_ Other Tests _
+1 💚 unit 0m 14s hbase-shaded-mapreduce in the patch passed.
20m 44s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5542/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5542
Optional Tests javac javadoc unit shadedjars compile
uname Linux 7e7d9e3711b1 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / dbfb516
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5542/1/testReport/
Max. process+thread count 72 (vs. ulimit of 30000)
modules C: hbase-shaded/hbase-shaded-mapreduce U: hbase-shaded/hbase-shaded-mapreduce
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5542/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 11s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 2m 54s master passed
+1 💚 compile 0m 14s master passed
+1 💚 spotless 0m 43s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 42s the patch passed
+1 💚 compile 0m 14s the patch passed
+1 💚 javac 0m 14s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 9m 25s Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚 spotless 0m 41s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
23m 25s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5542/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5542
Optional Tests dupname asflicense javac hadoopcheck spotless xml compile
uname Linux 2bcf5fa4384b 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / dbfb516
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-shaded/hbase-shaded-mapreduce U: hbase-shaded/hbase-shaded-mapreduce
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5542/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor

stoty commented Nov 28, 2023

Shouldn't netty-all be coming from the Hadoop classpath ?

@stoty
Copy link
Contributor

stoty commented Nov 28, 2023

hbase-shaded-client is meant to include Hadoop, but hbase-shaded-mapreduce is not.

@stoty
Copy link
Contributor

stoty commented Nov 28, 2023

As discussed offline netty-all is a direct dependency of ZK, so I think this is fine after all.
It would be nice if we wouldn't have to add it explicitly, and instead could take it transitively from zookeeper.

@stoty
Copy link
Contributor

stoty commented Nov 28, 2023

-1
We don't need netty-all, only netty-handler.
This problem is caused by overriding the netty4 version, and HBASE-28153 already solves it in a more appropriate way.

@Apache9
Copy link
Contributor

Apache9 commented Nov 29, 2023

Hbase-mapreduce module does not transitively depend on netty-all? Strange...

@stoty
Copy link
Contributor

stoty commented Nov 29, 2023

hbase-mapreduce does.
But it is transitive via Hadoop, and we mark Hadoop dependencies as provided in the hbase-mapreduce-shaded uberjar, and only add netty artifacts coming via ZK.
hbase-mapreduce-shaded is like hbase-client-byo-hadoop in this regard, and expects to have Hadoop on the classpath.

@anmolnar anmolnar marked this pull request as draft November 29, 2023 12:10
@anmolnar
Copy link
Contributor Author

Thanks @stoty . Converting it to draft, because we're verifying a downstream-only fix.

@anmolnar
Copy link
Contributor Author

anmolnar commented Dec 4, 2023

Resolved downstream. No need for this fix. Actually the upstream version of hbase does include io.netty in hbase-shaded-mapreduce. Thanks @stoty @Apache9

@anmolnar anmolnar closed this Dec 4, 2023
@anmolnar anmolnar deleted the HBASE-28223 branch December 4, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants