HBASE-25549 Provide a switch that allows avoiding reopening all regions when modifying a table to prevent RIT storms #5549

gourabtaparia · 2023-11-29T08:42:18Z

This is to prevent RIT storms.
The changes have been made in both alter and alter sync commands.

The related changes have already been merged in the master branch from #2924. This change cherry-picks that, and makes few additional changes on top of that.

…fying a table to prevent RIT storms.

Apache-HBase · 2023-11-29T09:47:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 50s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 52s	branch-2 passed
+1 💚	compile	4m 43s	branch-2 passed
+1 💚	checkstyle	1m 38s	branch-2 passed
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
+1 💚	spotbugs	5m 19s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 43s	the patch passed
+1 💚	compile	4m 43s	the patch passed
+1 💚	cc	4m 43s	the patch passed
+1 💚	javac	4m 43s	the patch passed
-0 ⚠️	checkstyle	0m 37s	hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9)
-0 ⚠️	rubocop	0m 9s	The patch generated 10 new + 422 unchanged - 5 fixed = 432 total (was 427)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 57s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚	hbaseprotoc	1m 55s	the patch passed
+1 💚	spotless	0m 42s	patch has no errors when running spotless:check.
+1 💚	spotbugs	5m 48s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 50s	The patch does not generate ASF License warnings.
		51m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5549
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux 6e40393d4659 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `ea11923`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	81 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java

Apache-HBase · 2023-11-29T13:44:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 53s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 58s	branch-2 passed
+1 💚	compile	2m 20s	branch-2 passed
+1 💚	shadedjars	5m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 23s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 54s	the patch passed
+1 💚	compile	2m 22s	the patch passed
+1 💚	javac	2m 22s	the patch passed
+1 💚	shadedjars	6m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 27s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	8m 9s	hbase-client in the patch passed.
+1 💚	unit	232m 18s	hbase-server in the patch passed.
+1 💚	unit	6m 51s	hbase-thrift in the patch passed.
+1 💚	unit	7m 51s	hbase-shell in the patch passed.
		288m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5549
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6c310b0d2f8e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `ea11923`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/1/testReport/
Max. process+thread count	4713 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-11-29T14:51:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 43s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 16s	branch-2 passed
+1 💚	compile	2m 24s	branch-2 passed
+1 💚	shadedjars	4m 58s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 37s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 40s	the patch passed
+1 💚	compile	2m 25s	the patch passed
+1 💚	javac	2m 25s	the patch passed
+1 💚	shadedjars	5m 6s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 0s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 44s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	8m 55s	hbase-client in the patch passed.
-1 ❌	unit	298m 10s	hbase-server in the patch failed.
+1 💚	unit	8m 35s	hbase-thrift in the patch passed.
+1 💚	unit	7m 16s	hbase-shell in the patch passed.
		355m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5549
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d677302398ce 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `ea11923`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/1/testReport/
Max. process+thread count	4479 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

gourabtaparia · 2023-11-29T15:58:57Z

@bbeaudreault I have made the suggested change. Please review again.

bbeaudreault

LGTM, let's wait for pre-commit to come back. Thanks for doing this :)

gourabtaparia · 2023-11-29T16:18:28Z

Thanks for the review.

Apache-HBase · 2023-11-29T17:01:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 7s	branch-2 passed
+1 💚	compile	4m 35s	branch-2 passed
+1 💚	checkstyle	1m 33s	branch-2 passed
+1 💚	spotless	0m 45s	branch has no errors when running spotless:check.
+1 💚	spotbugs	5m 0s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 39s	the patch passed
+1 💚	compile	4m 34s	the patch passed
+1 💚	cc	4m 34s	the patch passed
+1 💚	javac	4m 34s	the patch passed
-0 ⚠️	checkstyle	0m 32s	hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9)
-0 ⚠️	rubocop	0m 10s	The patch generated 10 new + 422 unchanged - 5 fixed = 432 total (was 427)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	14m 38s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚	hbaseprotoc	1m 42s	the patch passed
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	5m 37s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 37s	The patch does not generate ASF License warnings.
		50m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5549
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux 41d79191be6c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `a91e933`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-11-29T20:43:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 2s	branch-2 passed
+1 💚	compile	2m 7s	branch-2 passed
+1 💚	shadedjars	5m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 21s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 39s	the patch passed
+1 💚	compile	2m 6s	the patch passed
+1 💚	javac	2m 6s	the patch passed
+1 💚	shadedjars	5m 16s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 19s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 29s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	8m 5s	hbase-client in the patch passed.
+1 💚	unit	219m 23s	hbase-server in the patch passed.
+1 💚	unit	7m 14s	hbase-thrift in the patch passed.
-1 ❌	unit	8m 10s	hbase-shell in the patch failed.
		272m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5549
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f21dc00e4e02 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `a91e933`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/2/testReport/
Max. process+thread count	4856 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-11-29T21:07:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 51s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 12s	branch-2 passed
+1 💚	compile	2m 22s	branch-2 passed
+1 💚	shadedjars	5m 54s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 25s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 51s	the patch passed
+1 💚	compile	2m 14s	the patch passed
+1 💚	javac	2m 14s	the patch passed
+1 💚	shadedjars	5m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 40s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	8m 7s	hbase-client in the patch passed.
+1 💚	unit	240m 10s	hbase-server in the patch passed.
+1 💚	unit	7m 28s	hbase-thrift in the patch passed.
-1 ❌	unit	8m 14s	hbase-shell in the patch failed.
		296m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5549
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c5230926d67f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `a91e933`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-shell.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/2/testReport/
Max. process+thread count	4680 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-11-29T22:38:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 46s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 21s	branch-2 passed
+1 💚	compile	6m 30s	branch-2 passed
+1 💚	checkstyle	2m 4s	branch-2 passed
+1 💚	spotless	0m 59s	branch has no errors when running spotless:check.
+1 💚	spotbugs	7m 2s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 30s	the patch passed
+1 💚	compile	4m 35s	the patch passed
+1 💚	cc	4m 35s	the patch passed
+1 💚	javac	4m 35s	the patch passed
-0 ⚠️	checkstyle	0m 34s	hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9)
-0 ⚠️	rubocop	0m 9s	The patch generated 10 new + 422 unchanged - 5 fixed = 432 total (was 427)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	14m 30s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚	hbaseprotoc	1m 44s	the patch passed
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	5m 35s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 38s	The patch does not generate ASF License warnings.
		57m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5549
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux 8c88abd7f7ea 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `a91e933`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	81 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-11-30T02:49:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 11s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 22s	branch-2 passed
+1 💚	compile	1m 49s	branch-2 passed
+1 💚	shadedjars	5m 4s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 28s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 51s	the patch passed
+1 💚	compile	2m 17s	the patch passed
+1 💚	javac	2m 17s	the patch passed
+1 💚	shadedjars	5m 37s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 30s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 29s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	8m 10s	hbase-client in the patch passed.
-1 ❌	unit	250m 35s	hbase-server in the patch failed.
+1 💚	unit	9m 4s	hbase-thrift in the patch passed.
-1 ❌	unit	7m 52s	hbase-shell in the patch failed.
		308m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5549
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 981b9a51be6b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `a91e933`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-shell.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/3/testReport/
Max. process+thread count	4963 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-11-30T02:58:17Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 51s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 9s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 11s	branch-2 passed
+1 💚	compile	2m 45s	branch-2 passed
+1 💚	shadedjars	5m 50s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 51s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 37s	the patch passed
+1 💚	compile	2m 47s	the patch passed
+1 💚	javac	2m 47s	the patch passed
+1 💚	shadedjars	6m 15s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 52s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	8m 6s	hbase-client in the patch passed.
-1 ❌	unit	259m 8s	hbase-server in the patch failed.
+1 💚	unit	7m 23s	hbase-thrift in the patch passed.
-1 ❌	unit	7m 37s	hbase-shell in the patch failed.
		317m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5549
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 25cee694c517 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `a91e933`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/3/testReport/
Max. process+thread count	4058 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

GeorryHuang

LGTM.Thanks for your work.

gourabtaparia · 2023-11-30T11:09:23Z

@GeorryHuang @bbeaudreault Looks like few of the unrelated unit tests are failing here. How should we move ahead here ? Should i submit a dummy change to retrigger the runs ? Or is this okay to be merged ?

Apache-HBase · 2023-12-01T07:31:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 52s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 1s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 53s	branch-2 passed
+1 💚	compile	4m 44s	branch-2 passed
+1 💚	checkstyle	1m 36s	branch-2 passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
+1 💚	spotbugs	5m 16s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 40s	the patch passed
+1 💚	compile	4m 45s	the patch passed
+1 💚	cc	4m 45s	the patch passed
+1 💚	javac	4m 45s	the patch passed
-0 ⚠️	checkstyle	0m 37s	hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9)
-0 ⚠️	rubocop	0m 10s	The patch generated 10 new + 422 unchanged - 5 fixed = 432 total (was 427)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 56s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚	hbaseprotoc	1m 52s	the patch passed
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	5m 46s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 50s	The patch does not generate ASF License warnings.
		51m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5549
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux 79d41e7bda01 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0f63885`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	81 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-01T11:14:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 43s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 8s	branch-2 passed
+1 💚	compile	2m 59s	branch-2 passed
+1 💚	shadedjars	5m 28s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 34s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 7s	the patch passed
+1 💚	compile	2m 26s	the patch passed
+1 💚	javac	2m 26s	the patch passed
+1 💚	shadedjars	4m 57s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 35s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	8m 17s	hbase-client in the patch passed.
+1 💚	unit	217m 40s	hbase-server in the patch passed.
+1 💚	unit	7m 50s	hbase-thrift in the patch passed.
+1 💚	unit	7m 4s	hbase-shell in the patch passed.
		273m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5549
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d1d1dd376599 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0f63885`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/4/testReport/
Max. process+thread count	4697 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-01T11:16:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 45s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 35s	branch-2 passed
+1 💚	compile	1m 49s	branch-2 passed
+1 💚	shadedjars	5m 5s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 13s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 14s	the patch passed
+1 💚	compile	1m 48s	the patch passed
+1 💚	javac	1m 48s	the patch passed
+1 💚	shadedjars	5m 1s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 24s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	7m 53s	hbase-client in the patch passed.
-1 ❌	unit	225m 31s	hbase-server in the patch failed.
+1 💚	unit	7m 25s	hbase-thrift in the patch passed.
+1 💚	unit	7m 55s	hbase-shell in the patch passed.
		276m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5549
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 992dca863b6c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0f63885`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/4/testReport/
Max. process+thread count	4671 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

gourabtaparia · 2023-12-01T13:08:40Z

Hi @bbeaudreault @GeorryHuang

Retriggered the build again, and all the previous failed test succeeded, and this time a new test TestClientScannerTimeouts.testNormalScanTimeoutOnNextAsync is failing. This looks not related to the changes made.

Can you guys please help to get this merged ? Or should i continue to re-trigger it until all the tests succeed ?

bbeaudreault

I noticed one small thing. I can merge once you fix that, we don't have to wait for the full pre-commit to run, just the first one which checks spotless/checkstyle/etc

hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java

gourabtaparia · 2023-12-01T13:38:28Z

@bbeaudreault Thanks for pointing this out, i have pushed a commit adding the related javadoc.

Apache-HBase · 2023-12-01T15:00:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 24s	branch-2 passed
+1 💚	compile	7m 58s	branch-2 passed
+1 💚	checkstyle	2m 7s	branch-2 passed
+1 💚	spotless	1m 13s	branch has no errors when running spotless:check.
+1 💚	spotbugs	8m 51s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 28s	the patch passed
+1 💚	compile	7m 1s	the patch passed
+1 💚	cc	7m 1s	the patch passed
+1 💚	javac	7m 1s	the patch passed
-0 ⚠️	checkstyle	1m 2s	hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9)
-0 ⚠️	rubocop	0m 17s	The patch generated 10 new + 422 unchanged - 5 fixed = 432 total (was 427)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 54s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚	hbaseprotoc	2m 38s	the patch passed
-1 ❌	spotless	0m 27s	patch has 49 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	9m 57s	the patch passed
		_ Other Tests _
+1 💚	asflicense	1m 1s	The patch does not generate ASF License warnings.
		80m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5549
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux 6e8385aeb028 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0f63885`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/5/artifact/yetus-general-check/output/diff-patch-rubocop.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/5/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	81 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/5/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-01T18:15:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 43s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 6s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 5s	branch-2 passed
+1 💚	compile	2m 49s	branch-2 passed
+1 💚	shadedjars	5m 23s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 41s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 52s	the patch passed
+1 💚	compile	2m 26s	the patch passed
+1 💚	javac	2m 26s	the patch passed
+1 💚	shadedjars	4m 57s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 35s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	8m 18s	hbase-client in the patch passed.
-1 ❌	unit	219m 25s	hbase-server in the patch failed.
+1 💚	unit	7m 57s	hbase-thrift in the patch passed.
+1 💚	unit	7m 5s	hbase-shell in the patch passed.
		274m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5549
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux aec47f0eda8e 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0f63885`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/5/testReport/
Max. process+thread count	4414 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-01T18:30:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 54s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 39s	branch-2 passed
+1 💚	compile	2m 20s	branch-2 passed
+1 💚	shadedjars	6m 5s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 33s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 42s	the patch passed
+1 💚	compile	2m 12s	the patch passed
+1 💚	javac	2m 12s	the patch passed
+1 💚	shadedjars	5m 48s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 27s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 29s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	8m 9s	hbase-client in the patch passed.
-1 ❌	unit	234m 35s	hbase-server in the patch failed.
+1 💚	unit	6m 57s	hbase-thrift in the patch passed.
+1 💚	unit	7m 58s	hbase-shell in the patch passed.
		289m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5549
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 65eaf4bf2fc1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0f63885`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/5/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/5/testReport/
Max. process+thread count	4552 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-01T19:23:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 55s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 49s	branch-2 passed
+1 💚	compile	4m 42s	branch-2 passed
+1 💚	checkstyle	1m 39s	branch-2 passed
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
+1 💚	spotbugs	5m 15s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 39s	the patch passed
+1 💚	compile	4m 44s	the patch passed
+1 💚	cc	4m 44s	the patch passed
+1 💚	javac	4m 44s	the patch passed
-0 ⚠️	checkstyle	0m 36s	hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9)
-0 ⚠️	rubocop	0m 10s	The patch generated 10 new + 422 unchanged - 5 fixed = 432 total (was 427)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 59s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚	hbaseprotoc	1m 54s	the patch passed
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	5m 49s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 43s	The patch does not generate ASF License warnings.
		50m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5549
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname	Linux 6e85577e2eb2 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `dbc165a`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/6/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	81 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/6/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…ns when modifying a table to prevent RIT storms (#5549) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>

…eopening all regions when modifying a table to prevent RIT storms (apache#5549) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>

Apache-HBase · 2023-12-01T22:59:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 49s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 30s	branch-2 passed
+1 💚	compile	2m 5s	branch-2 passed
+1 💚	shadedjars	5m 29s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 25s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 48s	the patch passed
+1 💚	compile	2m 28s	the patch passed
+1 💚	javac	2m 28s	the patch passed
+1 💚	shadedjars	5m 55s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 30s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 29s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	8m 5s	hbase-client in the patch passed.
+1 💚	unit	213m 47s	hbase-server in the patch passed.
+1 💚	unit	6m 47s	hbase-thrift in the patch passed.
+1 💚	unit	7m 37s	hbase-shell in the patch passed.
		266m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5549
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d596ac0a538a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `dbc165a`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/6/testReport/
Max. process+thread count	4672 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/6/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-01T23:46:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 40s	branch-2 passed
+1 💚	compile	3m 9s	branch-2 passed
+1 💚	shadedjars	5m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 49s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 23s	the patch passed
+1 💚	compile	2m 59s	the patch passed
+1 💚	javac	2m 59s	the patch passed
+1 💚	shadedjars	6m 6s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 54s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 48s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	9m 1s	hbase-client in the patch passed.
-1 ❌	unit	253m 54s	hbase-server in the patch failed.
+1 💚	unit	8m 10s	hbase-thrift in the patch passed.
+1 💚	unit	7m 1s	hbase-shell in the patch passed.
		313m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5549
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8aa5dbf633a5 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `dbc165a`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/6/testReport/
Max. process+thread count	4460 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5549/6/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

gourabtaparia · 2023-12-02T05:53:19Z

Thanks @bbeaudreault for merging this.

Provide a switch that allows avoiding reopening all regions when modi…

fea7642

…fying a table to prevent RIT storms.

wchevreuil mentioned this pull request Nov 29, 2023

HBASE-28120 Switch that allows avoiding reopening all regions when altering table #5482

Closed

bbeaudreault reviewed Nov 29, 2023

View reviewed changes

hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java Show resolved Hide resolved

Retain the orignal method caller

a6e4bd7

bbeaudreault approved these changes Nov 29, 2023

View reviewed changes

GeorryHuang approved these changes Nov 30, 2023

View reviewed changes

Updating comment to retrigger the build

eebe217

bbeaudreault requested changes Dec 1, 2023

View reviewed changes

hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java Outdated Show resolved Hide resolved

Add javadoc for new params

e847883

Run spotless:apply

91ddb77

bbeaudreault approved these changes Dec 1, 2023

View reviewed changes

bbeaudreault merged commit ad2c364 into apache:branch-2 Dec 1, 2023
1 check was pending

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-25549 Provide a switch that allows avoiding reopening all regions when modifying a table to prevent RIT storms #5549

HBASE-25549 Provide a switch that allows avoiding reopening all regions when modifying a table to prevent RIT storms #5549

gourabtaparia commented Nov 29, 2023

Apache-HBase commented Nov 29, 2023

Apache-HBase commented Nov 29, 2023

Apache-HBase commented Nov 29, 2023

gourabtaparia commented Nov 29, 2023

bbeaudreault left a comment

gourabtaparia commented Nov 29, 2023 •

edited

Loading

Apache-HBase commented Nov 29, 2023

Apache-HBase commented Nov 29, 2023

Apache-HBase commented Nov 29, 2023

Apache-HBase commented Nov 29, 2023

Apache-HBase commented Nov 30, 2023

Apache-HBase commented Nov 30, 2023

GeorryHuang left a comment

gourabtaparia commented Nov 30, 2023

Apache-HBase commented Dec 1, 2023

Apache-HBase commented Dec 1, 2023

Apache-HBase commented Dec 1, 2023

gourabtaparia commented Dec 1, 2023

bbeaudreault left a comment

gourabtaparia commented Dec 1, 2023

Apache-HBase commented Dec 1, 2023

Apache-HBase commented Dec 1, 2023

Apache-HBase commented Dec 1, 2023

Apache-HBase commented Dec 1, 2023

Apache-HBase commented Dec 1, 2023

Apache-HBase commented Dec 1, 2023

gourabtaparia commented Dec 2, 2023

HBASE-25549 Provide a switch that allows avoiding reopening all regions when modifying a table to prevent RIT storms #5549

HBASE-25549 Provide a switch that allows avoiding reopening all regions when modifying a table to prevent RIT storms #5549

Conversation

gourabtaparia commented Nov 29, 2023

Apache-HBase commented Nov 29, 2023

Apache-HBase commented Nov 29, 2023

Apache-HBase commented Nov 29, 2023

gourabtaparia commented Nov 29, 2023

bbeaudreault left a comment

Choose a reason for hiding this comment

gourabtaparia commented Nov 29, 2023 • edited Loading

Apache-HBase commented Nov 29, 2023

Apache-HBase commented Nov 29, 2023

Apache-HBase commented Nov 29, 2023

Apache-HBase commented Nov 29, 2023

Apache-HBase commented Nov 30, 2023

Apache-HBase commented Nov 30, 2023

GeorryHuang left a comment

Choose a reason for hiding this comment

gourabtaparia commented Nov 30, 2023

Apache-HBase commented Dec 1, 2023

Apache-HBase commented Dec 1, 2023

Apache-HBase commented Dec 1, 2023

gourabtaparia commented Dec 1, 2023

bbeaudreault left a comment

Choose a reason for hiding this comment

gourabtaparia commented Dec 1, 2023

Apache-HBase commented Dec 1, 2023

Apache-HBase commented Dec 1, 2023

Apache-HBase commented Dec 1, 2023

Apache-HBase commented Dec 1, 2023

Apache-HBase commented Dec 1, 2023

Apache-HBase commented Dec 1, 2023

gourabtaparia commented Dec 2, 2023

gourabtaparia commented Nov 29, 2023 •

edited

Loading