Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-28245 Sync internal protobuf version for hbase to be same as hb… #5564

Merged
merged 1 commit into from
Dec 14, 2023
Merged

HBASE-28245 Sync internal protobuf version for hbase to be same as hb… #5564

merged 1 commit into from
Dec 14, 2023

Conversation

NihalJain
Copy link
Contributor

…ase-thirdparty

@NihalJain NihalJain marked this pull request as draft December 6, 2023 14:42
@NihalJain
Copy link
Contributor Author

Build fails with this change, need to debug!

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 42s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 2m 35s master passed
+1 💚 compile 0m 47s master passed
+1 💚 shadedjars 4m 46s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 26s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 2m 22s the patch passed
+1 💚 compile 0m 48s the patch passed
+1 💚 javac 0m 48s the patch passed
+1 💚 shadedjars 4m 44s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 25s the patch passed
_ Other Tests _
+1 💚 unit 0m 32s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 2s hbase-examples in the patch passed.
21m 41s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5564/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5564
Optional Tests javac javadoc unit shadedjars compile
uname Linux 348dab143fd6 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 25e9228
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5564/1/testReport/
Max. process+thread count 1420 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-examples U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5564/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 38s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 44s master passed
+1 💚 compile 0m 56s master passed
+1 💚 shadedjars 4m 55s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 23s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 42s the patch passed
+1 💚 compile 0m 58s the patch passed
+1 💚 javac 0m 58s the patch passed
+1 💚 shadedjars 4m 51s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 26s the patch passed
_ Other Tests _
+1 💚 unit 0m 39s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 54s hbase-examples in the patch passed.
22m 43s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5564/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5564
Optional Tests javac javadoc unit shadedjars compile
uname Linux 369b71511011 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 25e9228
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5564/1/testReport/
Max. process+thread count 1359 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-examples U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5564/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain
Copy link
Contributor Author

Build fails with this change, need to debug!

Local build failure was due to rebase issue. Rebased and force pushed!

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 2m 54s master passed
+1 💚 compile 0m 54s master passed
+1 💚 spotless 0m 41s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 35s the patch passed
+1 💚 compile 0m 55s the patch passed
+1 💚 javac 0m 55s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 9m 48s Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚 spotless 0m 38s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 15s The patch does not generate ASF License warnings.
25m 31s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5564/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5564
Optional Tests dupname asflicense javac hadoopcheck spotless xml compile
uname Linux ba3f62e45415 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 25e9228
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-examples U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5564/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain NihalJain marked this pull request as ready for review December 6, 2023 15:08
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 38s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 8s Maven dependency ordering for branch
+1 💚 mvninstall 2m 48s master passed
+1 💚 compile 0m 58s master passed
+1 💚 shadedjars 4m 53s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 24s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 2m 45s the patch passed
+1 💚 compile 0m 57s the patch passed
+1 💚 javac 0m 57s the patch passed
+1 💚 shadedjars 4m 52s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 25s the patch passed
_ Other Tests _
+1 💚 unit 0m 38s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 53s hbase-examples in the patch passed.
22m 42s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5564/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5564
Optional Tests javac javadoc unit shadedjars compile
uname Linux 9e31e0f109ca 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 25e9228
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5564/2/testReport/
Max. process+thread count 1400 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-examples U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5564/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 3m 6s master passed
+1 💚 compile 0m 57s master passed
+1 💚 spotless 0m 44s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 52s the patch passed
+1 💚 compile 0m 57s the patch passed
+1 💚 javac 0m 57s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 10m 33s Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚 spotless 0m 40s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 15s The patch does not generate ASF License warnings.
27m 27s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5564/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5564
Optional Tests dupname asflicense javac hadoopcheck spotless xml compile
uname Linux 42f8fb4f0d79 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 25e9228
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-examples U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5564/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 42s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 42s master passed
+1 💚 compile 1m 4s master passed
+1 💚 shadedjars 7m 20s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 29s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 23s the patch passed
+1 💚 compile 1m 8s the patch passed
+1 💚 javac 1m 7s the patch passed
+1 💚 shadedjars 7m 14s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 28s the patch passed
_ Other Tests _
+1 💚 unit 0m 35s hbase-protocol-shaded in the patch passed.
+1 💚 unit 3m 47s hbase-examples in the patch passed.
31m 39s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5564/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5564
Optional Tests javac javadoc unit shadedjars compile
uname Linux 803f60304e08 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 25e9228
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5564/2/testReport/
Max. process+thread count 1547 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-examples U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5564/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain
Copy link
Contributor Author

In my opinion this should go to all branches having https://issues.apache.org/jira/browse/HBASE-22138 i.e master, branch-3, branch-2, branch-2.6, branch-2.5, branch-2.4, please let me know what do you think? @Apache9

I plan to commit this tonight.!

CC: @apurtell

@NihalJain
Copy link
Contributor Author

In my opinion this should go to all branches having https://issues.apache.org/jira/browse/HBASE-22138 i.e master, branch-3, branch-2, branch-2.6, branch-2.5, branch-2.4, please let me know what do you think?

Gentle ping @Apache9, @apurtell

@NihalJain NihalJain merged commit 4ffdcea into apache:master Dec 14, 2023
1 check passed
NihalJain added a commit that referenced this pull request Dec 14, 2023
@NihalJain
HBASE-28245 Sync internal protobuf version for hbase to be same as hb…
e9105e9 
…ase-thirdparty (#5564)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 4ffdcea)
NihalJain added a commit that referenced this pull request Dec 14, 2023
@NihalJain
HBASE-28245 Sync internal protobuf version for hbase to be same as hb…
a602446 
…ase-thirdparty (#5564)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 4ffdcea)
NihalJain added a commit that referenced this pull request Dec 14, 2023
@NihalJain
HBASE-28245 Sync internal protobuf version for hbase to be same as hb…
1e7d51f 
…ase-thirdparty (#5564)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 4ffdcea)
NihalJain added a commit that referenced this pull request Dec 14, 2023
@NihalJain
HBASE-28245 Sync internal protobuf version for hbase to be same as hb…
de98735 
…ase-thirdparty (#5564)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 4ffdcea)
NihalJain added a commit that referenced this pull request Dec 14, 2023
@NihalJain
HBASE-28245 Sync internal protobuf version for hbase to be same as hb…
7058408 
…ase-thirdparty (#5564)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 4ffdcea)
kadirozde pushed a commit to kadirozde/hbase that referenced this pull request Jan 5, 2024
@NihalJain @kadirozde
HBASE-28245 Sync internal protobuf version for hbase to be same as hb…
dc969ff 
…ase-thirdparty (apache#5564)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@NihalJain
HBASE-28245 Sync internal protobuf version for hbase to be same as hb…
b642236 
…ase-thirdparty (apache#5564)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 4ffdcea)
(cherry picked from commit 7058408)
Change-Id: I87e99367e387ecc0fa0875aa712c8727571233ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apache9 Apache9 Apache9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@NihalJain @Apache-HBase @Apache9