HBASE-28252 Add sun.net.dns and sun.net.util to the JDK11+ module exports in the hbase script #5571

stoty · 2023-12-08T14:02:31Z

Change-Id: I0ade930b2f92a0dfd015697a9c4de20e7de65ba5

stoty · 2023-12-08T14:03:46Z

This is a bit awkaward, as I tried to duplicate how the existing code works, but 99% of the time this should be autodecteded anyway.

Apache-HBase · 2023-12-08T14:12:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests
uname	Linux 8336f3454085 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6e421e9`
Max. process+thread count	38 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-08T14:12:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests
uname	Linux 1e18f2e48a3d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6e421e9`
Max. process+thread count	29 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-08T14:13:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	spotless	0m 47s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
-0 ⚠️	shellcheck	0m 2s	The patch generated 1 new + 39 unchanged - 0 fixed = 40 total (was 39)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		3m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests	dupname asflicense spotless shellcheck shelldocs
uname	Linux 731df90054ff 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6e421e9`
shellcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/1/artifact/yetus-general-check/output/diff-patch-shellcheck.txt
Max. process+thread count	45 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/1/console
versions	git=2.34.1 maven=3.8.6 shellcheck=0.8.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2023-12-08T14:21:56Z

Optimized it a bit, and added printing HBASE_OPTS in debug mode.

Apache-HBase · 2023-12-08T14:27:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests
uname	Linux d71716f534f4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6e421e9`
Max. process+thread count	38 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-08T14:27:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests
uname	Linux aa0a4e634ff2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6e421e9`
Max. process+thread count	28 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-08T14:28:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	spotless	0m 45s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
-0 ⚠️	shellcheck	0m 1s	The patch generated 1 new + 39 unchanged - 0 fixed = 40 total (was 39)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		3m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests	dupname asflicense spotless shellcheck shelldocs
uname	Linux 75910e24d851 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6e421e9`
shellcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/2/artifact/yetus-general-check/output/diff-patch-shellcheck.txt
Max. process+thread count	45 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/2/console
versions	git=2.34.1 maven=3.8.6 shellcheck=0.8.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-08T14:42:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests
uname	Linux d1cf555973f3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6e421e9`
Max. process+thread count	41 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-08T14:42:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests
uname	Linux b8dfcbd501e9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6e421e9`
Max. process+thread count	32 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-08T14:43:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
-0 ⚠️	shellcheck	0m 1s	The patch generated 1 new + 39 unchanged - 0 fixed = 40 total (was 39)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 37s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		2m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests	dupname asflicense spotless shellcheck shelldocs
uname	Linux ef2875523b2a 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6e421e9`
shellcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/3/artifact/yetus-general-check/output/diff-patch-shellcheck.txt
Max. process+thread count	44 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/3/console
versions	git=2.34.1 maven=3.8.6 shellcheck=0.8.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-08T14:57:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests
uname	Linux e41617cbd968 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6e421e9`
Max. process+thread count	28 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-08T14:57:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests
uname	Linux c7de7131cbcc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6e421e9`
Max. process+thread count	37 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-08T14:58:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	spotless	0m 38s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
-0 ⚠️	shellcheck	0m 1s	The patch generated 1 new + 39 unchanged - 0 fixed = 40 total (was 39)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 37s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		2m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests	dupname asflicense spotless shellcheck shelldocs
uname	Linux 56015c92e29b 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6e421e9`
shellcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/4/artifact/yetus-general-check/output/diff-patch-shellcheck.txt
Max. process+thread count	44 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/4/console
versions	git=2.34.1 maven=3.8.6 shellcheck=0.8.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-08T15:12:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests
uname	Linux 2ec1b5a67032 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6e421e9`
Max. process+thread count	37 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-08T15:12:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests
uname	Linux 4ef98fd8ab5c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6e421e9`
Max. process+thread count	28 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-08T15:13:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
-0 ⚠️	shellcheck	0m 1s	The patch generated 1 new + 39 unchanged - 0 fixed = 40 total (was 39)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		2m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests	dupname asflicense spotless shellcheck shelldocs
uname	Linux 40f0b6305821 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6e421e9`
shellcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/5/artifact/yetus-general-check/output/diff-patch-shellcheck.txt
Max. process+thread count	45 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/5/console
versions	git=2.34.1 maven=3.8.6 shellcheck=0.8.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2023-12-10T14:07:19Z

Can we not duplicate a bunch of the existing code? At least we should not try jdk detection two times?

stoty · 2023-12-11T05:24:08Z

I have added caching to JDK detection, so it doesn't perform the expensive calls twice.
We could save and re-use the result in a variable directly, but I'm not sure if that would be more readable.

We could make some JDK version handling function, but I think that with the parameters, debug messages, and dynamically eveluated functions for lambdas, it would hurt readability more than help it.

However, the problematic JDK17 dependency is only present in tests, so don't have to bother with it in the runtime scripts.
I'm going to remove the JDK17 specific code.

…orts in the hbase script

Apache-HBase · 2023-12-11T05:42:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests
uname	Linux 63b23ca9025c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `82a2ce1`
Max. process+thread count	38 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/6/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-11T05:42:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests
uname	Linux ee827fbc0638 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `82a2ce1`
Max. process+thread count	29 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/6/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-11T05:43:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	spotless	0m 38s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	shellcheck	0m 2s	There were no new shellcheck issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		2m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests	dupname asflicense spotless shellcheck shelldocs
uname	Linux 4362a669ed55 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `82a2ce1`
Max. process+thread count	43 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/6/console
versions	git=2.34.1 maven=3.8.6 shellcheck=0.8.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2023-12-11T05:47:43Z

I have removed the JDK17 specific code, and updated the JIRA summary and the commit message.
I have left the version detection caching and the extra debug in, as I think those are generlly useful.
PTAL @Apache9 .

Apache-HBase · 2023-12-11T05:56:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests
uname	Linux 092799f1e54d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `82a2ce1`
Max. process+thread count	41 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/7/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-11T05:56:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 23s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests
uname	Linux 58db28169b61 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `82a2ce1`
Max. process+thread count	28 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/7/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-11T05:58:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	spotless	0m 38s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	shellcheck	0m 1s	There were no new shellcheck issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		2m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5571
Optional Tests	dupname asflicense spotless shellcheck shelldocs
uname	Linux 4e273ae9340c 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `82a2ce1`
Max. process+thread count	45 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5571/7/console
versions	git=2.34.1 maven=3.8.6 shellcheck=0.8.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…orts in the hbase script (#5571) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>

…orts in the hbase script (apache#5571) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>

…orts in the hbase script (#5571) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>

…orts in the hbase script (apache#5571) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>

…orts in the hbase script (#5571) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org> (cherry picked from commit 5503962)

…orts in the hbase script (apache#5571) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org> (cherry picked from commit b6ef44a) Change-Id: I2ed5e5acf02ffb371b607d7709cee62a5cbf9379

stoty force-pushed the HBASE-28252 branch from ba75af0 to cf0d5f2 Compare December 8, 2023 14:11

stoty force-pushed the HBASE-28252 branch from cf0d5f2 to a3a7fcf Compare December 8, 2023 14:25

stoty force-pushed the HBASE-28252 branch from a3a7fcf to 763c2a4 Compare December 8, 2023 14:33

stoty force-pushed the HBASE-28252 branch from 763c2a4 to f74b5ff Compare December 8, 2023 14:44

stoty force-pushed the HBASE-28252 branch from f74b5ff to 1b69a12 Compare December 8, 2023 15:09

HBASE-28252 Add sun.net.dns and sun.net.util to the JDK11+ module exp…

3c5f17e

…orts in the hbase script

stoty force-pushed the HBASE-28252 branch from acdbfea to 3c5f17e Compare December 11, 2023 05:43

stoty changed the title ~~HBASE-28252 Update JDK11 and add JDK17 options to hbase script~~ HBASE-28252 Add sun.net.dns and sun.net.util to the JDK11+ module exports in the hbase script Dec 11, 2023

Apache9 approved these changes Dec 11, 2023

View reviewed changes

meszibalu merged commit 5503962 into apache:master Dec 12, 2023
1 check passed

asfgit pushed a commit that referenced this pull request Dec 12, 2023

HBASE-28252 Add sun.net.dns and sun.net.util to the JDK11+ module exp…

879b529

…orts in the hbase script (#5571) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>

asfgit pushed a commit that referenced this pull request Dec 12, 2023

HBASE-28252 Add sun.net.dns and sun.net.util to the JDK11+ module exp…

1993048

…orts in the hbase script (#5571) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>

asfgit pushed a commit that referenced this pull request Dec 12, 2023

HBASE-28252 Add sun.net.dns and sun.net.util to the JDK11+ module exp…

e99a794

…orts in the hbase script (#5571) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>

asfgit pushed a commit that referenced this pull request Dec 12, 2023

HBASE-28252 Add sun.net.dns and sun.net.util to the JDK11+ module exp…

b6ef44a

…orts in the hbase script (#5571) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28252 Add sun.net.dns and sun.net.util to the JDK11+ module exports in the hbase script #5571

HBASE-28252 Add sun.net.dns and sun.net.util to the JDK11+ module exports in the hbase script #5571

stoty commented Dec 8, 2023

stoty commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

stoty commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache9 commented Dec 10, 2023

stoty commented Dec 11, 2023 •

edited

Apache-HBase commented Dec 11, 2023

Apache-HBase commented Dec 11, 2023

Apache-HBase commented Dec 11, 2023

stoty commented Dec 11, 2023

Apache-HBase commented Dec 11, 2023

Apache-HBase commented Dec 11, 2023

Apache-HBase commented Dec 11, 2023

HBASE-28252 Add sun.net.dns and sun.net.util to the JDK11+ module exports in the hbase script #5571

HBASE-28252 Add sun.net.dns and sun.net.util to the JDK11+ module exports in the hbase script #5571

Conversation

stoty commented Dec 8, 2023

stoty commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

stoty commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache-HBase commented Dec 8, 2023

Apache9 commented Dec 10, 2023

stoty commented Dec 11, 2023 • edited

Apache-HBase commented Dec 11, 2023

Apache-HBase commented Dec 11, 2023

Apache-HBase commented Dec 11, 2023

stoty commented Dec 11, 2023

Apache-HBase commented Dec 11, 2023

Apache-HBase commented Dec 11, 2023

Apache-HBase commented Dec 11, 2023

stoty commented Dec 11, 2023 •

edited