HBASE-28269 Fix broken ruby scripts and clean up logging #5588

NihalJain · 2023-12-19T10:26:01Z

Removed redundant imports and replaced unsupported methods with alternates
Removed usage of org.apache.logging.log4j and org.apache.log4j.Logger from ruby scripts
Added new methods in Log4jUtils.java and InternalLog4jUtils.java to be used as alternative in scripts
Disabled info/debug logging of existing ruby scripts to clean up noisy output

Apache-HBase · 2023-12-19T10:42:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 23s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5588
Optional Tests
uname	Linux 02aa147d8cd1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `53e01b2`
Max. process+thread count	33 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-19T10:42:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
		_ Patch Compile Tests _
		_ Other Tests _
		1m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5588
Optional Tests
uname	Linux aa636df07b6a 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `53e01b2`
Max. process+thread count	39 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-19T10:43:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	spotless	0m 45s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	rubocop	0m 8s	There were no new rubocop issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 37s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		3m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5588
Optional Tests	dupname asflicense spotless rubocop
uname	Linux 104d2dc730c0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `53e01b2`
Max. process+thread count	45 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/1/console
versions	git=2.34.1 maven=3.8.6 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2023-12-19T10:58:49Z

Testing out few more things, please hold.

NihalJain · 2023-12-19T11:41:18Z

In this PR have remove the redundant imports as the scripts run even w/o them. Also removed banned log4j imports.

Tested them as follows:

Build code with assembly:single
Untar the tarball
Start hbase in local mode
Create a table 't1' via shell: create 't1', 'cf'
Run following to test:
- ./hbase org.jruby.Main get-active-master.rb
- ./hbase org.jruby.Main replication/copy_tables_desc.rb 127.0.0.1:2181:/hbase 127.0.0.1:2181:/hbase t1
- ./hbase org.jruby.Main draining_servers.rb add hostname:16020
- ./hbase org.jruby.Main draining_servers.rb list
- ./hbase org.jruby.Main draining_servers.rb remove hostname:16020
- ./hbase org.jruby.Main shutdown_regionserver.rb IP:16020
Also copied new log4j command in shell verified no error.
Also ran hbase-shell tests locally

Will fix region_status.rb as part of HBASE-28273.

Apache-HBase · 2023-12-19T11:43:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 6s	Maven dependency ordering for branch
+1 💚	spotless	0m 37s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 4s	Maven dependency ordering for patch
-0 ⚠️	rubocop	0m 13s	The patch generated 14 new + 93 unchanged - 10 fixed = 107 total (was 103)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 37s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		3m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5588
Optional Tests	dupname asflicense spotless rubocop
uname	Linux 415b1c41493d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `53e01b2`
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	43 (vs. ulimit of 30000)
modules	C: . hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/2/console
versions	git=2.34.1 maven=3.8.6 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-19T15:59:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 54s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 38s	the patch passed
		_ Other Tests _
-1 ❌	unit	247m 18s	root in the patch failed.
		259m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5588
Optional Tests	unit
uname	Linux 81882c941960 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `53e01b2`
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/2/testReport/
Max. process+thread count	5208 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-19T19:08:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 7s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 32s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 17s	the patch passed
		_ Other Tests _
+1 💚	unit	436m 8s	root in the patch passed.
		447m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5588
Optional Tests	unit
uname	Linux 7785092b2440 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `53e01b2`
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/2/testReport/
Max. process+thread count	8496 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-20T05:39:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 3s	Maven dependency ordering for patch
-0 ⚠️	rubocop	0m 13s	The patch generated 14 new + 93 unchanged - 10 fixed = 107 total (was 103)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		3m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5588
Optional Tests	dupname asflicense spotless rubocop
uname	Linux a3453c651a31 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c07847`
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	43 (vs. ulimit of 30000)
modules	C: . hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/3/console
versions	git=2.34.1 maven=3.8.6 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-20T10:08:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 8s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 49s	the patch passed
		_ Other Tests _
-1 ❌	unit	256m 40s	root in the patch failed.
		272m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5588
Optional Tests	unit
uname	Linux 384985adcd2c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2c07847`
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/3/testReport/
Max. process+thread count	7513 (vs. ulimit of 30000)
modules	C: hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bin/get-active-master.rb

bin/replication/copy_tables_desc.rb

NihalJain · 2023-12-21T13:02:37Z

Updated title to include what the PR covers.

* Added new methods in Log4jUtils.java and InternalLog4jUtils.java * Disabled info/debug logging of existing scripts

Apache-HBase · 2023-12-21T13:46:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 54s	master passed
+1 💚	compile	4m 49s	master passed
+1 💚	checkstyle	1m 12s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	7m 5s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	4m 53s	the patch passed
-0 ⚠️	javac	4m 53s	root generated 1 new + 923 unchanged - 0 fixed = 924 total (was 923)
-0 ⚠️	checkstyle	1m 4s	root: The patch generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
-0 ⚠️	rubocop	0m 15s	The patch generated 21 new + 100 unchanged - 12 fixed = 121 total (was 112)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 55s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
-1 ❌	spotless	0m 8s	patch has 47 errors when running spotless:check, run spotless:apply to fix.
-1 ❌	spotbugs	0m 23s	hbase-logging generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-1 ❌	spotbugs	7m 2s	root generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 25s	The patch does not generate ASF License warnings.
		50m 37s

Reason	Tests
FindBugs	module:hbase-logging
	Dead store to level in org.apache.hadoop.hbase.logging.InternalLog4jUtils.setAllLevels(String, String) At InternalLog4jUtils.java:org.apache.hadoop.hbase.logging.InternalLog4jUtils.setAllLevels(String, String) At InternalLog4jUtils.java:[line 50]
FindBugs	module:root
	Dead store to level in org.apache.hadoop.hbase.logging.InternalLog4jUtils.setAllLevels(String, String) At InternalLog4jUtils.java:org.apache.hadoop.hbase.logging.InternalLog4jUtils.setAllLevels(String, String) At InternalLog4jUtils.java:[line 50]

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5588
Optional Tests	dupname asflicense spotless rubocop javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 0be3572d4492 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d084b4c`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/4/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/4/artifact/yetus-general-check/output/patch-spotless.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/4/artifact/yetus-general-check/output/new-spotbugs-hbase-logging.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/4/artifact/yetus-general-check/output/new-spotbugs-root.html
Max. process+thread count	175 (vs. ulimit of 30000)
modules	C: hbase-logging hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2023-12-21T13:48:20Z

Retested the following as follows:

Build code with assembly:single
Untar the tarball
Start hbase in local mode
- Start hbase shell and ensure logs are as expected
- Create a table 't1' via shell: create 't1', 'cf'
- Start hbase shell --debug and ensure debug logs are coming
Run following to test and ensure output/behaviour is as expected. Also now nosisy logging is not there:
- ./hbase org.jruby.Main get-active-master.rb
- ./hbase org.jruby.Main replication/copy_tables_desc.rb 127.0.0.1:2181:/hbase 127.0.0.1:2181:/hbase t1
- ./hbase org.jruby.Main draining_servers.rb add hostname:16020
- ./hbase org.jruby.Main draining_servers.rb list
- ./hbase org.jruby.Main draining_servers.rb remove hostname:16020
- ./hbase org.jruby.Main shutdown_regionserver.rb IP:16020
- Also modified one of the scripts and ensured setRootLevel works as expected
Also ran hbase-shell tests locally and ensured tests pass

hbase-logging/src/main/java/org/apache/hadoop/hbase/logging/InternalLog4jUtils.java

Apache-HBase · 2023-12-21T18:19:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 25s	master passed
+1 💚	compile	2m 26s	master passed
+1 💚	shadedjars	5m 38s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 45s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 28s	the patch passed
+1 💚	compile	2m 25s	the patch passed
+1 💚	javac	2m 25s	the patch passed
+1 💚	shadedjars	5m 33s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 46s	the patch passed
		_ Other Tests _
-1 ❌	unit	288m 20s	root in the patch failed.
		323m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5588
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 37c77deda29f 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d084b4c`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/4/testReport/
Max. process+thread count	5476 (vs. ulimit of 30000)
modules	C: hbase-logging hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-21T20:13:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 27s	master passed
+1 💚	compile	1m 31s	master passed
+1 💚	shadedjars	5m 1s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 34s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 13s	the patch passed
+1 💚	compile	1m 33s	the patch passed
+1 💚	javac	1m 33s	the patch passed
+1 💚	shadedjars	4m 59s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 33s	the patch passed
		_ Other Tests _
+1 💚	unit	409m 58s	root in the patch passed.
		437m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5588
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f23f62f4aeae 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d084b4c`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/4/testReport/
Max. process+thread count	8534 (vs. ulimit of 30000)
modules	C: hbase-logging hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-21T21:06:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 1s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 9s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 57s	master passed
+1 💚	compile	4m 55s	master passed
+1 💚	checkstyle	1m 5s	master passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
+1 💚	spotbugs	7m 4s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	compile	4m 46s	the patch passed
+1 💚	javac	4m 46s	the patch passed
+1 💚	checkstyle	1m 3s	the patch passed
-0 ⚠️	rubocop	0m 17s	The patch generated 3 new + 100 unchanged - 12 fixed = 103 total (was 112)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 55s	Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	7m 25s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 24s	The patch does not generate ASF License warnings.
		50m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5588
Optional Tests	dupname asflicense spotless rubocop javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux db60875339a8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d084b4c`
Default Java	Eclipse Adoptium-11.0.17+8
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/5/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	177 (vs. ulimit of 30000)
modules	C: hbase-logging hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/5/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-22T01:25:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 9s	master passed
+1 💚	compile	2m 1s	master passed
+1 💚	shadedjars	5m 30s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 7s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 49s	the patch passed
+1 💚	compile	1m 57s	the patch passed
+1 💚	javac	1m 57s	the patch passed
+1 💚	shadedjars	5m 26s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 4s	the patch passed
		_ Other Tests _
+1 💚	unit	278m 4s	root in the patch passed.
		309m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5588
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 37a31875b95c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d084b4c`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/5/testReport/
Max. process+thread count	8567 (vs. ulimit of 30000)
modules	C: hbase-logging hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-22T04:08:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 8s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 36s	master passed
+1 💚	compile	2m 16s	master passed
+1 💚	shadedjars	5m 48s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 0s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 57s	the patch passed
+1 💚	compile	2m 24s	the patch passed
+1 💚	javac	2m 24s	the patch passed
+1 💚	shadedjars	5m 34s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	438m 43s	root in the patch passed.
		472m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5588
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9efc378da93a 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d084b4c`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/5/testReport/
Max. process+thread count	7884 (vs. ulimit of 30000)
modules	C: hbase-logging hbase-shell . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5588/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

* Removed redundant imports and replaced unsupported methods with alternates * Removed usage of `org.apache.logging.log4j` and `org.apache.log4j.Logger` from ruby scripts * Added new methods in `Log4jUtils.java` and `InternalLog4jUtils.java` to be used as alternative in scripts * Disabled info/debug logging of existing ruby scripts to clean up noisy output Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 4e8d93d)

NihalJain · 2023-12-22T09:07:48Z

Build code with assembly:single

Untar the tarball

Start hbase in local mode

Start hbase shell and ensure logs are as expected

Create a table 't1' via shell: create 't1', 'cf'

Start hbase shell --debug and ensure debug logs are coming

Run following to test and ensure output/behaviour is as expected. Also now nosisy logging is not there:

./hbase org.jruby.Main get-active-master.rb

./hbase org.jruby.Main replication/copy_tables_desc.rb 127.0.0.1:2181:/hbase 127.0.0.1:2181:/hbase t1

./hbase org.jruby.Main draining_servers.rb add hostname:16020

./hbase org.jruby.Main draining_servers.rb list

./hbase org.jruby.Main draining_servers.rb remove hostname:16020

./hbase org.jruby.Main shutdown_regionserver.rb IP:16020

Also modified one of the scripts and ensured setRootLevel works as expected

Also ran hbase-shell tests locally and ensured tests pass

Tested above on branch-2.5+ and pushed change.
Code does not apply directly on 2.4. As the scripts works fine there w/o the patch too, skipping.

Thanks for the review @Apache9 !

* Removed redundant imports and replaced unsupported methods with alternates * Removed usage of `org.apache.logging.log4j` and `org.apache.log4j.Logger` from ruby scripts * Added new methods in `Log4jUtils.java` and `InternalLog4jUtils.java` to be used as alternative in scripts * Disabled info/debug logging of existing ruby scripts to clean up noisy output Signed-off-by: Duo Zhang <zhangduo@apache.org>

HBASE-28269 Ruby scripts are broken as they import non-existent classes

7b8b088

NihalJain requested a review from Apache9 December 19, 2023 10:32

NihalJain marked this pull request as draft December 19, 2023 10:58

Handle banned log4j imports

60b25f2

NihalJain marked this pull request as ready for review December 19, 2023 11:44

Apache9 reviewed Dec 21, 2023

View reviewed changes

bin/get-active-master.rb Outdated Show resolved Hide resolved

NihalJain commented Dec 21, 2023

View reviewed changes

bin/replication/copy_tables_desc.rb Show resolved Hide resolved

NihalJain changed the title ~~HBASE-28269 Ruby scripts are broken as they import non-existent classes~~ HBASE-28269 Fix broken ruby scripts and clean up logging Dec 21, 2023

NihalJain requested a review from Apache9 December 21, 2023 13:05

* Remove usage of org.apache.logging.log4j.core.config.Configurator

f334fb1

* Added new methods in Log4jUtils.java and InternalLog4jUtils.java * Disabled info/debug logging of existing scripts

NihalJain force-pushed the HBASE-28269 branch from 6e5fe03 to f334fb1 Compare December 21, 2023 13:11

NihalJain commented Dec 21, 2023

View reviewed changes

hbase-logging/src/main/java/org/apache/hadoop/hbase/logging/InternalLog4jUtils.java Outdated Show resolved Hide resolved

Fix findbug and rubocop warnings

ae3ef7c

NihalJain force-pushed the HBASE-28269 branch from 85c9b68 to ae3ef7c Compare December 21, 2023 15:21

Apache9 approved these changes Dec 22, 2023

View reviewed changes

NihalJain merged commit 4e8d93d into apache:master Dec 22, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28269 Fix broken ruby scripts and clean up logging #5588

HBASE-28269 Fix broken ruby scripts and clean up logging #5588

NihalJain commented Dec 19, 2023 •

edited

Loading

Apache-HBase commented Dec 19, 2023

Apache-HBase commented Dec 19, 2023

Apache-HBase commented Dec 19, 2023

NihalJain commented Dec 19, 2023

NihalJain commented Dec 19, 2023 •

edited

Loading

Apache-HBase commented Dec 19, 2023

Apache-HBase commented Dec 19, 2023

Apache-HBase commented Dec 19, 2023

Apache-HBase commented Dec 20, 2023

Apache-HBase commented Dec 20, 2023

NihalJain commented Dec 21, 2023

Apache-HBase commented Dec 21, 2023

NihalJain commented Dec 21, 2023

Apache-HBase commented Dec 21, 2023

Apache-HBase commented Dec 21, 2023

Apache-HBase commented Dec 21, 2023

Apache-HBase commented Dec 22, 2023

Apache-HBase commented Dec 22, 2023

NihalJain commented Dec 22, 2023 •

edited

Loading

HBASE-28269 Fix broken ruby scripts and clean up logging #5588

HBASE-28269 Fix broken ruby scripts and clean up logging #5588

Conversation

NihalJain commented Dec 19, 2023 • edited Loading

Apache-HBase commented Dec 19, 2023

Apache-HBase commented Dec 19, 2023

Apache-HBase commented Dec 19, 2023

NihalJain commented Dec 19, 2023

NihalJain commented Dec 19, 2023 • edited Loading

Apache-HBase commented Dec 19, 2023

Apache-HBase commented Dec 19, 2023

Apache-HBase commented Dec 19, 2023

Apache-HBase commented Dec 20, 2023

Apache-HBase commented Dec 20, 2023

NihalJain commented Dec 21, 2023

Apache-HBase commented Dec 21, 2023

NihalJain commented Dec 21, 2023

Apache-HBase commented Dec 21, 2023

Apache-HBase commented Dec 21, 2023

Apache-HBase commented Dec 21, 2023

Apache-HBase commented Dec 22, 2023

Apache-HBase commented Dec 22, 2023

NihalJain commented Dec 22, 2023 • edited Loading

NihalJain commented Dec 19, 2023 •

edited

Loading

NihalJain commented Dec 19, 2023 •

edited

Loading

NihalJain commented Dec 22, 2023 •

edited

Loading