Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-28302 Add tracking of fs read times in ScanMetrics and slow logs #5622

Merged
merged 2 commits into from
Jan 23, 2024
Merged

HBASE-28302 Add tracking of fs read times in ScanMetrics and slow logs #5622

merged 2 commits into from
Jan 23, 2024

Conversation

bbeaudreault
Copy link
Contributor

These have proven very useful for us in tracking down HDFS slowness and breaking down where scan time is spent.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 1s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 3m 11s master passed
+1 💚 compile 4m 32s master passed
+1 💚 checkstyle 1m 29s master passed
+1 💚 spotless 0m 44s branch has no errors when running spotless:check.
+1 💚 spotbugs 5m 34s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 2m 49s the patch passed
+1 💚 compile 4m 27s the patch passed
+1 💚 cc 4m 27s the patch passed
+1 💚 javac 4m 27s the patch passed
-0 ⚠️ checkstyle 0m 34s hbase-server: The patch generated 1 new + 11 unchanged - 0 fixed = 12 total (was 11)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 5m 42s Patch does not cause any errors with Hadoop 3.3.6.
+1 💚 hbaseprotoc 2m 26s the patch passed
+1 💚 spotless 0m 51s patch has no errors when running spotless:check.
+1 💚 spotbugs 8m 42s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 56s The patch does not generate ASF License warnings.
52m 15s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5622/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5622
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname Linux dae15ad39915 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a7429a7
Default Java Eclipse Adoptium-11.0.17+8
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5622/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5622/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 12s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 55s master passed
+1 💚 compile 2m 29s master passed
+1 💚 shadedjars 5m 8s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 38s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 54s the patch passed
+1 💚 compile 3m 0s the patch passed
+1 💚 javac 3m 0s the patch passed
+1 💚 shadedjars 5m 56s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 44s the patch passed
_ Other Tests _
+1 💚 unit 0m 40s hbase-protocol-shaded in the patch passed.
+1 💚 unit 0m 42s hbase-hadoop-compat in the patch passed.
+1 💚 unit 1m 36s hbase-client in the patch passed.
+1 💚 unit 234m 23s hbase-server in the patch passed.
+1 💚 unit 7m 5s hbase-thrift in the patch passed.
277m 14s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5622/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5622
Optional Tests javac javadoc unit shadedjars compile
uname Linux 4038ad055e76 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a7429a7
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5622/1/testReport/
Max. process+thread count 5038 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5622/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 2m 39s master passed
+1 💚 compile 1m 48s master passed
+1 💚 shadedjars 5m 30s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 11s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 22s the patch passed
+1 💚 compile 1m 48s the patch passed
+1 💚 javac 1m 48s the patch passed
+1 💚 shadedjars 5m 25s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 11s the patch passed
_ Other Tests _
+1 💚 unit 0m 26s hbase-protocol-shaded in the patch passed.
+1 💚 unit 0m 33s hbase-hadoop-compat in the patch passed.
+1 💚 unit 1m 20s hbase-client in the patch passed.
-1 ❌ unit 302m 53s hbase-server in the patch failed.
+1 💚 unit 7m 41s hbase-thrift in the patch passed.
340m 45s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5622/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5622
Optional Tests javac javadoc unit shadedjars compile
uname Linux 8a26027dac96 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a7429a7
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5622/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5622/1/testReport/
Max. process+thread count 4681 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5622/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 2m 55s master passed
+1 💚 compile 4m 27s master passed
+1 💚 checkstyle 1m 26s master passed
+1 💚 spotless 0m 42s branch has no errors when running spotless:check.
+1 💚 spotbugs 5m 24s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 2m 45s the patch passed
+1 💚 compile 4m 28s the patch passed
+1 💚 cc 4m 28s the patch passed
+1 💚 javac 4m 28s the patch passed
+1 💚 checkstyle 1m 25s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 5m 7s Patch does not cause any errors with Hadoop 3.3.6.
+1 💚 hbaseprotoc 1m 42s the patch passed
+1 💚 spotless 0m 39s patch has no errors when running spotless:check.
+1 💚 spotbugs 6m 3s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 36s The patch does not generate ASF License warnings.
45m 40s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5622/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5622
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname Linux b5828899aa65 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a683fcf
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 81 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5622/2/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 19s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 35s master passed
+1 💚 compile 2m 4s master passed
+1 💚 shadedjars 5m 0s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 23s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 2m 25s the patch passed
+1 💚 compile 2m 4s the patch passed
+1 💚 javac 2m 4s the patch passed
+1 💚 shadedjars 4m 58s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 23s the patch passed
_ Other Tests _
+1 💚 unit 0m 30s hbase-protocol-shaded in the patch passed.
+1 💚 unit 0m 40s hbase-hadoop-compat in the patch passed.
+1 💚 unit 1m 27s hbase-client in the patch passed.
+1 💚 unit 231m 0s hbase-server in the patch passed.
+1 💚 unit 7m 6s hbase-thrift in the patch passed.
269m 52s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5622/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5622
Optional Tests javac javadoc unit shadedjars compile
uname Linux 4aa3c0e82add 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a683fcf
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5622/2/testReport/
Max. process+thread count 5451 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5622/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 10s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 2m 59s master passed
+1 💚 compile 2m 26s master passed
+1 💚 shadedjars 5m 6s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 37s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 2m 48s the patch passed
+1 💚 compile 2m 26s the patch passed
+1 💚 javac 2m 26s the patch passed
+1 💚 shadedjars 5m 3s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 37s the patch passed
_ Other Tests _
+1 💚 unit 0m 39s hbase-protocol-shaded in the patch passed.
+1 💚 unit 0m 42s hbase-hadoop-compat in the patch passed.
+1 💚 unit 1m 32s hbase-client in the patch passed.
-1 ❌ unit 255m 15s hbase-server in the patch failed.
+1 💚 unit 7m 21s hbase-thrift in the patch passed.
295m 24s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5622/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5622
Optional Tests javac javadoc unit shadedjars compile
uname Linux c7dc6a4daafa 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a683fcf
Default Java Eclipse Adoptium-11.0.17+8
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5622/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5622/2/testReport/
Max. process+thread count 5149 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-hadoop-compat hbase-client hbase-server hbase-thrift U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5622/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk
ndimiduk approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I'm surprised to see that we have committed a generated thrift file.

@bbeaudreault
Copy link
Contributor Author

Thanks for the review! Yea it's pretty annoying to handle thrift, since I needed to go figure out how to generate them. But that seems to be how it works today. We could probably try to give it the protobuf-like treatment in a separate jira if anyone wants to improve the thrift build.

@bbeaudreault bbeaudreault merged commit 3a91c5b into apache:master Jan 23, 2024
1 check failed
@bbeaudreault bbeaudreault deleted the HBASE-28302 branch January 23, 2024 16:05
bbeaudreault added a commit that referenced this pull request Jan 23, 2024
@bbeaudreault
HBASE-28302 Add tracking of fs read times in ScanMetrics and slow logs (
cfa7acb 
#5622)

Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
bbeaudreault added a commit that referenced this pull request Jan 23, 2024
@bbeaudreault
HBASE-28302 Add tracking of fs read times in ScanMetrics and slow logs (
5488acf 
#5622)

Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
bbeaudreault added a commit that referenced this pull request Jan 23, 2024
@bbeaudreault
HBASE-28302 Add tracking of fs read times in ScanMetrics and slow logs (
af9c763 
#5622)

Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndimiduk ndimiduk ndimiduk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bbeaudreault @Apache-HBase @ndimiduk