Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-28327 Add remove(String name, Metric metric) method to MetricRegistry #5647

Merged
merged 3 commits into from
Jan 25, 2024
Merged

HBASE-28327 Add remove(String name, Metric metric) method to MetricRegistry #5647

merged 3 commits into from
Jan 25, 2024

Conversation

eab148
Copy link
Contributor

@eab148 eab148 commented Jan 24, 2024

JIRA: https://issues.apache.org/jira/browse/HBASE-28327

This will help us clean up metrics safely. We will remove a Metric with the specified name from the metric registry if and only if the provided metric matches the object in the registry.

@eab148 eab148 marked this pull request as draft January 24, 2024 22:29
@eab148 eab148 changed the title HBASE-28327 Add remove(String name, Metric metric) method to MetricRegistry HBASE-28327 Add remove(String name, Metric metric) method to MetricRegistry Jan 24, 2024
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 3m 10s master passed
+1 💚 compile 0m 25s master passed
+1 💚 checkstyle 0m 12s master passed
+1 💚 spotless 0m 44s branch has no errors when running spotless:check.
+1 💚 spotbugs 0m 32s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 2m 57s the patch passed
+1 💚 compile 0m 24s the patch passed
+1 💚 javac 0m 24s the patch passed
+1 💚 checkstyle 0m 12s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 5m 33s Patch does not cause any errors with Hadoop 3.3.6.
+1 💚 spotless 0m 42s patch has no errors when running spotless:check.
+1 💚 spotbugs 0m 46s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
23m 44s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5647
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux b646b7786b2e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 354a3a2
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-metrics-api hbase-metrics U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 3m 35s master passed
+1 💚 compile 0m 23s master passed
+1 💚 shadedjars 6m 27s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 23s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 59s the patch passed
+1 💚 compile 0m 26s the patch passed
+1 💚 javac 0m 26s the patch passed
+1 💚 shadedjars 6m 51s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 25s the patch passed
_ Other Tests _
+1 💚 unit 0m 16s hbase-metrics-api in the patch passed.
+1 💚 unit 0m 22s hbase-metrics in the patch passed.
25m 16s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5647
Optional Tests javac javadoc unit shadedjars compile
uname Linux 8d47f0204bba 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 354a3a2
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/testReport/
Max. process+thread count 197 (vs. ulimit of 30000)
modules C: hbase-metrics-api hbase-metrics U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 58s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 3m 36s master passed
+1 💚 compile 0m 31s master passed
+1 💚 shadedjars 7m 22s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 29s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for patch
+1 💚 mvninstall 3m 54s the patch passed
+1 💚 compile 0m 33s the patch passed
+1 💚 javac 0m 33s the patch passed
+1 💚 shadedjars 7m 14s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 30s the patch passed
_ Other Tests _
+1 💚 unit 0m 19s hbase-metrics-api in the patch passed.
+1 💚 unit 0m 22s hbase-metrics in the patch passed.
27m 32s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5647
Optional Tests javac javadoc unit shadedjars compile
uname Linux 4b9b9175c0d4 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 354a3a2
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/testReport/
Max. process+thread count 168 (vs. ulimit of 30000)
modules C: hbase-metrics-api hbase-metrics U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5647/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@eab148 eab148 marked this pull request as ready for review January 24, 2024 23:11
@bbeaudreault bbeaudreault merged commit ef1ddc9 into apache:master Jan 25, 2024
1 check passed
@bbeaudreault bbeaudreault deleted the HBASE-28327 branch January 25, 2024 13:17
bbeaudreault pushed a commit that referenced this pull request Jan 25, 2024
@eab148 @bbeaudreault
HBASE-28327 Add remove(String key, Metric metric) method to MetricReg…
2db27ae 
…istry interface (#5647)

Co-authored-by: Evie Boland <eboland@hubspot.com>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
bbeaudreault pushed a commit that referenced this pull request Jan 25, 2024
@eab148 @bbeaudreault
HBASE-28327 Add remove(String key, Metric metric) method to MetricReg…
be73106 
…istry interface (#5647)

Co-authored-by: Evie Boland <eboland@hubspot.com>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
bbeaudreault pushed a commit that referenced this pull request Jan 25, 2024
@eab148 @bbeaudreault
HBASE-28327 Add remove(String key, Metric metric) method to MetricReg…
feec643 
…istry interface (#5647)

Co-authored-by: Evie Boland <eboland@hubspot.com>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
bbeaudreault pushed a commit that referenced this pull request Jan 25, 2024
@eab148 @bbeaudreault
HBASE-28327 Add remove(String key, Metric metric) method to MetricReg…
9ab35a0 
…istry interface (#5647)

Co-authored-by: Evie Boland <eboland@hubspot.com>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
bbeaudreault pushed a commit to HubSpot/hbase that referenced this pull request Jan 25, 2024
@eab148 @bbeaudreault
HubSpot Backport: HBASE-28327 Add remove(String key, Metric metric) m…
64b6288 
…ethod to MetricRegistry interface (apache#5647)

Co-authored-by: Evie Boland <eboland@hubspot.com>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbeaudreault bbeaudreault bbeaudreault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@eab148 @Apache-HBase @bbeaudreault