HBASE-28349 Count atomic operations against read quotas #5668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
bbeaudreault
reviewed
Feb 7, 2024
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RegionServerRpcQuotaManager.java
Outdated
Show resolved
Hide resolved
bbeaudreault
reviewed
Feb 7, 2024
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestAtomicReadQuota.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
bbeaudreault
reviewed
Feb 8, 2024
| * @return the OperationQuota | ||
| * @throws RpcThrottlingException if the operation cannot be executed due to quota exceeded. | ||
| */ | ||
| public OperationQuota checkQuota(final Region region, final OperationQuota.OperationType type) | ||
| throws IOException, RpcThrottlingException { | ||
| public OperationQuota checkQuota(final Region region, final OperationQuota.OperationType type, |
There was a problem hiding this comment.
I'm thinking we should add another OperationType CHECK_AND_MUTATE. We can pass that in here instead of adding an isAtomic boolean. We can also add a util in QuotaUtil to return an OperationType for an Action + hasCondition boolean.
We can then use that same api in the other checkQuota below. Something like:
for (final ClientProtos.Action action : actions) {
OperationType type = QuotaUtil.getOperationType(action, hasCondition);
if (type.isRead()) {
numReads++;
}
if (type.isWrite()) {
numWrites++;
}
}The goal with this change is to DRY up the mutation type checking, and also to clarify a bit. Currently we are using the isAtomic boolean name which I'm realizing is not accurate. RowMutations is an example of an atomic operation which is not conditional (thus has no reads).
bbeaudreault
reviewed
Feb 8, 2024
| @@ -2679,7 +2679,8 @@ public MultiResponse multi(final RpcController rpcc, final MultiRequest request) | |||
|
|
|||
| try { | |||
| region = getRegion(regionSpecifier); | |||
| quota = getRpcQuotaManager().checkQuota(region, regionAction.getActionList()); | |||
| quota = getRpcQuotaManager().checkQuota(region, regionAction.getActionList(), | |||
| regionAction.getAtomic()); | |||
There was a problem hiding this comment.
per my other comment about RowMutations I think we actually want to change this and the other usage of getAtomic to hasCondition. I'm realizing that getAtomic seems specific to RowMutations, which may or may not be conditional depending of if the RowMutations is called via mutateRow, batch, or checkAndMutate (only the last one is conditional).
With this, we'll need to update your RowMutations test to ensure that it doesnt count against read capacity unless its a checkAndMutate
bbeaudreault
reviewed
Feb 8, 2024
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestAtomicReadQuota.java
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
bbeaudreault
approved these changes
Feb 8, 2024
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
bbeaudreault
pushed a commit
that referenced
this pull request
Feb 8, 2024
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
bbeaudreault
pushed a commit
to HubSpot/hbase
that referenced
this pull request
Feb 8, 2024
…otas (apache#5668) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
rmdmattingly
added a commit
to HubSpot/hbase
that referenced
this pull request
Feb 8, 2024
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now atomic operations are just treated as a single write from the quota perspective. Since an atomic operation also encompasses a read, it would make sense to increment readNum and readSize counts appropriately.
cc @bbeaudreault @hgromer @eab148 @bozzkar