HBASE-28391 Remove the need for ADMIN permissions for listDecommissionedRegionServers #5695

shahrs87 · 2024-02-21T23:33:30Z

No description provided.

…nedRegionServers

Apache-HBase · 2024-02-22T00:07:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 25s	master passed
+1 💚	compile	2m 43s	master passed
+1 💚	checkstyle	0m 37s	master passed
+1 💚	spotless	0m 47s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 37s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 6s	the patch passed
+1 💚	compile	2m 42s	the patch passed
-0 ⚠️	javac	2m 42s	hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
+1 💚	checkstyle	0m 36s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	5m 43s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 44s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 47s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		31m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5695/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5695
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux f823ccf3f3e2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7be588e`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5695/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5695/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-22T03:52:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 41s	master passed
+1 💚	compile	0m 43s	master passed
+1 💚	shadedjars	5m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 26s	the patch passed
+1 💚	compile	0m 41s	the patch passed
+1 💚	javac	0m 41s	the patch passed
+1 💚	shadedjars	5m 7s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	233m 56s	hbase-server in the patch passed.
		256m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5695/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5695
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d6113507b54c 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7be588e`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5695/1/testReport/
Max. process+thread count	5602 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5695/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-22T03:53:27Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 43s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 3s	master passed
+1 💚	compile	0m 49s	master passed
+1 💚	shadedjars	5m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 49s	the patch passed
+1 💚	compile	0m 51s	the patch passed
+1 💚	javac	0m 51s	the patch passed
+1 💚	shadedjars	5m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	233m 33s	hbase-server in the patch passed.
		257m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5695/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5695
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4b479a7235d6 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7be588e`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5695/1/testReport/
Max. process+thread count	4660 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5695/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2024-02-22T11:41:47Z

hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java

@@ -1203,12 +1203,6 @@ public void preDecommissionRegionServers(ObserverContext<MasterCoprocessorEnviro
    requirePermission(ctx, "decommissionRegionServers", Action.ADMIN);
  }

-  @Override


IMO we should not drop the method. If we want to allow every user to be able to be able to do so, we should have a no-op method and capture same as comments.

Although I am curious why only this change when we have other methods around listing?

Although I am curious why only this change when we have other methods around listing?

Just saw the JIRA description.

Also, please have a look at @Apache9 comment to change this to Action.READ. And also to start a discussion thread on dev list about this.

Updated to Action.READ. However I am curious to know the difference between removing this method vs having a no-op method?

And also to start a discussion thread on dev list about this.

Created a thread here. https://lists.apache.org/thread/vcf50plmsx59yh4fyvsfpo7xht4rbhz8

However I am curious to know the difference between removing this method vs having a no-op method?

IMO removing a method may send a false impression to a future auditor that there is no Access Rule defined for the method or it is somehow missing. And the person may end up re-adding the method. So it's better to have it, even if no-op.

Makes sense !!

…8391

Apache-HBase · 2024-02-27T05:34:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 17s	master passed
+1 💚	compile	2m 29s	master passed
+1 💚	checkstyle	0m 34s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 52s	the patch passed
+1 💚	compile	2m 31s	the patch passed
+1 💚	javac	2m 31s	the patch passed
+1 💚	checkstyle	0m 34s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	5m 12s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 32s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		28m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5695/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5695
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux e19bcc7f81c3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c4a02f7`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5695/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-27T09:21:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 42s	master passed
+1 💚	compile	0m 42s	master passed
+1 💚	shadedjars	5m 5s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 25s	the patch passed
+1 💚	compile	0m 42s	the patch passed
+1 💚	javac	0m 42s	the patch passed
+1 💚	shadedjars	5m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	234m 9s	hbase-server in the patch passed.
		256m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5695/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5695
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 29f5df2aa883 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c4a02f7`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5695/2/testReport/
Max. process+thread count	6073 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5695/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-27T09:29:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 58s	master passed
+1 💚	compile	0m 48s	master passed
+1 💚	shadedjars	5m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 49s	the patch passed
+1 💚	compile	0m 52s	the patch passed
+1 💚	javac	0m 52s	the patch passed
+1 💚	shadedjars	5m 12s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	238m 42s	hbase-server in the patch passed.
		264m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5695/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5695
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9fb37d3083b1 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c4a02f7`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5695/2/testReport/
Max. process+thread count	4519 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5695/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain

LGTM, given no objections are raised in mailing list.

…nedRegionServers (#5695) (cherry picked from commit 4b55243)

HBASE-28391 Remove the need for ADMIN permissions for listDecommissio…

f18f2eb

…nedRegionServers

NihalJain reviewed Feb 22, 2024

View reviewed changes

shahrs87 added 2 commits February 26, 2024 10:18

Merge branch 'master' of https://github.com/apache/hbase into HBASE-2…

2c3efd6

…8391

HBASE-28391 Change to READ

b1361ba

NihalJain approved these changes Feb 27, 2024

View reviewed changes

Apache9 approved these changes Feb 27, 2024

View reviewed changes

shahrs87 merged commit 4b55243 into apache:master Feb 27, 2024
1 check passed

shahrs87 added a commit that referenced this pull request Feb 27, 2024

HBASE-28391 Remove the need for ADMIN permissions for listDecommissio…

9e7cced

…nedRegionServers (#5695) (cherry picked from commit 4b55243)

shahrs87 added a commit that referenced this pull request Feb 27, 2024

HBASE-28391 Remove the need for ADMIN permissions for listDecommissio…

db6c4b2

…nedRegionServers (#5695) (cherry picked from commit 4b55243)

shahrs87 added a commit that referenced this pull request Feb 27, 2024

HBASE-28391 Remove the need for ADMIN permissions for listDecommissio…

d69f6d8

…nedRegionServers (#5695) (cherry picked from commit 4b55243)

shahrs87 added a commit that referenced this pull request Feb 27, 2024

HBASE-28391 Remove the need for ADMIN permissions for listDecommissio…

7636a2d

…nedRegionServers (#5695) (cherry picked from commit 4b55243)

shahrs87 added a commit that referenced this pull request Feb 27, 2024

HBASE-28391 Remove the need for ADMIN permissions for listDecommissio…

9459bd0

…nedRegionServers (#5695) (cherry picked from commit 4b55243)

shahrs87 deleted the HBASE-28391 branch February 27, 2024 20:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28391 Remove the need for ADMIN permissions for listDecommissionedRegionServers #5695

HBASE-28391 Remove the need for ADMIN permissions for listDecommissionedRegionServers #5695

shahrs87 commented Feb 21, 2024

Apache-HBase commented Feb 22, 2024

Apache-HBase commented Feb 22, 2024

Apache-HBase commented Feb 22, 2024

NihalJain Feb 22, 2024

NihalJain Feb 22, 2024 •

edited

Loading

shahrs87 Feb 27, 2024

NihalJain Feb 27, 2024

shahrs87 Feb 27, 2024

Apache-HBase commented Feb 27, 2024

Apache-HBase commented Feb 27, 2024

Apache-HBase commented Feb 27, 2024

NihalJain left a comment

HBASE-28391 Remove the need for ADMIN permissions for listDecommissionedRegionServers #5695

HBASE-28391 Remove the need for ADMIN permissions for listDecommissionedRegionServers #5695

Conversation

shahrs87 commented Feb 21, 2024

Apache-HBase commented Feb 22, 2024

Apache-HBase commented Feb 22, 2024

Apache-HBase commented Feb 22, 2024

NihalJain Feb 22, 2024

Choose a reason for hiding this comment

NihalJain Feb 22, 2024 • edited Loading

Choose a reason for hiding this comment

shahrs87 Feb 27, 2024

Choose a reason for hiding this comment

NihalJain Feb 27, 2024

Choose a reason for hiding this comment

shahrs87 Feb 27, 2024

Choose a reason for hiding this comment

Apache-HBase commented Feb 27, 2024

Apache-HBase commented Feb 27, 2024

Apache-HBase commented Feb 27, 2024

NihalJain left a comment

Choose a reason for hiding this comment

NihalJain Feb 22, 2024 •

edited

Loading