HBASE-28417 TestBlockingIPC.testBadPreambleHeader sometimes fails with… #5740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
changed the title
…h broken pipe instead of bad auth Also change the IPC related tests to test different combinations of rpc server&client, for example, NettyRpcClient and SimpleRpcServer
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
ndimiduk
approved these changes
Mar 5, 2024
| @@ -114,14 +118,12 @@ public abstract class AbstractTestIPC { | |||
| private static final KeyValue CELL = new KeyValue(CELL_BYTES, CELL_BYTES, CELL_BYTES, CELL_BYTES); | |||
|
|
|||
| protected static final Configuration CONF = HBaseConfiguration.create(); | |||
There was a problem hiding this comment.
Can you get rid of this static CONF instance entirely. All of its accesses in this class are using it with a copy constructor, but TestNettyTlsIPC is using/modifying it directly.
There was a problem hiding this comment.
We can not get rid of it, we need to change some configurations in setUp and tearDown. And in TestNettyTlsIPC, we need to change the configurations in setUpBeforeClass, so it has to be static...
There was a problem hiding this comment.
The copying in the tests method is because we need to customize some client configurations, so we want to affect other test methods.
| BadAuthException error = null; | ||
| // for SimpleRpcServer, it is possible that we get a broken pipe before getting the | ||
| // BadAuthException, so we add some retries here, see HBASE-28417 | ||
| for (int i = 0; i < 10; i++) { |
There was a problem hiding this comment.
Haha, same request as I received from @NihalJain -- can this use Waiter instead?
There was a problem hiding this comment.
Here the things are a bit different. It is not something that after some time, things will go right. We just need to try several times, and we should get at least one time, things go as expected...
The tests runs pretty fast, as it does not need to setup a mini cluster, just start some socket servers. On my local machine, the TestNettyIPC can be finished within 15 seconds. |
bbeaudreault
approved these changes
Mar 5, 2024
Apache9
added a commit
that referenced
this pull request
Mar 6, 2024
…h broken pipe instead of bad auth (#5740) Also change the IPC related tests to test different combinations of rpc server&client, for example, NettyRpcClient and SimpleRpcServer Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> (cherry picked from commit 2306820)
Apache9
added a commit
that referenced
this pull request
Mar 6, 2024
…h broken pipe instead of bad auth (#5740) Also change the IPC related tests to test different combinations of rpc server&client, for example, NettyRpcClient and SimpleRpcServer Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> (cherry picked from commit 2306820)
Apache9
added a commit
that referenced
this pull request
Mar 6, 2024
…h broken pipe instead of bad auth (#5740) Also change the IPC related tests to test different combinations of rpc server&client, for example, NettyRpcClient and SimpleRpcServer Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> (cherry picked from commit 2306820)
Apache9
added a commit
that referenced
this pull request
Mar 6, 2024
…h broken pipe instead of bad auth (#5740) Also change the IPC related tests to test different combinations of rpc server&client, for example, NettyRpcClient and SimpleRpcServer Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> (cherry picked from commit 2306820)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… broken pipe instead of bad auth
Also change the IPC related tests to test different combinations of rpc server&client, for example, NettyRpcClient and SimpleRpcServer