HBASE-28469: Changes for enabling data-tiering checks during cacheOnWrite (compaction codepaths) #5908
+1,272
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-cache (apache#5793) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…or Time Range Data Tiering (apache#5809) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…in prefetch functionality of HBase (apache#5808) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…pache#5829) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…ache#5856) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…rite (compaction codepaths) Change-Id: Ic8f11b328a911f23fc1f1c120a331b21847865bc
jhungund
commented
May 16, 2024
| private boolean shouldCacheBlock() { | ||
| DataTieringManager dataTieringManager = DataTieringManager.getInstance(); | ||
| if (dataTieringManager != null) { | ||
| return dataTieringManager.isHotData(timeRangeTracker, conf); |
There was a problem hiding this comment.
If we do not want to expose the isHotData call taking an argument of timeRangeTracker, we could wrap this metadata into some data holder (eg: define a new class DataTieringMetadata) so that we can abstract the time-range specific information. We will need to set the time-range in that metadata object and pass it to isHotData(), which will internally check the dataTieringType and perform the required checks
There was a problem hiding this comment.
We should move this shouldCacheBlock to the CacheConfig class.
|
💔 -1 overall
This message was automatically generated. |
wchevreuil
reviewed
May 16, 2024
| private boolean shouldCacheBlock() { | ||
| DataTieringManager dataTieringManager = DataTieringManager.getInstance(); | ||
| if (dataTieringManager != null) { | ||
| return dataTieringManager.isHotData(timeRangeTracker, conf); |
There was a problem hiding this comment.
We should move this shouldCacheBlock to the CacheConfig class.
| @@ -57,6 +61,7 @@ | |||
| import org.apache.yetus.audience.InterfaceAudience; | |||
| import org.slf4j.Logger; | |||
| import org.slf4j.LoggerFactory; | |||
| import javax.xml.crypto.Data; | |||
wchevreuil
force-pushed
the
HBASE-28463
branch
2 times, most recently
from
c392345
to
7527a74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT SUBMIT.
Change-Id: Ic8f11b328a911f23fc1f1c120a331b21847865bc