Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-23090 Update start-hbase.sh and stop-hbase.sh #665

Closed
wants to merge 3 commits into from

Conversation

Tikiri16
Copy link

removed extra '=' sign which gave an error: "55: [: false: unexpected operator"

removed extra '=' sign which gave an error: "55: [: false: unexpected operator"
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
💙 reexec 1m 10s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💙 shelldocs 0m 0s Shelldocs was not available.
💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
💚 shellcheck 0m 0s There were no new shellcheck issues.
💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
💚 asflicense 0m 17s The patch does not generate ASF License warnings.
2m 41s
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-665/1/artifact/out/Dockerfile
GITHUB PR #665
Optional Tests dupname asflicense shellcheck shelldocs
uname Linux 925ce572ad76 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-665/out/precommit/personality/provided.sh
git revision master / 3250a80
Max. process+thread count 47 (vs. ulimit of 10000)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-665/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani
Copy link
Contributor

Thanks for the PR @Tikiri16
Could you please specify the relevant Jira here?

@Tikiri16 Tikiri16 changed the title Update start-hbase.sh HBASE-23090 Update start-hbase.sh Sep 28, 2019
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally this change should not be required. Did you try with ./start-hbase.sh or sh start-hbase.sh?

@Tikiri16 Tikiri16 changed the title HBASE-23090 Update start-hbase.sh HBASE-23090 Update start-hbase.sh and stop-hbase.sh Oct 7, 2019
@Tikiri16
Copy link
Author

Tikiri16 commented Oct 7, 2019

Yes, I tried using ./ but, it still showed that error.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 36s Docker mode activated.
_ Prechecks _
💚 dupname 0m 1s No case conflicting files found.
💙 shelldocs 0m 1s Shelldocs was not available.
💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
💔 shellcheck 0m 1s The patch generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21)
💔 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
_ Other Tests _
💚 asflicense 0m 18s The patch does not generate ASF License warnings.
2m 7s
Subsystem Report/Notes
Docker Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-665/2/artifact/out/Dockerfile
GITHUB PR #665
Optional Tests dupname asflicense shellcheck shelldocs
uname Linux 6f393cc0a559 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-665/out/precommit/personality/provided.sh
git revision master / 1366c4d
shellcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-665/2/artifact/out/diff-patch-shellcheck.txt
whitespace https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-665/2/artifact/out/whitespace-eol.txt
Max. process+thread count 51 (vs. ulimit of 10000)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-665/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@busbey
Copy link
Contributor

busbey commented Oct 10, 2019

Just confirmed both of these scripts work as-is using HBase 2.2.1 on Ubuntu 18 with Bash 4.4.20(1). Something is incorrect in your environment, please bring the issue up on the user@hbase mailing list.

@busbey busbey closed this Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants