Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-23177 If fail to open reference because FNFE, make it plain it … #726

Closed
wants to merge 1 commit into from

Conversation

saintstack
Copy link
Contributor

…is a Reference

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 31s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
💚 mvninstall 6m 27s master passed
💚 compile 0m 56s master passed
💚 checkstyle 1m 19s master passed
💚 shadedjars 4m 41s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 0m 38s master passed
💙 spotbugs 3m 59s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 3m 57s master passed
_ Patch Compile Tests _
💚 mvninstall 4m 54s the patch passed
💚 compile 0m 56s the patch passed
💚 javac 0m 56s the patch passed
💚 checkstyle 1m 17s the patch passed
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 4m 34s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 15m 53s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚 javadoc 0m 35s the patch passed
💚 findbugs 4m 17s the patch passed
_ Other Tests _
💚 unit 165m 23s hbase-server in the patch passed.
💚 asflicense 0m 35s The patch does not generate ASF License warnings.
223m 18s
Subsystem Report/Notes
Docker Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-726/1/artifact/out/Dockerfile
GITHUB PR #726
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 68ae99931add 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-726/out/precommit/personality/provided.sh
git revision master / 7924ba3
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-726/1/testReport/
Max. process+thread count 4623 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-726/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@busbey busbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh lord thank you, yes merge and backport pls.

Copy link
Contributor

@Apache9 Apache9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@@ -19,11 +19,17 @@

import static org.junit.Assert.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid start import? Not your fault but I think we can fix this checkstyle issue by the way.

@saintstack
Copy link
Contributor Author

Merged it offline so I could add in handling of @Apache9 suggestion.

@saintstack saintstack closed this Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants