Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-23230 Enforce member visibility in HRegionServer #806

Commits on Nov 7, 2019

  1. HBASE-23230 Enforce member visibility in HRegionServer (apache#775)

     * Clean up a bunch of private variable leakage into other
       classes. Reduces visibility as much as possible, providing getters
       where access remains necessary or making use of getters that
       already exist. There remains an insidious relationship between
       `HRegionServer` and `RSRpcServices`.
     * Rename `fs` to `dataFs`, `rootDir` as `dataRootDir` so as to
       distinguish from the new `walFs`, `walRootDir` (and make it easier
       to spot bugs).
     * Cleanup or delete a bunch of lack-luster javadoc comments.
     * Delete a handful of methods that are unused according to static
       analysis.
     * Reduces the warning count as reported by IntelliJ from 100 to 7.
    
    Signed-off-by: stack <stack@apache.org>
    ndimiduk committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    6fa9f48 View commit details
    Browse the repository at this point in the history