HBASE-23322 [hbck2] Simplification on HBCKSCP scheduling #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stack <stack@apache.org>
Apache9
reviewed
Nov 20, 2019
| @@ -231,13 +232,13 @@ public static void fullScanTables(Connection connection, final Visitor visitor) | |||
| * Callers should call close on the returned {@link Table} instance. | |||
| * @param connection connection we're using to access Meta | |||
| * @return An {@link Table} for <code>hbase:meta</code> | |||
| * @throws NullPointerException if {@code connection} is {@code null} | |||
There was a problem hiding this comment.
I think the intention here should be 'do not pass null connection'?
| @@ -83,10 +83,8 @@ public void reset() { | |||
| } | |||
|
|
|||
| protected void init() { | |||
| Preconditions.checkState(iv != null, "IV is null"); | |||
There was a problem hiding this comment.
IllegalState instead of NPE?
| @@ -582,10 +562,7 @@ synchronized long expireServer(final ServerName serverName, | |||
| return Procedure.NO_PROC_ID; | |||
| } | |||
| LOG.info("Processing expiration of " + serverName + " on " + this.master.getServerName()); | |||
| long pid = function.apply(serverName); | |||
| if (pid <= 0) { | |||
There was a problem hiding this comment.
We do not need this test any more? It will skip the later listener calls.
| @@ -1502,26 +1503,38 @@ public long submitServerCrash(ServerName serverName, boolean shouldSplitWal) { | |||
| // server state to CRASHED, we will no longer accept the reportRegionStateTransition call from | |||
| // this server. This is used to simplify the implementation for TRSP and SCP, where we can make | |||
| // sure that, the region list fetched by SCP will not be changed any more. | |||
| serverNode.writeLock().lock(); | |||
| if (serverNode != null) { | |||
There was a problem hiding this comment.
I think here we'd better extract a special method for handling the unknown server case? It will make the code much cleaner, now lots of serverNode != null in the code base which means the code hard to understand...
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.