HBASE-23259: Populate master address end points in cluster/rs configs… #858

bharathv · 2019-11-20T20:57:43Z

… (#807)

All the clients need to know the master RPC end points while using master
based registry for creating cluster connections. This patch amends the
test cluster utility to populate these configs in the base configuration
object used to spin up the cluster.

The config key added here ("hbase.master.addrs") is used in the subsequent
patches for HBASE-18095.

Signed-off-by: Nick Dimiduk ndimiduk@apache.org
(cherry picked from commit 834ccb4)

bharathv · 2019-11-20T20:58:07Z

@apurtell @ndimiduk FYI, for branch-1.

Apache-HBase · 2019-11-20T22:16:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	29m 9s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ branch-1 Compile Tests _
+0 🆗	mvndep	1m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	8m 8s	branch-1 passed
+1 💚	compile	1m 9s	branch-1 passed with JDK v1.8.0_232
+1 💚	compile	1m 21s	branch-1 passed with JDK v1.7.0_242
+1 💚	checkstyle	2m 22s	branch-1 passed
+1 💚	shadedjars	3m 54s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 4s	branch-1 passed with JDK v1.8.0_232
+1 💚	javadoc	1m 13s	branch-1 passed with JDK v1.7.0_242
+0 🆗	spotbugs	3m 2s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	4m 16s	branch-1 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
-1 ❌	mvninstall	1m 18s	root in the patch failed.
+1 💚	compile	1m 3s	the patch passed with JDK v1.8.0_232
+1 💚	javac	1m 3s	the patch passed
-1 ❌	compile	0m 40s	hbase-server in the patch failed with JDK v1.7.0_242.
-1 ❌	javac	0m 40s	hbase-server in the patch failed with JDK v1.7.0_242.
+1 💚	checkstyle	0m 31s	The patch passed checkstyle in hbase-common
+1 💚	checkstyle	1m 48s	hbase-server: The patch generated 0 new + 29 unchanged - 1 fixed = 29 total (was 30)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	shadedjars	2m 11s	patch has 16 errors when building our shaded downstream artifacts.
-1 ❌	hadoopcheck	1m 20s	The patch causes 16 errors with Hadoop v2.8.5.
-1 ❌	hadoopcheck	3m 40s	The patch causes 16 errors with Hadoop v2.9.2.
+1 💚	javadoc	0m 52s	the patch passed with JDK v1.8.0_232
+1 💚	javadoc	1m 16s	the patch passed with JDK v1.7.0_242
-1 ❌	findbugs	0m 35s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	2m 53s	hbase-common in the patch passed.
-1 ❌	unit	0m 40s	hbase-server in the patch failed.
+1 💚	asflicense	0m 25s	The patch does not generate ASF License warnings.
		76m 16s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/1/artifact/out/Dockerfile
GITHUB PR	#858
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux b4ae25803112 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-858/out/precommit/personality/provided.sh
git revision	branch-1 / `eee337f`
Default Java	1.7.0_242
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
mvninstall	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/1/artifact/out/patch-mvninstall-root.txt
compile	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/1/artifact/out/patch-compile-hbase-server-jdk1.7.0_242.txt
javac	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/1/artifact/out/patch-compile-hbase-server-jdk1.7.0_242.txt
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/1/artifact/out/patch-shadedjars.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/1/artifact/out/patch-javac-2.8.5.txt
hadoopcheck	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/1/artifact/out/patch-javac-2.9.2.txt
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/1/artifact/out/patch-findbugs-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/1/testReport/
Max. process+thread count	181 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/1/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

bharathv · 2019-11-20T23:13:40Z

Ah String.join() not in jdk7. Will force push shortly. Sorry for the noise.

…apache#807) All the clients need to know the master RPC end points while using master based registry for creating cluster connections. This patch amends the test cluster utility to populate these configs in the base configuration object used to spin up the cluster. The config key added here ("hbase.master.addrs") is used in the subsequent patches for HBASE-18095. Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit 834ccb4)

Apache-HBase · 2019-11-21T02:53:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ branch-1 Compile Tests _
+0 🆗	mvndep	1m 27s	Maven dependency ordering for branch
+1 💚	mvninstall	8m 0s	branch-1 passed
+1 💚	compile	0m 58s	branch-1 passed with JDK v1.8.0_232
+1 💚	compile	1m 8s	branch-1 passed with JDK v1.7.0_242
+1 💚	checkstyle	2m 1s	branch-1 passed
+1 💚	shadedjars	2m 52s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 51s	branch-1 passed with JDK v1.8.0_232
+1 💚	javadoc	1m 3s	branch-1 passed with JDK v1.7.0_242
+0 🆗	spotbugs	2m 42s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 47s	branch-1 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	1m 59s	the patch passed
+1 💚	compile	0m 58s	the patch passed with JDK v1.8.0_232
+1 💚	javac	0m 58s	the patch passed
+1 💚	compile	1m 6s	the patch passed with JDK v1.7.0_242
+1 💚	javac	1m 6s	the patch passed
-1 ❌	checkstyle	1m 33s	hbase-server: The patch generated 1 new + 29 unchanged - 1 fixed = 30 total (was 30)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	2m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	5m 11s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	javadoc	0m 49s	the patch passed with JDK v1.8.0_232
+1 💚	javadoc	1m 3s	the patch passed with JDK v1.7.0_242
+1 💚	findbugs	4m 3s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 36s	hbase-common in the patch passed.
+1 💚	unit	151m 5s	hbase-server in the patch passed.
+1 💚	asflicense	0m 57s	The patch does not generate ASF License warnings.
		202m 37s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/2/artifact/out/Dockerfile
GITHUB PR	#858
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 09c87676b898 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-858/out/precommit/personality/provided.sh
git revision	branch-1 / `eee337f`
Default Java	1.7.0_242
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/2/artifact/out/diff-checkstyle-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/2/testReport/
Max. process+thread count	4465 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-858/2/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

ndimiduk

Thanks @bharathv !

bharathv force-pushed the branch-1-HBASE-23259 branch from cd625c5 to 54bcfe4 Compare November 20, 2019 23:23

ndimiduk approved these changes Nov 21, 2019

View reviewed changes

ndimiduk merged commit eb5e94a into apache:branch-1 Nov 21, 2019

bharathv deleted the branch-1-HBASE-23259 branch November 21, 2019 17:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-23259: Populate master address end points in cluster/rs configs… #858

HBASE-23259: Populate master address end points in cluster/rs configs… #858

bharathv commented Nov 20, 2019

bharathv commented Nov 20, 2019

Apache-HBase commented Nov 20, 2019

bharathv commented Nov 20, 2019

Apache-HBase commented Nov 21, 2019

ndimiduk left a comment

HBASE-23259: Populate master address end points in cluster/rs configs… #858

HBASE-23259: Populate master address end points in cluster/rs configs… #858

Conversation

bharathv commented Nov 20, 2019

bharathv commented Nov 20, 2019

Apache-HBase commented Nov 20, 2019

bharathv commented Nov 20, 2019

Apache-HBase commented Nov 21, 2019

ndimiduk left a comment

Choose a reason for hiding this comment