-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade helix-front to Angular 7.2 #2087
Merged
NealSun96
merged 29 commits into
apache:master
from
micahstubbs:micahstubbs/2084/upgrade-to-angular-7.2
Jun 1, 2022
Merged
Upgrade helix-front to Angular 7.2 #2087
NealSun96
merged 29 commits into
apache:master
from
micahstubbs:micahstubbs/2084/upgrade-to-angular-7.2
Jun 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 11, 2022
This was referenced May 18, 2022
b8ba53b
to
ab24cc8
Compare
10 tasks
…t alternative linting script
…angular-cli semver parsing bug. npm install
…e,forms,material,platform-browser,platform-browser-dynamic,platform-server,router}@6.1.0
This reverts commit f9e2e37.
…angular/core@7 as well as manually update cdk and material to ^7.2.16
… in @angular/flex-layout@7.0.0-beta.23
ab24cc8
to
9fc507b
Compare
Fix security vulnerabilities in helix-front dependencies. Upgrade helix-front dependencies to improve contributor productivity.
41b6287
to
43f2e1c
Compare
LGTM |
1 similar comment
LGTM |
This PR is ready to be merged, approved by @somecodemonkey upgrade helix-front to Angular 7.2 Fix #2084
|
This was referenced Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fix #2084
Description
This PR upgrades helix-front to Angular 7.2. This PR completely contains earlier helix-front upgrade PRs #2083 and #2078. These previous Angular major-version PRs should be merged first.
Tests
Let's test the upgrade from Angular 6.1 to Angular 7.2:
npm install
worksnpm run type:check:watch
shows 0 TypeScript errorsnpm run lint
runs and passesAll files pass linting.
npm run build
worksnpm start
works, with 0 errors in the browser console.npm run test
appears to work.npm start
works as expected, and recognizes our proxy config inproxy.conf.json
.Helix UI renders with XX errors and YY warning in the browser console. The warning is understandable since the piwik telemetry library is not configured.
npm run test
resultsDocumentation
Not applicable since this PR does not contain new functionality, only tooling and dependency upgrades.
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)
Not applicable since this PR does not make any changes to the Java codebase.