Upgrade helix-front to Angular 9.1 #2094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erial,platform-browser,platform-browser-dynamic,platform-server,router}@^5.2.0 @angular/flex-layout@5.0.0-beta.14 typescript@2.4.2 rxjs@^5.5.2
…t alternative linting script
…angular-cli semver parsing bug. npm install
…e,forms,material,platform-browser,platform-browser-dynamic,platform-server,router}@6.1.0
This reverts commit 013042e.
This reverts commit ef68413.
…#2074) helix-front: specify known working nodejs and npm versions in package.json
…erial,platform-browser,platform-browser-dynamic,platform-server,router}@^5.2.0 @angular/flex-layout@5.0.0-beta.14 typescript@2.4.2 rxjs@^5.5.2
…#2074) helix-front: specify known working nodejs and npm versions in package.json
…erial,platform-browser,platform-browser-dynamic,platform-server,router}@^5.2.0 @angular/flex-layout@5.0.0-beta.14 typescript@2.4.2 rxjs@^5.5.2
This was referenced May 18, 2022
|
will close for bad merge earlier |
|
New PR with clean history: #2125 |
This was referenced Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fix #2092
Description
This PR upgrades helix-front to Angular 9.1. This PR completely contains earlier helix-front upgrade PRs #2092, #2087, #2083, and #2078. These previous Angular major-version PRs should be merged first.
Tests
Let's test the upgrade from Angular 8.2 to Angular 9.1.
npm installworksnpm run type:check:watchshows 0 TypeScript errorsnpm run lintruns and passesAll files pass linting.npm run buildworksnpm startworks, with 0 errors in the browser console.npm run testruns and passes.npm startworks as expected, and recognizes our proxy config inproxy.conf.json.Helix UI renders with 0 errors and 1 warning in the browser console. The warning is understandable since the piwik telemetry library is not configured.
npm run testresultsDocumentation
Not applicable since this PR does not contain new functionality, only tooling and dependency upgrades.
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)
Not applicable since this PR does not make any changes to the Java codebase.