-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zookeeper-api module to Apache Helix #684
Conversation
244eba7
to
e929bd2
Compare
7266705
to
0bcba2c
Compare
e23ee8b
to
bdedd6d
Compare
Overall, the structure looks good to me. Just one thing: for the module folder. org/apache/helix/zookeeper/api/api. Shall we leave the module folder as org/apache/helix/zookeeper/api/... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Make sure you addressed other comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for working on this huge task.
One concern is the ivy file helix-core/helix-core-0.9.2-SNAPSHOT.ivy. 'commons-math3" is used by the WAGED rebalancer, I think we need to keep it in the ivy file.
Updated the .ivy file. |
This PR is ready to be merged, approved by @dasahcc @jiajunwang Add metrics-common, zookeeper-api, helix-common modules We want to create a new module called zookeeper-api in order to decouple Helix's ZooKeeper APIs from helix-core. The goal is to enable non-Helix applications to use Helix's ZooKeeper APIs to use ZooKeeper. |
We want to create a new module called zookeeper-api in order to decouple Helix's ZooKeeper APIs from helix-core. The goal is to enable non-Helix applications to use Helix's ZooKeeper APIs. This change also allows for better modularity and separation of concerns.
We want to create a new module called zookeeper-api in order to decouple Helix's ZooKeeper APIs from helix-core. The goal is to enable non-Helix applications to use Helix's ZooKeeper APIs. This change also allows for better modularity and separation of concerns.
Issues
Fixes #631 Fixes #556
Description
https://github.com/apache/helix/wiki/New-Modules-for-Apache-Helix
Tests
All existing tests are kept.
helix-agent
helix-rest
helix-admin-webapp
-> This is a known failing test.
helix-core
These tests pass when run individually.
Commits
Documentation
https://github.com/apache/helix/wiki/New-modules-for-Apache-Helix
Code Quality