Skip to content

Pull Request Merge Steps

Micah Stubbs edited this page May 29, 2022 · 4 revisions
  1. Create a PR for review.

  2. Address all comments and feedback. You will need at least one approval from Helix contributors. In order to become a Helix contributor, one must have made at least 5 commits to Helix.

  3. Leave a final comment on the PR stating:

This PR is ready to be merged
  1. If you have made multiple commits for one PR, these commits will be squashed into one commit at merge time. If this is the case, you must include one final commit message for the squashed commit in your final comment. This way, the squashed commit will be merged into master cleanly, and the history of all commits for the PR will be kept intact for future reference.

  2. Helix PMC/Committers will only merge the PRs with no pending comments and with the final approval message from Steps 3 and 4.

Clone this wiki locally