Skip to content

Pull Request Testing

Micah Stubbs edited this page May 29, 2022 · 2 revisions

If new functionality is being added, the pull request should include tests, either as unit tests, integration tests, or both.

Before you submit a pull request from your forked repo, you are expected to make sure all tests pass (not just newly added ones). To do this, run the "mvn test" command from the root of the project and include the result in the pull request.

If tests fail that seem unrelated to the changes in the pull request, more specific testing may be done. Directly run "mvn test" for the following modules:

  • /helix-core
  • /zookeeper-api
  • /helix-rest
  • /helix-common

With the exception of /helix-core, all tests should pass. For helix-core, there can currently be as many as 3-4 failing tests depending on the machine (test stabilization efforts are currently in progress). At that point, run the failing tests individually using the Maven command "mvn test -Dtest=". Usually when the failed tests are run individually, they pass. If they don't that means something is legitimately wrong.

Any failing tests, even those that succeed when run individually, should be documented in the pull request as well.

Clone this wiki locally