Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-24635: Support Values clause as operand of set operation #1869

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

kasakrisz
Copy link
Contributor

What changes were proposed in this pull request?

  1. Move the valuesSource rule alternative from queryStatementExpression parser rule to atomSelectStatement
  2. Remove valuesClause rule alternative from regularBody since it is covered through
    selectStatement->atomSelectStatement->valuesSource->valuesClause

Why are the changes needed?

Enable queries which has values clause as operand of set operation. See jira or values.q for example

Does this PR introduce any user-facing change?

Yes. Users can write queries which has values clause as operand of set operation. This feature was not enabled in the past and Hive thrown exception such cases. Existing queries are not affected.

How was this patch tested?

mvn test -Dtest=TestValuesClause -pl parser
mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=values.q -pl itests/qtest -Pitests

Copy link
Contributor

@jcamachor jcamachor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (pending tests)

@kasakrisz kasakrisz merged commit 8903232 into apache:master Jan 15, 2021
@kasakrisz kasakrisz deleted the HIVE-24635-master-values-union branch May 4, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants