HIVE-24944: When the default engine of the hiveserver is MR and the t… #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests failed
tests unstable
tests passed
and removed
tests unstable
tests pending
tests failed
labels
dengzhhu653
approved these changes
May 25, 2021
|
Hi @anishek, could you please take another look on the changes? thanks. |
|
Hey @thejasmn, @kgyrtkirk could you please take another look if have secs? |
|
Looks alright. Can you do me a quick favor and switch statement it? switch(engineInSessionConf) {
case "tez":
case "mr":
default:
} |
…ez engine is set by the client, the client TEZ progress log cannot be printed normally（ZhangQidong reviewed by Zhihua Deng)
kgyrtkirk
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
labels
kgyrtkirk
added
tests pending
tests unstable
tests passed
and removed
tests unstable
tests pending
labels
|
Hi @belugabehr @dengzhhu653 @thejasmn @kgyrtkirk @anishek |
dengzhhu653
reviewed
Jun 28, 2021
| case "spark": | ||
| mapper = new SparkProgressMonitorStatusMapper(); | ||
| break; | ||
| default: |
There was a problem hiding this comment.
nit: maybe we could remove the default execution path here?
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
See the: https://issues.apache.org/jira/browse/HIVE-24944
Why are the changes needed?
When the default engine of the hiveserver is MR and the tez engine is set by the client, the client TEZ progress log cannot be printed normally
Does this PR introduce any user-facing change?
No
How was this patch tested?
Remote cluster.