Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIVE-24944: When the default engine of the hiveserver is MR and the t… #2204

Closed
wants to merge 1 commit into from
Closed

HIVE-24944: When the default engine of the hiveserver is MR and the t… #2204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 14 additions & 5 deletions service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,11 +794,20 @@ public TGetOperationStatusResp GetOperationStatus(TGetOperationStatusReq req) th
}
JobProgressUpdate progressUpdate = operationStatus.jobProgressUpdate();
ProgressMonitorStatusMapper mapper = ProgressMonitorStatusMapper.DEFAULT;
if ("tez".equals(hiveConf.getVar(ConfVars.HIVE_EXECUTION_ENGINE))) {
mapper = new TezProgressMonitorStatusMapper();
}
if ("spark".equals(hiveConf.getVar(ConfVars.HIVE_EXECUTION_ENGINE))) {
mapper = new SparkProgressMonitorStatusMapper();
String engineInSessionConf = cliService.getSessionManager().getOperationManager()
.getOperation(operationHandle)
.getParentSession()
.getHiveConf()
.getVar(ConfVars.HIVE_EXECUTION_ENGINE);
switch (engineInSessionConf) {
case "tez":
mapper = new TezProgressMonitorStatusMapper();
break;
case "spark":
mapper = new SparkProgressMonitorStatusMapper();
break;
default:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe we could remove the default execution path here?

break;
}
TJobExecutionStatus executionStatus =
mapper.forStatus(progressUpdate.status);
Expand Down