HIVE-25306: Move Date and Timestamp parsing from ResolverStyle.LENIENT to ResolverStyle.STRICT #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zabetak Could you please review the PR? |
kgyrtkirk
added
tests pending
tests unstable
and removed
tests failed
tests pending
tests unstable
labels
ashish-kumar-sharma
force-pushed
the
HIVE-25306
branch
from
c4f1e0b
to
5ad7510
Compare
kgyrtkirk
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
labels
mattmccline-microsoft
approved these changes
Jul 8, 2021
|
This is going to change the behavior for customers. Previously, the queries which used to work fine, will start throwing exception now. |
sankarh
reviewed
Jul 9, 2021
ql/src/test/queries/clientpositive/materialized_view_rewrite_in_between.q
Outdated
Show resolved
Hide resolved
...a/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
Outdated
Show resolved
Hide resolved
I'm also in favour of keeping this change within a config. |
|
@mattmccline-microsoft @ashish-kumar-sharma @sankarh I added a few comments in the JIRA since I think we should agree there before doing a line by line review. |
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
zabetak
reviewed
Jul 21, 2021
common/src/test/org/apache/hive/common/util/TestTimestampParser.java
Outdated
Show resolved
Hide resolved
common/src/test/org/apache/hive/common/util/TestTimestampParser.java
Outdated
Show resolved
Hide resolved
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFAddMonths.java
Show resolved
Hide resolved
common/src/java/org/apache/hive/common/util/TimestampParser.java
Outdated
Show resolved
Hide resolved
...a/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
Outdated
Show resolved
Hide resolved
kgyrtkirk
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
adesh-rao
approved these changes
Jul 22, 2021
zabetak
approved these changes
Jul 23, 2021
zchovan
pushed a commit
to zchovan/hive
that referenced
this pull request
Jul 29, 2021
…sh Kumar Sharma, reviewed by Adesh Kumar Rao, Matt McCline, Sankar Hariappan, Stamatis Zampetakis) With this change parsing string literals to dates/timestamps does not tolerate dates which do not conform exactly to the expected syntax and does not compensate for months, days, etc., out of the usual ranges. When the literal cannot be parsed the null value is returned adopting the default MySQL behavior. This is a breaking change. Closes apache#2445
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
…sh Kumar Sharma, reviewed by Adesh Kumar Rao, Matt McCline, Sankar Hariappan, Stamatis Zampetakis) With this change parsing string literals to dates/timestamps does not tolerate dates which do not conform exactly to the expected syntax and does not compensate for months, days, etc., out of the usual ranges. When the literal cannot be parsed the null value is returned adopting the default MySQL behavior. This is a breaking change. Closes apache#2445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently Date.java and Timestamp.java use DateTimeFormatter for parsing to convert the date/timpstamp from int,string,char etc to Date or Timestamp.
Default DateTimeFormatter which use ResolverStyle.LENIENT which mean date like "1992-13-12" is converted to "2000-01-12",
Moving DateTimeFormatter which use ResolverStyle.STRICT which mean date like "1992-13-12" is not be converted instead NULL is return.
Why are the changes needed?
ResolverStyle.LENIENT to ResolverStyle.STRICT
Does this PR introduce any user-facing change?
No
How was this patch tested?
UTs and QTs added as part of PR