Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIVE-24483: Bump protobuf version to 3.7.1 (aarch64 support). #3498

Merged
merged 9 commits into from
Aug 11, 2022
Merged

HIVE-24483: Bump protobuf version to 3.7.1 (aarch64 support). #3498

merged 9 commits into from
Aug 11, 2022

Conversation

ayushtkn
Copy link
Member

@ayushtkn ayushtkn commented Aug 3, 2022

Exploratory Sate: See what all breaks

@Noremac201
Copy link
Contributor

Won't standalone-metastore/pom.xml also need to be updated?

@ayushtkn
Copy link
Member Author

ayushtkn commented Aug 3, 2022

yep, @Noremac201 I updated there and there were some explicit changes for Aarch because of lower version of protobuf, have updated that.
Saw 2 Hbase related failure in the last build, may be upgrading Hbase version should solve them, will check post the next build result

@ayushtkn ayushtkn mentioned this pull request Aug 4, 2022
Closed
@ayushtkn
Copy link
Member Author

ayushtkn commented Aug 4, 2022

Got a green build with 3.7.1 version(the red is due to oracle init failing), which is same as with one present in hadoop. Attempted to upgraded to 3.21.1 which is the latest.
Tried building on AArch-64 as well and the build was successful

@slachiewicz
Copy link
Member

You shout also regenerate code running with Protobuf profile see #3500

@github-actions github-actions bot requested a review from pgaref August 4, 2022 15:43
@ayushtkn ayushtkn requested a review from zabetak August 5, 2022 06:50
@ayushtkn
Copy link
Member Author

ayushtkn commented Aug 5, 2022

Build is green. Tried compiling on OS-X-Aarch64 and I was able to get a successful mvn clean install -DskipTests without any hacks or tweaks.

Awaiting reviews now. :-)

@ayushtkn ayushtkn requested a review from zabetak August 9, 2022 20:16
zabetak
zabetak approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@zabetak zabetak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ayushtkn ayushtkn merged commit 18501dd into apache:master Aug 11, 2022
DongWei-4 pushed a commit to DongWei-4/hive that referenced this pull request Oct 28, 2022
@ayushtkn @DongWei-4
HIVE-24483: aarch64 Support: Bump protobuf version to 3.21.4 (apache#…
b8562c7 
…3498). (Ayush Saxena, reviewed by Stamatis Zampetakis and  Sylwester Lachiewicz)
dengzhhu653 pushed a commit to dengzhhu653/hive that referenced this pull request Dec 15, 2022
@ayushtkn @dengzhhu653
HIVE-24483: aarch64 Support: Bump protobuf version to 3.21.4 (apache#…
5ef4fc5 
…3498). (Ayush Saxena, reviewed by Stamatis Zampetakis and  Sylwester Lachiewicz)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slachiewicz slachiewicz slachiewicz approved these changes

@zabetak zabetak zabetak approved these changes

@pgaref pgaref Awaiting requested review from pgaref

@abstractdog abstractdog Awaiting requested review from abstractdog

Assignees
No one assigned
Labels
tests passed
Projects
None yet
Milestone
No milestone
5 participants
@ayushtkn @Noremac201 @slachiewicz @zabetak @kgyrtkirk