Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-26890 : Disable TestSSL#testConnectionWrongCertCN (Done as part of HIVE-22621 in master) #3895

Merged
merged 1 commit into from Jan 5, 2023

Conversation

amanraj2520
Copy link
Contributor

@amanraj2520 amanraj2520 commented Dec 27, 2022

This was done as part of HIVE-22621 on oss/master. This test also fails with the same error in Hive-3.1.3 release. So we can safely ignore this test from branch-3. Please find the JIRA link : https://issues.apache.org/jira/browse/HIVE-26890

@amanraj2520
Copy link
Contributor Author

@abstractdog @zabetak @cnauroth Can you please review this.

@amanraj2520
Copy link
Contributor Author

@abstractdog @zabetak @cnauroth Can you please review this

@abstractdog
Copy link
Contributor

I think this has nothing to do with HIVE-21456 itself, HIVE-21456 only changed the class level @ignore to method level
b7da718
the original disable commit was in the scope of HIVE-22620 (fix) / HIVE-22621 (disable)

for clarity's sake let's call this "Disable TestSSL#testConnectionWrongCertCN" and refer to HIVE-22621
other than that, looks good to me

@abstractdog abstractdog changed the title HIVE-26890 : Disable TestSSL (Done as part of HIVE-21456 in oss/master) HIVE-26890 : Disable TestSSL#testConnectionWrongCertCN (Done as part of HIVE-22621 in master) Jan 2, 2023
@abstractdog abstractdog self-requested a review January 2, 2023 19:46
@amanraj2520
Copy link
Contributor Author

@abstractdog I agree with you on the same. Updated the description.

@amanraj2520
Copy link
Contributor Author

@abstractdog Can we please merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants