Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-26890: [2.3] Disable TestSSL#testConnectionWrongCertCN (Done as part of HIVE-22621 in master) #4506

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Jul 20, 2023

What changes were proposed in this pull request?

Disable the consistently failed test TestSSL#testConnectionWrongCertCN

Why are the changes needed?

It was disabled by HIVE-22621 in master, and by #3895 in branch-3.

The test failed consistently at

assertTrue(e.toString().contains("java.security.cert.CertificateException"));

Suspect was caused by the JDK upgrading which changed the behavior. Anyway, just follow what master did.

Does this PR introduce any user-facing change?

No.

Is the change a dependency upgrade?

No.

How was this patch tested?

Jekins

@pan3793
Copy link
Member Author

pan3793 commented Jul 27, 2023

ping @sunchao

Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunchao sunchao changed the title HIVE-26890. [2.3] Disable TestSSL#testConnectionWrongCertCN (Done as part of HIVE-22621 in master) HIVE-26890: [2.3] Disable TestSSL#testConnectionWrongCertCN (Done as part of HIVE-22621 in master) Jul 27, 2023
@sunchao sunchao merged commit 0a970dc into apache:branch-2.3 Jul 27, 2023
@sunchao
Copy link
Member

sunchao commented Jul 27, 2023

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants