Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-26880: [2.3] Upgrade Apache Directory Server to 1.5.7 #4487

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Jul 15, 2023

What changes were proposed in this pull request?

Same as #3815 (for branch-3)

branch-2.3 uses Apache Directory Server in some tests. It currently uses version 1.5.6. This version has a transitive dependency to a SNAPSHOT, making it awkward to build and release. We can upgrade to 1.5.7 to remove the SNAPSHOT dependency.

Why are the changes needed?

SNAPSHOT dependencies make local builds awkward and release build policies typically don't allow them.

Does this PR introduce any user-facing change?

No, Apache Directory Server is only used for tests.

Is the change a dependency upgrade?

Yes, but it's test only

How was this patch tested?

I built locally

@pan3793
Copy link
Member Author

pan3793 commented Jul 17, 2023

ping @sunchao

@sunchao sunchao changed the title [HIVE-26880][2.3] Upgrade Apache Directory Server to 1.5.7 HIVE-26880: [2.3] Upgrade Apache Directory Server to 1.5.7 Jul 17, 2023
Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunchao sunchao merged commit c331f0c into apache:branch-2.3 Jul 17, 2023
@sunchao
Copy link
Member

sunchao commented Jul 17, 2023

Merged, thanks @pan3793 . BTW: please follow Hive-style PR title in future: "HIVE-XXXXX: PR title".

@pan3793
Copy link
Member Author

pan3793 commented Jul 18, 2023

@sunchao got it, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants