HIVE-20682: Async query execution can potentially fail if shared sessionHive is closed by master thread. #452
Conversation
sankarh
force-pushed
the
HIVE-20682
branch
8 times, most recently
from
bc21f49
to
11d589d
Compare
| this.get().close(); | ||
| public synchronized void set(Hive hiveObj) { | ||
| Hive currentHive = this.get(); | ||
| if ((currentHive == null) || (currentHive != hiveObj)) { |
There was a problem hiding this comment.
i think this check ((currentHive == null) ) is not required
| if (hiveDb != null && hiveDb != parentHive) { | ||
| // If new hive object is created by the child thread, then we need to close it as it might | ||
| // have created a hms connection. Call Hive.closeCurrent() that closes the HMS connection, causes | ||
| // HMS connection leaks otherwise. |
There was a problem hiding this comment.
i think this check is required as we can not gurantee that parent hive object is session hive object
There was a problem hiding this comment.
When I create sessionHive, I set the allowClose flag to false. So, even if I try to invoke close on sessionHive via closeCurrent, it will be no-op and doesn't close it. So, this check is not needed.
There was a problem hiding this comment.
i am not sure if we can safely assume that BackgroundWork is always called with session hive
There was a problem hiding this comment.
Currently, it is always sessionHive and for any custom implementation is there, I will add a comment in BackgroundWork for parentHive to use it correctly. Also, shall add an assert to verify it before setting it in async thread.
sankarh
force-pushed
the
HIVE-20682
branch
5 times, most recently
from
b8d08f1
to
af6e32b
Compare
No description provided.