HIVE-28053: Incorrect shading configuration for beeline jar-with-dependencies #5056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndencies 1. Remove descriptorRefs cause it is not valid configuration parameter for maven-shade-plugin and has no effect on the build. 2. Set correct mainClass in the MANIFEST file making the jar runnable without extra options and avoid errors due to missing jmh class.
aturoczy
approved these changes
Feb 1, 2024
|
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Feb 9, 2024
…ndencies (Stamatis Zampetakis reviewed by Alessandro Solimando, Attila Turoczy) 1. Remove descriptorRefs cause it is not valid configuration parameter for maven-shade-plugin and has no effect on the build. 2. Set correct mainClass in the MANIFEST file making the jar runnable without extra options and avoid errors due to missing jmh class. Close apache#5056
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Mar 7, 2024
…ndencies (Stamatis Zampetakis reviewed by Alessandro Solimando, Attila Turoczy) 1. Remove descriptorRefs cause it is not valid configuration parameter for maven-shade-plugin and has no effect on the build. 2. Set correct mainClass in the MANIFEST file making the jar runnable without extra options and avoid errors due to missing jmh class. Close apache#5056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request and why?
Does this PR introduce any user-facing change?
Is the change a dependency upgrade?
No
How was this patch tested?
Build and then run: