Skip to content

Commit

Permalink
HIVE-28053: Incorrect shading configuration for beeline jar-with-depe…
Browse files Browse the repository at this point in the history
…ndencies (Stamatis Zampetakis reviewed by Alessandro Solimando, Attila Turoczy)

1. Remove descriptorRefs cause it is not valid configuration parameter for maven-shade-plugin and has no effect on the build.
2. Set correct mainClass in the MANIFEST file making the jar runnable without extra options and avoid errors due to missing jmh class.

Close apache#5056
  • Loading branch information
zabetak authored and dengzhhu653 committed Mar 7, 2024
1 parent e9a58a8 commit 615a844
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions beeline/pom.xml
Expand Up @@ -243,14 +243,11 @@
<goal>shade</goal>
</goals>
<configuration>
<descriptorRefs>
<descriptorRef>jar-with-dependencies</descriptorRef>
</descriptorRefs>
<finalName>jar-with-dependencies</finalName>
<transformers>
<transformer implementation="com.github.edwgiz.mavenShadePlugin.log4j2CacheTransformer.PluginsCacheFileTransformer"/>
<transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
<mainClass>org.openjdk.jmh.Main</mainClass>
<mainClass>org.apache.hive.beeline.BeeLine</mainClass>
</transformer>
</transformers>
<filters>
Expand Down

0 comments on commit 615a844

Please sign in to comment.