Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIVE-28330: Fix a typo in the example output of UDFHex #5296

Merged
merged 2 commits into from
Jun 18, 2024
Merged

HIVE-28330: Fix a typo in the example output of UDFHex #5296

merged 2 commits into from
Jun 18, 2024

Conversation

yaooqinn
Copy link
Member

What changes were proposed in this pull request?

Fix a typo in the example output of UDFHex

Why are the changes needed?

doc fix

Does this PR introduce any user-facing change?

no

Is the change a dependency upgrade?

no

How was this patch tested?

I test this with 4.0.0

docker exec -it hiveserver2 beeline -u 'jdbc:hive2://localhost:10000/'  -e "select hex(17)"

+------+
| _c0  |
+------+
| 11   |
+------+

@yaooqinn yaooqinn closed this Jun 14, 2024
@yaooqinn yaooqinn reopened this Jun 14, 2024
@zhangbutao
Copy link
Contributor

@yaooqinn Could you please create a ticket in https://issues.apache.org/jira/projects/HIVE/issues as well?

@yaooqinn yaooqinn changed the title Typo: Fix example output of UDFHex HIVE-28330: Fix a typo in the example output of UDFHex Jun 14, 2024
@yaooqinn
Copy link
Member Author

Hi @zhangbutao, thank you for the reminder, I have filed the ticket and attached it to the PR title.

zhangbutao
zhangbutao approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@zhangbutao zhangbutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 waiting a green pass.

@zhangbutao
Copy link
Contributor

https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5296/2/tests Please fix the output of udf_hex.q as well.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@zhangbutao zhangbutao merged commit b38888d into apache:master Jun 18, 2024
5 checks passed
@yaooqinn yaooqinn deleted the hex branch June 18, 2024 03:17
@yaooqinn
Copy link
Member Author

Thank you @zhangbutao for the review.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangbutao zhangbutao zhangbutao approved these changes

Assignees
No one assigned
Labels
tests passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yaooqinn @zhangbutao @asf-ci-hive