Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIVE-23030 ds rollup union #960

Closed
wants to merge 124 commits into from
Closed

HIVE-23030 ds rollup union #960

wants to merge 124 commits into from

Conversation

kgyrtkirk
Copy link
Member

No description provided.

kgyrtkirk and others added 30 commits February 19, 2020 14:41
jcamachor
jcamachor reviewed Mar 25, 2020
View reviewed changes
ql/src/test/queries/clientpositive/sketches_rollup.q Outdated Show resolved Hide resolved
ql/src/test/queries/clientpositive/sketches_rollup.q Outdated Show resolved Hide resolved
ql/src/test/queries/clientpositive/sketches_rollup.q Outdated Show resolved Hide resolved
ql/src/test/queries/clientpositive/sketches_rollup.q Outdated Show resolved Hide resolved
ql/src/test/queries/clientpositive/sketches_rollup.q Outdated Show resolved Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java Outdated Show resolved Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java Outdated Show resolved Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/functions/HiveMergeablAggregate.java Outdated Show resolved Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/exec/DataSketchesFunctions.java Outdated Show resolved Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/exec/DataSketchesFunctions.java Outdated Show resolved Hide resolved
@b-slim
Copy link
Contributor

b-slim commented Mar 30, 2020

@kgyrtkirk great work ! did you plan to add support for cases where users want to plug the error rates / sketches size ?

@kgyrtkirk
Copy link
Member Author

@kgyrtkirk great work ! did you plan to add support for cases where users want to plug the error rates / sketches size ?

I think if it's defined by hand (as argument to the ds_*_sketch function) - it will kinda work as-is.
For automatic rewriting these things are a bit unformed; in the next patch (HIVE-23031) there will be some pieces to give control over the sketch type/sketch size

@kgyrtkirk kgyrtkirk closed this May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcamachor jcamachor jcamachor left review comments

@b-slim b-slim b-slim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.