-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support aliyun oss as object store backend #20
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Four failing cases:
Update: all passed |
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
analytic_engine/src/setup.rs
Outdated
path: sst_path.to_string_lossy().into_owned(), | ||
})?; | ||
LocalFileSystem::new_with_prefix(sst_path).context(OpenObjectStore) | ||
async fn open_storage_local(config: Config) -> Result<LocalFileSystem> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better to use the struct in the StorageOptions::Local
as the paramater of this function?
analytic_engine/src/setup.rs
Outdated
} | ||
} | ||
|
||
async fn open_storage_aliyun(config: Config) -> Result<impl ObjectStore> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better to use the struct in the StorageOptions::Aliyun as the paramater of this function?
components/object_store/Cargo.toml
Outdated
upstream = { package = "object_store", version = "0.1.0" } | ||
# oss-rust-sdk = "0.4.0" | ||
oss-rust-sdk = { git = "https://github.com/NoXF/oss-rust-sdk.git", rev = "260e6fc95e06739fc33927a8b575896088a65966" } | ||
snafu = { version = "0.6.10", features = ["backtraces"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a newline?
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: impl object store interface for aliyun oss Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * add storage options Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * license header Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * CR refines Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia waynestxia@gmail.com
Which issue does this PR close?
Closes #19
Rationale for this change
See #19
What changes are included in this PR?
ObjectStore
implementorAliyunOSS
Are there any user-facing changes?
Config changed.
Removed:
analytical_engine::Config::data_path
Added:
analytical_engine::Config::storage
analytical_engine::Config::wal_path
How does this change test
Run unit test on a private aliyun OSS deployment.