2.4.x mod_deflate cleanups #423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1619448 13f79535-47bb-0310-9956-ffa450edef68 (cherry picked from commit 3093948)
- fix signed/unsigned (int/size_t) comparisons, - add consume_buffer() to factorize code used multiple times, - cleanup passed brigade (don't rely on next output filters to do it). git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1619486 13f79535-47bb-0310-9956-ffa450edef68 (cherry picked from commit 2b94587)
the input brigade even if done inflating (ctx->done is true), but don't try to flush the inflate stream in that case. (Caught by Coverity) Github: closes apache#280 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1895552 13f79535-47bb-0310-9956-ffa450edef68 (cherry picked from commit 6aef687)
apr_bucket_read() errors. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1894152 13f79535-47bb-0310-9956-ffa450edef68 (cherry picked from commit c1a2dfc)
Submitted by: Eric Norris <enorris etsy.com> Github: closes apache#387 git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1914800 13f79535-47bb-0310-9956-ffa450edef68 (cherry picked from commit 4889f66)
notroj
force-pushed
the
2.4.x-deflate-cleanups
branch
from
44f4421
to
82a2fb7
Compare
asfgit
pushed a commit
that referenced
this pull request
Mar 26, 2024
leave a hint while scrolling through inflate() calls mod_deflate: - fix signed/unsigned (int/size_t) comparisons, - add consume_buffer() to factorize code used multiple times, - cleanup passed brigade (don't rely on next output filters to do it). * modules/filters/mod_deflate.c (deflate_in_filter): Handle FLUSH in the input brigade even if done inflating (ctx->done is true), but don't try to flush the inflate stream in that case. (Caught by Coverity) * modules/filters/mod_deflate.c (deflate_out_filter): Catch apr_bucket_read() errors. mod_deflate: remove filter after seeing EOS Github: closes #423 Submitted by: covener, ylavic, jorton, Eric Norris <enorris etsy.com> Reviewed by: jorton, gbechis, ylavic git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1916557 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.