[HUDI-995] Migrate HoodieTestUtils APIs to HoodieTestTable #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xushiyan
force-pushed
the
migrate-to-HoodieTestTable
branch
5 times, most recently
from
6fb5d84
to
3be9ec7
Compare
Remove APIs in `HoodieTestUtils` - listAllDataFilesAndLogFilesInPath - listAllLogFilesInPath - listAllDataFilesInPath - writeRecordsToLogFiles - createCleanFiles - createPendingCleanFiles Migrate the callers to use `HoodieTestTable` and `HoodieWriteableTestTable` with new APIs added - listAllBaseAndLogFiles - listAllLogFiles - listAllBaseFiles - withLogAppends - addClean - addInflightClean Also added related APIs in `FileCreateUtils` - createCleanFile - createRequestedCleanFile - createInflightCleanFile
xushiyan
force-pushed
the
migrate-to-HoodieTestTable
branch
from
3be9ec7
to
1d9dac8
Compare
|
@yanghua this should be the 2nd last PR of this migration. Thanks. |
xushiyan
commented
Oct 5, 2020
Comment on lines
164
to
181
| private void appendRecordsToLogFile(List<HoodieRecord> groupedRecords) throws Exception { | ||
| String partitionPath = groupedRecords.get(0).getPartitionPath(); | ||
| HoodieRecordLocation location = groupedRecords.get(0).getCurrentLocation(); | ||
| try (HoodieLogFormat.Writer logWriter = HoodieLogFormat.newWriterBuilder().onParentPath(new Path(basePath, partitionPath)) | ||
| .withFileExtension(HoodieLogFile.DELTA_EXTENSION).withFileId(location.getFileId()) | ||
| .overBaseCommit(location.getInstantTime()).withFs(fs).build()) { | ||
| Map<HoodieLogBlock.HeaderMetadataType, String> header = new HashMap<>(); | ||
| header.put(HoodieLogBlock.HeaderMetadataType.INSTANT_TIME, location.getInstantTime()); | ||
| header.put(HoodieLogBlock.HeaderMetadataType.SCHEMA, schema.toString()); | ||
| logWriter.appendBlock(new HoodieAvroDataBlock(groupedRecords.stream().map(r -> { | ||
| try { | ||
| GenericRecord val = (GenericRecord) r.getData().getInsertValue(schema).get(); | ||
| HoodieAvroUtils.addHoodieKeyToRecord(val, r.getRecordKey(), r.getPartitionPath(), ""); | ||
| return (IndexedRecord) val; | ||
| } catch (IOException e) { | ||
| return null; | ||
| } | ||
| }).collect(Collectors.toList()), header)); |
There was a problem hiding this comment.
refer to hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestUtils.java#writeRecordsToLogFiles
xushiyan
commented
Oct 5, 2020
Comment on lines
-355
to
+404
| public List<FileStatus> listAllFilesInTempFolder() throws IOException { | ||
| return FileSystemTestUtils.listRecursive(fs, new Path(Paths.get(basePath, HoodieTableMetaClient.TEMPFOLDER_NAME).toString())); | ||
| public FileStatus[] listAllFilesInTempFolder() throws IOException { | ||
| return FileSystemTestUtils.listRecursive(fs, new Path(Paths.get(basePath, HoodieTableMetaClient.TEMPFOLDER_NAME).toString())).toArray(new FileStatus[0]); |
There was a problem hiding this comment.
change to return array to work with HoodieTableFileSystemView APIs which take in array
|
@xushiyan Sorry for the late reply, the past week was during the National Day holiday, you know. Will review tomorrow. |
yanghua
reviewed
Oct 9, 2020
...ient/hudi-spark-client/src/test/java/org/apache/hudi/testutils/HoodieWriteableTestTable.java
Outdated
Show resolved
Hide resolved
...ient/hudi-spark-client/src/test/java/org/apache/hudi/testutils/HoodieWriteableTestTable.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2143 +/- ##
============================================
+ Coverage 47.38% 53.61% +6.23%
- Complexity 2567 2845 +278
============================================
Files 358 359 +1
Lines 16484 16535 +51
Branches 1767 1777 +10
============================================
+ Hits 7811 8866 +1055
+ Misses 8032 6912 -1120
- Partials 641 757 +116
Flags with carried forward coverage won't be shown. Click here to find out more. |
prashantwason
pushed a commit
to prashantwason/incubator-hudi
that referenced
this pull request
Feb 22, 2021
* [HUDI-995] Migrate HoodieTestUtils APIs to HoodieTestTable Remove APIs in `HoodieTestUtils` - listAllDataFilesAndLogFilesInPath - listAllLogFilesInPath - listAllDataFilesInPath - writeRecordsToLogFiles - createCleanFiles - createPendingCleanFiles Migrate the callers to use `HoodieTestTable` and `HoodieWriteableTestTable` with new APIs added - listAllBaseAndLogFiles - listAllLogFiles - listAllBaseFiles - withLogAppends - addClean - addInflightClean Also added related APIs in `FileCreateUtils` - createCleanFile - createRequestedCleanFile - createInflightCleanFile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove APIs in
HoodieTestUtilsMigrate the callers to use
HoodieTestTableandHoodieWriteableTestTablewith new APIs addedAlso added related APIs in
FileCreateUtilsCommitter checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.