[HUDI-1685] keep updating current date for every batch #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akanungoz we need to file a bug and link the ticket id to this. |
akanungoz
changed the title
xushiyan
approved these changes
Mar 12, 2021
...ities/src/main/java/org/apache/hudi/utilities/sources/helpers/DatePartitionPathSelector.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2671 +/- ##
=============================================
+ Coverage 52.00% 69.43% +17.42%
+ Complexity 3579 363 -3216
=============================================
Files 465 53 -412
Lines 22268 1963 -20305
Branches 2375 235 -2140
=============================================
- Hits 11581 1363 -10218
+ Misses 9676 466 -9210
+ Partials 1011 134 -877
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
When current date is not specified as config setting, the current system date should keep getting updated and should not be initialized in the constructor
Brief change log
Verify this pull request
There exists tests for this code already (https://github.com/apache/hudi/blob/master/hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestDatePartitionPathSelector.java#L193)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.