[HUDI-5228] Flink table service job fs view conf overwrites the one o… #7214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * configuration {@code conf}. | ||
| */ | ||
| @SuppressWarnings("rawtypes") | ||
| public static HoodieFlinkWriteClient createWriteClientV2(Configuration conf) { |
There was a problem hiding this comment.
Can you add a parameter to determine whether to override the configuration, the name is still createWriteClient?
There was a problem hiding this comment.
Name it createWriteClientV2 instead of adding a param here.
XuQianJin-Stars
approved these changes
Nov 16, 2022
satishkotha
pushed a commit
to satishkotha/incubator-hudi
that referenced
this pull request
Dec 12, 2022
danny0405
added a commit
to danny0405/hudi
that referenced
this pull request
Dec 15, 2022
…f writing job (apache#7214) (cherry picked from commit dc5cc08)
nsivabalan
pushed a commit
that referenced
this pull request
Dec 16, 2022
* [HUDI-5007] Prevent Hudi from reading the entire timeline's when performing a LATEST streaming read (#6920) (cherry picked from commit 6baf733) * [HUDI-5228] Flink table service job fs view conf overwrites the one of writing job (#7214) (cherry picked from commit dc5cc08) Co-authored-by: voonhous <voonhousu@gmail.com>
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…f writing job
Change Logs
The table service job generates a fresh new fs view storage conf that overwrites the writing job. This could cause the writing job to failover.
Impact
No impact.
Risk level (write none, low medium or high below)
none
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist