Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-5987] Fix clustering on bootstrap tables non row writer #8289

Closed
wants to merge 2 commits into from

Conversation

jonvex
Copy link
Contributor

@jonvex jonvex commented Mar 25, 2023

Change Logs

Fixes clustering on bootstrapped tables with and without row-writer. There are two issues:

  1. Clustering strategy added bootstrap as well as source paths to the glob paths. This was causing an error, as mentioned in HUDI-5891, while building file index. There is no need to add source path as that is handled in HoodieBootstrapRDD.
  2. Sometimes the path will have scheme and sometimes it will be without scheme, so getting the relative partition path based was buggy. Corrected that in HoodieBootstrapRelation.

Impact

No public API change. A bug fix for the bootstrap path.

Risk level (write none, low medium or high below)

low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@codope codope changed the title [HUDI-5891] fix clustering on bootstrap tables. Row-writer disabled does not work… [HUDI-5891] Fix clustering on bootstrap tables Mar 25, 2023
@codope codope added priority:critical production down; pipelines stalled; Need help asap. table-service bootstrap labels Mar 25, 2023
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@jonvex jonvex changed the title [HUDI-5891] Fix clustering on bootstrap tables [HUDI-5987] Fix clustering on bootstrap tables non row writer Mar 27, 2023
@codope
Copy link
Member

codope commented Apr 4, 2023

Closing in favor of #8342

@codope codope closed this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootstrap priority:critical production down; pipelines stalled; Need help asap. table-service
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants