Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Remove link to Flink unit test #10160

Merged
merged 1 commit into from
May 6, 2024
Merged

Docs: Remove link to Flink unit test #10160

merged 1 commit into from
May 6, 2024

Conversation

manuzhang
Copy link
Contributor

@manuzhang manuzhang commented Apr 17, 2024 •
edited
Loading

The link to flink 1.16 unit test is broken after #10154. I remove it in this PR since

  1. I don't see an example of write generic DataStream to iceberg table from the unit test as the doc stated
  2. We don't trigger links check on source code changes so it will break next if we only update the link to latest version

The PR also adds docs/site to .gitignore file.

cc @nastra @pvary @rodmeneses @Fokko

@manuzhang manuzhang mentioned this pull request Apr 17, 2024
Merged
@pvary
Copy link
Contributor

pvary commented Apr 17, 2024

@manuzhang: Could you please rebase?

@manuzhang
Copy link
Contributor Author

@pvary @nastra any more comments?

Fokko
Fokko approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @manuzhang

@Fokko Fokko merged commit ed84ea0 into apache:main May 6, 2024
3 checks passed
@manuzhang manuzhang deleted the fix-flink-doc branch June 4, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Fokko approved these changes

@pvary pvary pvary approved these changes

Assignees
No one assigned
Labels
docs INFRA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manuzhang @pvary @Fokko