Core: Upgrade Jetty and Servlet API #10850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the latest Jetty version that runs with JDK11
findepi
approved these changes
Aug 2, 2024
| jaxb-api = "2.3.1" | ||
| jaxb-runtime = "2.3.9" | ||
| jetty = "9.4.55.v20240627" | ||
| jetty = "11.0.22" |
There was a problem hiding this comment.
Worth adding code comment like "this is the latest Jetty version that runs with JDK11" here?
There was a problem hiding this comment.
we have a bunch of dependencies like this where we're at the latest version for the JDK we're running with, so I don't think it's worth adding such a comment just here.
That being said, we might actually need to re-visit and see if we're still at the latest version of each dependency for JDK11 now (I'll open a separate issue to tackle that, since dependabot doesn't take the JDK version into account)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're on JDK11 we can bump Jetty and the underlying Servlet API being used. Note that this is the latest Jetty version that runs with JDK11